[PATCH 5/9] examples: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- examples/nettime.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/nettime.c

[PATCH 6/9] gatchat: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gatchat/gatchat.c | 46 +++--- gatchat/gathdlc.c |8

[PATCH 7/9] gdbus: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gdbus/object.c | 24 gdbus/polkit.c |2 +- gdbus/watch.c | 21 ++--- 3

[PATCH 8/9] plugins: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- plugins/bluetooth.c |6 +++--- plugins/calypso.c |4 ++-- plugins/hfp.c | 20

Re: [PATCH 1/9] coding-style: add rule about checking NULL pointer

On Sat, Nov 27, 2010 at 1:57 PM, rajesh.naga...@elektrobit.com wrote: +3) +array = g_try_new0(int, 20); +if (!array)  // Correct Shouldn't be if (array == NULL) // Correct :)? You are right. Thanks, fixed. Lucas De Marchi ___ ofono mailing list

[PATCH 1/2] phonesim: implement ctm atom

--- plugins/phonesim.c | 150 ++-- 1 files changed, 146 insertions(+), 4 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index d2faf42..d10eda8 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -46,6 +46,7 @@ #include

[PATCH 2/2] TODO: Mark CTM task as done

manufacturer specific commands - are required. - - Priority: High - Complexity: C1 - Owner: Lucas De Marchi lucas.demar...@profusion.mobi - - Add support for GPS power control atom. Many modem manufacturers provide a GPS unit with their modem hardware. This unit can be turned on or off

[PATCH 1/9] coding-style: add rule about checking NULL pointer

--- doc/coding-style.txt | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index eccdacc..9dfdc09 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -209,6 +209,27 @@ However if the enum comes

[PATCH 4/9] gisi: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gisi/client.c | 46 +++--- gisi/iter.c |2 +- gisi/server.c |6

[PATCH 5/9] examples: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- examples/nettime.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/nettime.c

[PATCH 6/9] gatchat: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gatchat/gatchat.c | 46 +++--- gatchat/gathdlc.c |8

[PATCH 7/9] gdbus: explicitly compare pointers to NULL

This patch was generated by the following semantic patch (http://coccinelle.lip6.fr/) // smpl @fix disable is_null,isnt_null1@ expression *E; @@ - !E + E == NULL // /smpl --- gdbus/object.c | 24 gdbus/polkit.c |2 +- gdbus/watch.c | 21 ++--- 3

Re: [PATCH v2 4/7] text-telephony: implement interface/atom

this very hard.  In the single property case it is doable, but I'm fine accepting this part as is.  So feel free to ignore this feedback. HUmn... If this is the correct approach, I'm ok with doing it. regards, Lucas De Marchi ___ ofono mailing list

[PATCH 2/5] text-telephony: implement interface/atom

--- Makefile.am |2 +- src/ctm.c | 334 +++ src/ofono.h |2 + 3 files changed, 337 insertions(+), 1 deletions(-) create mode 100644 src/ctm.c diff --git a/Makefile.am b/Makefile.am index 2615be7..93db7ea 100644 --- a/Makefile.am

[PATCH 3/5] text-telephony: add documentation

--- Makefile.am|2 +- doc/text-telephony-api.txt | 39 +++ 2 files changed, 40 insertions(+), 1 deletions(-) create mode 100644 doc/text-telephony-api.txt diff --git a/Makefile.am b/Makefile.am index 93db7ea..77965d4 100644 ---

[PATCH 5/5] Add script to enable/disable text-telephony support

--- test/set-tty | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100755 test/set-tty diff --git a/test/set-tty b/test/set-tty new file mode 100755 index 000..67876af --- /dev/null +++ b/test/set-tty @@ -0,0 +1,25 @@ +#!/usr/bin/python +

Re: [PATCH v2 4/7] text-telephony: implement interface/atom

Hi Denis, On Wed, Nov 24, 2010 at 1:58 PM, Denis Kenzior denk...@gmail.com wrote: Hi Lucas, On 11/23/2010 12:04 PM, Lucas De Marchi wrote: ---  Makefile.am          |    2 +-  src/ofono.h          |    2 +  src/text-telephony.c |  341

Add text telephony support

Second version of this patch series adds support for text telephony. Difference from previous patch: o As requested, now this patch is split in a per-directory basis; o Fixed documentation about the Errors that might be returned o Add documentation to build system

[PATCH v2 1/7] text-telephony: add public header

--- Makefile.am |3 +- include/text-telephony.h | 71 ++ 2 files changed, 73 insertions(+), 1 deletions(-) create mode 100644 include/text-telephony.h diff --git a/Makefile.am b/Makefile.am index f841b4c..fb075a0 100644 ---

[PATCH v2 2/7] text-telephony: define new dbus interface

--- include/dbus.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/dbus.h b/include/dbus.h index 59b2aae..9e29afb 100644 --- a/include/dbus.h +++ b/include/dbus.h @@ -48,6 +48,7 @@ extern C { #define OFONO_PHONEBOOK_INTERFACE org.ofono.Phonebook #define

[PATCH v2 3/7] text-telephony: add new interface to feature map

--- src/modem.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index cfc767e..f032d93 100644 --- a/src/modem.c +++ b/src/modem.c @@ -904,6 +904,7 @@ static const struct { { OFONO_SIM_MANAGER_INTERFACE, sim }, {

[PATCH v2 4/7] text-telephony: implement interface/atom

--- Makefile.am |2 +- src/ofono.h |2 + src/text-telephony.c | 341 ++ 3 files changed, 344 insertions(+), 1 deletions(-) create mode 100644 src/text-telephony.c diff --git a/Makefile.am b/Makefile.am index

[PATCH v2 5/7] text-telephony: add documentation

--- Makefile.am|2 +- doc/text-telephony-api.txt | 39 +++ 2 files changed, 40 insertions(+), 1 deletions(-) create mode 100644 doc/text-telephony-api.txt diff --git a/Makefile.am b/Makefile.am index ee1313d..e231457 100644 ---

[PATCH v2 6/7] phonesim: implement text-telephony atom

--- plugins/phonesim.c | 148 ++-- 1 files changed, 144 insertions(+), 4 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index d2faf42..8c31df4 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -54,6 +54,7 @@ #include

[PATCH v2 7/7] Add script to enable/disable text-telephony support

--- test/set-tty | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100755 test/set-tty diff --git a/test/set-tty b/test/set-tty new file mode 100755 index 000..cbbb043 --- /dev/null +++ b/test/set-tty @@ -0,0 +1,25 @@ +#!/usr/bin/python +

[PATCH] radio-settings: update doc with possible errors

When GetProperties() and SetProperty() are called, there are more errors that might be returned. Add them in documentation. --- doc/radio-settings-api.txt |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/doc/radio-settings-api.txt b/doc/radio-settings-api.txt index

[PATCH] TODO: add owner to Frequency Band Selection task

De Marchi lucas.demar...@profusion.mobi This feature is not discussed in 27.007, thus manufacturer specific commands are required. -- 1.7.3.2 ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/3] Add TTY (hearing impaired) support

here what is the best name. Seems that Marcel prefers Powered though. Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 1/3] Add TTY (hearing impaired) support

--- Makefile.am|5 +- doc/text-telephony-api.txt | 38 + include/dbus.h |1 + include/text-telephony.h | 71 ++ src/modem.c|1 + src/ofono.h|2 + src/text-telephony.c | 333

Re: [PATCH 1/3] Add TTY (hearing impaired) support

sending again with the docs. regards Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: [PATCH 1/3] Add TTY (hearing impaired) support

On Thu, Nov 18, 2010 at 9:26 AM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: +                       Changes the value of the specified property. Only +                       properties that are listed as read-write are A minor issue I found with other docs, it's written here as read

[PATCH 1/3] Add TTY (hearing impaired) support

--- Makefile.am |5 +- include/dbus.h |1 + include/text-telephony.h | 71 ++ src/modem.c |1 + src/ofono.h |2 + src/text-telephony.c | 333 ++ 6 files changed, 411

[PATCH] Add responses for TTY commands

--- src/default.xml | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/src/default.xml b/src/default.xml index e16e18d..216b2b8 100644 --- a/src/default.xml +++ b/src/default.xml @@ -301,6 +301,9 @@ !-- CGSMS Bearer control -- set name=CGSMS

[PATCH 2/3] phonesim: implement TTY interface

--- plugins/phonesim.c | 148 ++-- 1 files changed, 144 insertions(+), 4 deletions(-) diff --git a/plugins/phonesim.c b/plugins/phonesim.c index d2faf42..8c31df4 100644 --- a/plugins/phonesim.c +++ b/plugins/phonesim.c @@ -54,6 +54,7 @@ #include

[PATCH 3/3] Add script to enable/disable TTY support

--- test/set-tty | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) create mode 100755 test/set-tty diff --git a/test/set-tty b/test/set-tty new file mode 100755 index 000..cbbb043 --- /dev/null +++ b/test/set-tty @@ -0,0 +1,25 @@ +#!/usr/bin/python +

[PATCH] TODO: add owner to TTY support

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index a5196f7..1dcca92 100644 --- a/TODO +++ b/TODO @@ -474,6 +474,7 @@ Miscellaneous Priority: High Complexity: C1 + Owner: Lucas De Marchi lucas.demar...@profusion.mobi - Add support

[PATCH] Fix build outside of tree after linker script change

Let configure generate connman.ver file and copy it to the build directory. --- .gitignore |1 + configure.ac |2 +- src/ofono.ver|7 --- src/ofono.ver.in |7 +++ 4 files changed, 9 insertions(+), 8 deletions(-) delete mode 100644 src/ofono.ver create mode

Re: [PATCH] Fix common misspellings

. regards Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH] Fix common misspellings

-proprietary reponsible-responsible seperately-separately subsidary(-ies)-subsidiary(-ies) succeded-succeeded targetted-targeted transfering-transferring witheld-withheld withold-withhold Signed-off-by: Lucas De Marchi lucas.demar...@profusion.mobi --- TODO|4 ++-- doc/call

Re: [PATCH] Fix common misspellings

in documentation + changes in source files. thanks regards, Lucas De Marchi ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 1/6] Fix common misspellings in documentation

Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspellings: accomodate-accommodate targetted-targeted transfering-transferring

[PATCH 2/6] Fix common misspellings in drivers

Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspellings: subsidary(-ies)-subsidiary(-ies) transfering-transferring ---

[PATCH 3/6] Fix common misspellings in gatchat

Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspellings: priviledge-privilege succeded-succeeded --- gatchat/gatppp.c |2

[PATCH 4/6] Fix common misspelling in gisi

Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspelling: fomr-from --- gisi/client.c |2 +- gisi/server.c |2 +- 2 files

[PATCH 6/6] Fix common misspelling in source files

Fix common misspellings by using the list available at http://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines. From the list cited above, the substitution script found the following misspelling: reponsible-responsible --- src/util.c |2 +- 1 files changed, 1

<    1   2   3