[PATCH 1/1] Fix primary context active/deactive result d-bus reply missing issue

2011-04-27 Thread martin . xu
From: Martin Xu If user offline modem when the gprs_context is in enabling or disabling state(activating/disactivating), the GPRS primary context activate/disactivate result will not be replied to the corresponding application. --- drivers/atmodem/gprs-context.c |7 +++ src/gprs.c

[PATCH 1/1] Switch to offline mode only when the modem is NOT online

2011-04-26 Thread martin . xu
From: Martin Xu --- plugins/huawei.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 1f69a8c..5f2c47f 100644 --- a/plugins/huawei.c +++ b/plugins/huawei.c @@ -217,7 +217,8 @@ static gboolean notify_sim_state(struct ofono_modem

[PATCH 2/2] Check modem device open failure

2011-04-26 Thread martin . xu
From: Martin Xu disable gprs function if open modem device file failed, Otherwise, it will cause ofonod crash, due to gatchat is NULL. --- plugins/huawei.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/plugins/huawei.c b/plugins/huawei.c index 4051a93

[PATCH 1/2] Fix ofonod crash issue

2011-04-26 Thread martin . xu
From: Martin Xu In case of offline modem when GPRS data connection is connected, if gprs atom is removed before PPP termination process is complete, the terminate_timer will not be stop. It will cause ofonod crash when the timer time out. --- gatchat/ppp_cp.c |2 ++ 1 files changed, 2

[PATCH] Fix huawei_disconnect function issue

2011-03-08 Thread martin . xu
From: Martin Xu huawei_disconnect is used to recovery the io and gprs context when io error happends, see commit 39382730d7758b093ca6271f4e9dea875fa04b3a However, io error not only happends at PPP disconnect, in theory it can happends at any situation. I also observed that it happens when modem

[PATCH] Fix huawei_disconnect function issue

2011-03-03 Thread martin . xu
From: Martin Xu huawei_disconnect is used to recovery the io and gprs context when io error happends, see commit 39382730d7758b093ca6271f4e9dea875fa04b3a However, io error not only happends at PPP disconnect, in theory it can happends at any situation. I also observed that it happens when modem

[V3 PATCH 2/3] PPP: Use default ACCM (0xffffffff) to trasmit package

2011-02-14 Thread martin . xu
From: Martin Xu Using my Huawei EM770W modem, if set ACCM as 0x, RXJ- event breaks PPP link, after IP package transmit for a while. Using default ACCM, the issue can be fixed. I tested it at China Unicom networks. --- gatchat/ppp_lcp.c |8 +--- 1 files changed, 5 insertions

[V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-02-12 Thread martin . xu
From: Martin Xu Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP connection can't work --- plugins/ofono.rules |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index 111f071..7dec243 100644 --- a/pl

[V3 PATCH 2/3] PPP: Use default ACCM (0xffffffff) to trasmit package

2011-02-12 Thread martin . xu
From: Martin Xu Using my Huawei EM770W modem, if set ACCM as 0x, RXJ- event breaks PPP link, after IP package transmit for a while. Using default ACCM, the issue can be fixed. I tested it at China Unicom networks. --- gatchat/ppp_lcp.c |8 +--- 1 files changed, 5 insertions

[V3 PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

2011-02-12 Thread martin . xu
From: Martin Xu Tramsmit ACCM and receive ACCM is mixed up. According to RFC1662 Section 7.1, ACCM Configuration Option is used to inform the peer which control characters MUST remain mapped when the peer sends them. --- gatchat/ppp_lcp.c | 16 ++-- 1 files changed, 14 insertions

[PATCH 3/3] Huawei: set Huawei EM770W modem device to 00

2011-01-19 Thread martin . xu
From: Martin Xu Device 00 is ppp port. Setting it as 01, my Huawei EM770W modem PPP connection can't work --- plugins/ofono.rules |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/plugins/ofono.rules b/plugins/ofono.rules index 111f071..7dec243 100644 --- a/pl

[PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue

2011-01-19 Thread martin . xu
From: Martin Xu Tramsmit ACCM and receive ACCM is mixed up. According to RFC1662 Section 7.1, ACCM Configuration Option is used to inform the peer which control characters MUST remain mapped when the peer sends them. --- gatchat/ppp_lcp.c | 16 ++-- 1 files changed, 14 insertions

[PATCH 2/3] Use default ACCM (0xffffffff) to trasmit package

2011-01-19 Thread martin . xu
From: Martin Xu Using my Huawei EM770W modem, if set ACCM as 0x, RXJ- event breaks PPP link, after IP package transmit for a while. Using default ACCM, the issue can be fixed. I tested it at China Unicom networks. --- gatchat/ppp_lcp.c |9 ++--- 1 files changed, 6 insertions

[PATCH 2/2] Inform Huawei modem using ACCM 0xffffffff to trasmit package. Using my Huawei modem (EM770W) if set ACCM as 0x00000000, the RXJ- event will happend, and PPP link down, when IP package tran

2011-01-10 Thread martin . xu
From: Martin Xu --- gatchat/ppp_lcp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c index bc97257..181bc14 100644 --- a/gatchat/ppp_lcp.c +++ b/gatchat/ppp_lcp.c @@ -106,7 +106,7 @@ static void lcp_generate_config_options

[PATCH 1/2] PPP: Fix Transmit ACCM and Receive ACCM setting error

2011-01-10 Thread martin . xu
From: Martin Xu --- gatchat/ppp_lcp.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c index 3a80a62..bc97257 100644 --- a/gatchat/ppp_lcp.c +++ b/gatchat/ppp_lcp.c @@ -149,7 +149,11 @@ static void lcp_rca(struct

[PATCH 0/2] fix ACCM handle issue for Huawei EM770W modem

2011-01-10 Thread martin . xu
From: Martin Xu [PATCH 1/2] PPP: Fix Trasmit ACCM and Receive ACCM setting error according to RFC 1662 section 7.2, looks like oFono has set receive and transmit ACCM wrongly. normally the two ACCM are both set as 0x, and the issue will not be found. Once the they are different

[PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread martin . xu
From: Martin Xu --- src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static gboolean

[PATCH] Fix compile warning at MeeGo The gcc version is MeeGo 4.5.1

2011-01-06 Thread martin . xu
From: blutolan --- src/call-forwarding.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/call-forwarding.c b/src/call-forwarding.c index 512f223..36ba4f1 100644 --- a/src/call-forwarding.c +++ b/src/call-forwarding.c @@ -246,7 +246,7 @@ static gboolean is_cfu_enable

[PATCH 1/1] Install default.xml file to /usr/share/phonesim

2010-03-14 Thread Martin Xu
--- Makefile.am |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index fcee5e6..34198a5 100644 --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,9 @@ INCLUDES = -I$(top_srcdir)/src -I$(top_builddir)/src CLEANFILES = src/control.moc $(nodist_sr

[PATCH 1/1] install data files

2010-03-09 Thread Martin Xu
--- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index fcee5e6..0f4fe7b 100644 --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,7 @@ INCLUDES = -I$(top_srcdir)/src -I$(top_builddir)/src CLEANFILES = src/control.moc $(nodist_src_

[PATCH 1/1] install data file

2010-03-09 Thread Martin Xu
--- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index fcee5e6..007d5b9 100644 --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,7 @@ INCLUDES = -I$(top_srcdir)/src -I$(top_builddir)/src CLEANFILES = src/control.moc $(nodist_src_

[PATCH 1/1] set netmask for static ip on mbm

2009-12-15 Thread Martin Xu
--- drivers/mbmmodem/gprs-context.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/mbmmodem/gprs-context.c b/drivers/mbmmodem/gprs-context.c index 5dae7b5..407a2d3 100644 --- a/drivers/mbmmodem/gprs-context.c +++ b/drivers/mbmmodem/gprs-context.c @@ -48,6 +4

[PATCH 1/1] new modem desc for f3607g modem in Samos platform

2009-12-08 Thread Martin Xu
--- plugins/udev.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 243ce9b..8bb2d65 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -86,24 +86,30 @@ static void add_mbm(struct ofono_modem *modem, if (desc == NULL)

[PATCH 1/1] new modem desc for f3607g modem in Samos platform

2009-12-08 Thread Martin Xu
From: root --- plugins/udev.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index 243ce9b..8bb2d65 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -86,24 +86,30 @@ static void add_mbm(struct ofono_modem *modem, if (desc

[PATCH 1/1] Allow builds to install the test scripts for debugging

2009-12-03 Thread Martin Xu
--- Makefile.am |9 +++-- bootstrap-configure |1 + configure.ac|4 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 4b0d7e8..2a140c1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -231,7 +231,7 @@ doc_files = doc/o

[PATCH 1/1] emit settings signal before active signal

2009-11-21 Thread Martin Xu
--- src/gprs.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index b533209..57bb794 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -374,18 +374,19 @@ static void pri_activate_callback(const struct ofono_error *error, __ofono_dbus

[PATCH 5/5] update gprs context settings when activating primary conext

2009-11-17 Thread Martin Xu
--- drivers/mbmmodem/gprs-context.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/drivers/mbmmodem/gprs-context.c b/drivers/mbmmodem/gprs-context.c index ecbafa0..b800d4a 100644 --- a/drivers/mbmmodem/gprs-context.c +++ b/drivers/mbmmodem/gprs-context.c @@

[PATCH 4/5] add function ofono_gprs_context_get_modem

2009-11-17 Thread Martin Xu
--- include/gprs-context.h |2 ++ src/gprs.c |5 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index 8b860c2..95b2bae 100644 --- a/include/gprs-context.h +++ b/include/gprs-context.h @@ -79,6 +79,8 @@ void o

[PATCH 3/5] ofono_gprs_context_update_settings

2009-11-17 Thread Martin Xu
--- include/gprs-context.h |8 src/gprs.c | 26 ++ 2 files changed, 34 insertions(+), 0 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index c4ebd23..8b860c2 100644 --- a/include/gprs-context.h +++ b/include/gprs-contex

[PATCH 1/5] ignore the NULL dict entry

2009-11-17 Thread Martin Xu
--- src/dbus.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/dbus.c b/src/dbus.c index b74481f..942294e 100644 --- a/src/dbus.c +++ b/src/dbus.c @@ -134,6 +134,9 @@ static void append_dict_variant(DBusMessageIter *iter, int type, void *val)

[PATCH 2/5] emit PropertyChanged Settings signal after active/deactive primary context

2009-11-17 Thread Martin Xu
--- src/gprs.c | 115 1 files changed, 115 insertions(+), 0 deletions(-) diff --git a/src/gprs.c b/src/gprs.c index 0253109..a8d8afa 100644 --- a/src/gprs.c +++ b/src/gprs.c @@ -82,9 +82,19 @@ struct ofono_gprs { struct ofono_a

[PATCH 1/1] add Settings property description to dataconnectionmanger-api.txt

2009-11-15 Thread Martin Xu
--- doc/dataconnectionmanager-api.txt | 35 +++ 1 files changed, 23 insertions(+), 12 deletions(-) diff --git a/doc/dataconnectionmanager-api.txt b/doc/dataconnectionmanager-api.txt index 41fc02f..7afdf99 100644 --- a/doc/dataconnectionmanager-api.txt +++ b/doc/

[PATCH 4/4] add mbm_gprs_create/destroy_interface to mbm gprs_context_driver

2009-11-08 Thread Martin Xu
--- drivers/mbmmodem/gprs-context.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/drivers/mbmmodem/gprs-context.c b/drivers/mbmmodem/gprs-context.c index ecbafa0..d3e03b7 100644 --- a/drivers/mbmmodem/gprs-context.c +++ b/drivers/mbmmodem/gprs-contex

[PATCH 2/4] add create/destroy_interface to ofono_gprs_context_driver

2009-11-08 Thread Martin Xu
--- include/gprs-context.h |4 src/gprs.c | 20 ++-- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index adb0820..b8c770d 100644 --- a/include/gprs-context.h +++ b/include/gprs-context.h @@ -57

[PATCH 3/4] add function ofono_gprs_context_get_modem

2009-11-08 Thread Martin Xu
--- include/gprs-context.h |2 ++ src/gprs.c |5 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index b8c770d..2a788ef 100644 --- a/include/gprs-context.h +++ b/include/gprs-context.h @@ -76,6 +76,8 @@ void o

[PATCH 1/4] add interface property to primary context

2009-11-08 Thread Martin Xu
--- include/gprs-context.h |1 + src/gprs.c |4 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/gprs-context.h b/include/gprs-context.h index c4ebd23..adb0820 100644 --- a/include/gprs-context.h +++ b/include/gprs-context.h @@ -37,6 +37,7 @@ struct o

[PATCH 1/1] Use AT+CFUN? to query powered state

2009-11-04 Thread Martin Xu
--- plugins/mbm.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index fd4569c..602709d 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c @@ -187,6 +187,9 @@ static int mbm_enable(struct ofono_modem *modem)

index c2e9c41..6661074 100644

2009-11-04 Thread Martin Xu
___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 1/1] handle werid mbm card network name

2009-11-03 Thread Martin Xu
--- plugins/udev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/plugins/udev.c b/plugins/udev.c index c2e9c41..345613b 100644 --- a/plugins/udev.c +++ b/plugins/udev.c @@ -120,7 +120,8 @@ static void add_mbm(struct ofono_modem *modem, devnode = udev_de