[PATCH] Add CallBarring::ChangePassword for setting a new service password.

Depends on [PATCH] Teach USSD to recognise password change strings. --- src/call-barring.c | 158 ++-- src/driver.h |3 + 2 files changed, 144 insertions(+), 17 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index

[PATCH] Parse SIM alpha fields (EF-SPN) according to TS 11.11.

--- src/sim.c | 119 ++--- 1 files changed, 114 insertions(+), 5 deletions(-) diff --git a/src/sim.c b/src/sim.c index 8485e1e..a5d2164 100644 --- a/src/sim.c +++ b/src/sim.c @@ -199,6 +199,115 @@ static GDBusMethodTable

Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Sat, 1 Aug 2009 15:40:58 +0200 Subject: [PATCH] Add a MessageWaiting interface for tracking message waiting indications. The state of the indications is kept in memory and written back to the SIM after any changes. --- src/Makefile.am

[PATCH] Loop on EINTR returned from file io calls in sim.c

--- src/sim.c | 31 --- 1 files changed, 20 insertions(+), 11 deletions(-) diff --git a/src/sim.c b/src/sim.c index 90e8251..b437b75 100644 --- a/src/sim.c +++ b/src/sim.c @@ -23,6 +23,9 @@ #include config.h #endif +#define _GNU_SOURCE +#include unistd.h +

[PATCH] Implement writing EF-MBDN on SetProperty or Enhanced Voicemail IE.

I've not tested this on a real SIM yet. --- src/message-waiting.c | 51 src/simutil.c | 27 + src/simutil.h |2 + src/smsutil.c | 47 +---

Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

in SimManager would be good as well. Will get on it today. Regards From 4096f07b8b08005866ee69188763e5885574ed8c Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Wed, 5 Aug 2009 07:17:10 +0200 Subject: [PATCH] Use invalid_args instead of invalid_format --- src/call

Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

2009/8/5 Denis Kenzior denk...@gmail.com: Sorry I don't quite follow.  The mw_set_indicator function sets the value and emits the signals regardless of whether the MWIS file could be written.  Can you explain some more? For setting mailbox numbers, a working EF-MBDN is required since the only

[PATCH] Make SimManager property SubscriberNumbers writable.

This implements writing SubscriberNumbers if the SIM allows this (optional to the SIM provider). Because the property is an array of phone numbers, setting the property needs to write multiple records on the SIM so it's not atomic and potentially can fail partially. In this case we have to

Re: [PATCH 4/4] Add a MessageWaiting interface to track message waiting indications.

Hi, 2009/8/10 Denis Kenzior denk...@gmail.com: 2009/8/5 Denis Kenzior denk...@gmail.com: mw_set_indicator does the right thing, I missed this fact.  But when a mailbox number is set or received from network all clients get a PropertyChanged and the new number can be retrieved from the

Re: Read EFad and expose MNC length in IMSI as a SimManager property.

. Regards From 274297e45b1ad7536cdaf80c41af5a063411 Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Thu, 20 Aug 2009 18:01:07 +0200 Subject: [PATCH] Read EFad and expose MNC length in IMSI as a SimManager property. Alternatively we could expose the MNC

Fix getting the offset into sms fragment bitmap.

Otherwise only 64 fragments fit. --- src/smsutil.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index bae501e..fcff9aa 100644 --- a/src/smsutil.c +++ b/src/smsutil.c @@ -2132,7 +2132,7 @@ GSList *sms_assembly_add_fragment(struct

Re: Decode and encode alpha-identifier fields in EFadn format utils.

Attaching an updated patch. 2009/8/19 Andrzej Zaborowski andrew.zaborow...@intel.com: Also fix the number length passed to extract_bcd_number in sim_adn_parse. ---  src/message-waiting.c |    5 +++--  src/sim.c             |    5 +++--  src/simutil.c         |   42

Re: Read EFad and expose MNC length in IMSI as a SimManager property.

Attaching an updated patch. 2009/8/20 Andrzej Zaborowski andrew.zaborow...@intel.com: 2009/8/20 Gu, Yang yang...@intel.com: Several minor comments on this patch: 1. How about unify all the mnc_length to be unsigned char? 2. For this piece of code: +              value = new_mnc_length

Re: Expose service dialling numbers stored on SIM through SimManager.

for id uniqueness here? Thanks for the remarks, incorporated them in the patch and updated it to current. Regards From eaddaf02b27fb8f299a31851d9f1bbb52f5421cc Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Wed, 26 Aug 2009 04:27:04 +0200 Subject: [PATCH

Re: Read messages left over in ME storage on startup.

Hi, 2009/8/25 Denis Kenzior denk...@gmail.com: On Fri, Aug 21, 2009 at 9:35 PM, Andrzej Zaborowski andrew.zaborow...@intel.com wrote: On modems that don't support +CMT (or for class 2 SMSes) the messages are stored in the modem and then read and deleted from there in two separate steps

Re: Write state of SMS assembly to disk and restore on startup.

2009/9/1 Denis Kenzior denk...@gmail.com: On Fri, Aug 21, 2009 at 9:40 PM, Andrzej Zaborowski andrew.zaborow...@intel.com wrote: This way we can continue receiving segmented messages over a reset or crash. ---  src/common.c     |   29 +++  src/common.h     |   10 +++  src/sim.c

[PATCH] Keep modem-powered_pending up to date after set_powered.

Without this once a request to power up the modem fails, modem.c won't retry even when asked. --- src/modem.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/modem.c b/src/modem.c index ed6f870..5e6e582 100644 --- a/src/modem.c +++ b/src/modem.c @@ -462,6

Re: [PATCH] Present list of preferred languages on SimManager interface.

763a0b12a6636d7f1ec5be99d8fe24c5925c6678 Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Mon, 14 Sep 2009 21:25:05 +0200 Subject: [PATCH] Present list of preferred languages on SimManager interface. Patch made on top of [PATCH] Do the PIN check in SIMManager

Re: [PATCH] [RFC] Do the PIN check in SIMManager

7209a4406224a0c4f8ad1c241ea355ee00e1fb5b Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Thu, 17 Sep 2009 22:43:22 +0200 Subject: [PATCH 2/2] Do PIN authentication This adds checking whether PIN is required during SIM initialisation and delaying the sim ready notifications until after correct

Re: [PATCH] [RFC] Do the PIN check in SIMManager

Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Wed, 23 Sep 2009 23:17:06 +0200 Subject: [PATCH] Update sim-api.txt: ChangePin no longer disables pin. --- doc/sim-api.txt |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/doc/sim-api.txt

Re: [PATCH] Present list of preferred languages on SimManager interface.

2009/9/23 Denis Kenzior denk...@gmail.com: Hi Andrew, The only corner case where order is now different is when the first Sorry, I'm not following, can you elaborate?  If sim_efli_format encounters an empty entry it simply continues on... In 5.1.1.2 of 31.102, EFpl also takes precedence

Re: [PATCH] Present list of preferred languages on SimManager interface.

Hi Denis, 2009/9/24 Denis Kenzior denk...@gmail.com: I pushed a patch to simply ignore EFli if the first entry is 0x I moved the check a little up because at that point the raw EFli would have been freed already (see attached). Regards

[RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

Hi, here's a one-big-patch that adds the DataConnectionManager interface according to doc/dataconnectionmanager-api.txt without any glue for the multiplexer or PPP setup. Only AT backend is implemented. One issue with the AT implementation of the api is that Powered (a read-write property) can

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009/10/12 Andrzej Zaborowski andrew.zaborow...@intel.com: here's a one-big-patch that adds the DataConnectionManager interface according to doc/dataconnectionmanager-api.txt without any glue for the multiplexer or PPP setup.  Only AT backend is implemented. This patch depends on 0001 attached

Re-add Manager.Create / Remove

This is a small patch to revive Manager.Create and Manager.Remove that lets you create a modem over D-Bus dynamically, for example in python that could be: modem_path = manager.Create('phonesim', { 'Port': 12345, 'Address': '127.0.0.1' }) This is only posted for those who want to use the patch

Re: netlink.c:97: error: cast increases required alignment of target type

2009/11/9 Rémi Denis-Courmont r...@remlab.net: As far as I know NO extra alignement is needed. The kernel will anyway memory copy from/to the sockaddr_pn buffer as part of the socket calls, so it couldn't care less about alignment. Practically I'm sure you're right and maybe we should stick a

[PATCH] Don't give up netreg init if generic CellID reporting is not supported.

--- drivers/atmodem/gprs.c | 57 +-- drivers/atmodem/network-registration.c | 56 +-- 2 files changed, 106 insertions(+), 7 deletions(-) diff --git a/drivers/atmodem/gprs.c b/drivers/atmodem/gprs.c index 6f4933a..242086c

[PATCH 2/3] Add Palm Pre plugin

--- Makefile.am |3 + plugins/modemconf.c |3 +- plugins/palmpre.c | 219 +++ 3 files changed, 224 insertions(+), 1 deletions(-) create mode 100644 plugins/palmpre.c diff --git a/Makefile.am b/Makefile.am index c3e06b4..0e08349

[PATCH 3/3] Add SMS support for Palm Pre with a vendor quirk

--- drivers/atmodem/sms.c |7 --- plugins/palmpre.c |2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index b3d6ff5..20ab47a 100644 --- a/drivers/atmodem/sms.c +++ b/drivers/atmodem/sms.c @@ -680,9 +680,10 @@ static

[PATCH] Accept ranges in +CSMS responses.

--- drivers/atmodem/sms.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c index 20ab47a..dfccdb4 100644 --- a/drivers/atmodem/sms.c +++ b/drivers/atmodem/sms.c @@ -1043,7 +1043,7 @@ static void at_csms_query_cb(gboolean

Re: ppp

Hi, 2009/11/13 Chris Pitchford of...@intrepid.cx: Is the line discipline so much of an issue when using ppp connected to a fake tty? could that not be handed on the proxy side inside ofono? I've not tried it on a non-tty but it definitely should work modulo potential bugs that need to be

Re: Palm Pre modem plugin

Hi, 2009/11/20 morp...@gravedo.de: The Problem why we do this is the following: As I and some other people find out, there is no support on the data channel (the one you use in oFono to speak plain AT with the modem) for unsolicited responses. So the only option is to support the binary

Re: Palm Pre modem plugin

2009/11/21 morp...@gravedo.de: I am currently working on the implementation of the basics I found out about the protocol. I split the whole code into two projects: msmcommd and libmsmcomm. msmcommd is a daemon which does all the link layer protocol handling which is required to speak probably

Re: Palm Pre modem plugin

Hi, 2009/11/21 morp...@gravedo.de: On Fri, Nov 20, 2009 at 02:17:06PM +0100, andrzej zaborowski wrote: The ofono plugin is experimental, but some unsolicited responses are available on the AT port, like incoming SMS.  I've not checked incoming voice calls yet, outgoing calls worked fine

Re: [PATCH 2/4] Handle EF-CBSMID contents.

tested on real hardware due to obvious difficulties :) Regards From 57a9e9bc9e0110ba960bdd72415e58886dc52f6f Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Thu, 17 Dec 2009 18:22:05 +0100 Subject: [PATCH 1/3] Add utility for checking if CBS topic is in a range

Re: [PATCH 3/4] Add Powered property to CbsManager.

: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Thu, 17 Dec 2009 21:54:07 +0100 Subject: [PATCH 4/4] Add Powered property to CbsManager. --- src/cbs.c | 172 1 files changed, 160 insertions(+), 12 deletions(-) diff --git a/src

Re: [PATCH 4/4] Save CellBroadcast Topics list, handle EF-CBMI, EF-CBMIR.

Hi, 2009/12/16 Denis Kenzior denk...@gmail.com: The two SIM files are only used to bootstrap the topics list value if there's no previous value.  I think there's no point in updating their contents because if the user adds new ranges, most likely the list will not fit the file sizes and

[PATCH 1/3] Retrieve CPHS phase (if any) from SIM.

--- include/sim.h |9 + src/sim.c | 47 ++- src/simutil.h |1 + 3 files changed, 56 insertions(+), 1 deletions(-) diff --git a/include/sim.h b/include/sim.h index bc846f3..7a61269 100644 --- a/include/sim.h +++ b/include/sim.h @@

[PATCH 2/3] Use CPHS version of mailbox numbers on SIM if 3GPP version not available.

Otherwise just try to keep the CPHS version of the files in sync. --- include/sim.h |4 ++ src/message-waiting.c | 130 +++- src/simutil.h |1 + 3 files changed, 121 insertions(+), 14 deletions(-) diff --git a/include/sim.h

[PATCH 3/3] If EF-MWIS is not available use the CPHS version.

--- src/message-waiting.c | 81 +++-- src/simutil.h |1 + 2 files changed, 79 insertions(+), 3 deletions(-) diff --git a/src/message-waiting.c b/src/message-waiting.c index 283c5e2..05d05ed 100644 --- a/src/message-waiting.c +++

Re: [PATCH 4/4] Save CellBroadcast Topics list, handle EF-CBMI, EF-CBMIR.

From 0feca823565c9a00cd60a64142bc88b1a7e1bf20 Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date: Mon, 11 Jan 2010 17:30:35 +0100 Subject: [PATCH] Save CellBroadcast Topics list, handle EF-CBMI, EF-CBMIR. The two SIM files are only used to bootstrap the topics list

Re: [PATCH] Add support of Huawei EM770 modem

On 11 February 2010 06:54, Gu, Yang yang...@intel.com wrote: In oFono code, device4 represents the modem, while device1 is the udev_device when calling function add_huawei_em770(modem, udev_device). When I check if it's ttyUSB2 or not in my code, I think I'm checking the device1 and its

[PATCH] Use g_dbus_emit_signal in call-{barring,meter}.c

--- src/call-barring.c | 13 ++--- src/call-meter.c | 12 ++-- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/src/call-barring.c b/src/call-barring.c index e4c39f3..2a04b25 100644 --- a/src/call-barring.c +++ b/src/call-barring.c @@ -991,18 +991,9 @@ static

Re: [PATCH, rfc] Handle network-initiated ussd requests.

Hi, On 15 February 2010 18:03, Denis Kenzior denk...@gmail.com wrote:       } else {               ofono_error(Received an unsolicited USSD, ignoring for now...);               DBG(USSD is: status: %d, %s, status, str); +             if (ussd-driver-respond_not_supported) +                

Re: [PATCH, rfc] Handle network-initiated ussd requests.

Hi, On 15 February 2010 22:24, Denis Kenzior denk...@gmail.com wrote: In everything I've researched I understood that there can't be two concurrent ussd sessions.  The only things that can happen during USSD_STATE_USER_ACTION: - Network sends a timed out notification or terminates the ussd

[PATCH] Use stk_envelope_type constant name in sim.c

--- src/sim.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/sim.c b/src/sim.c index 0ab399d..03d3e6e 100644 --- a/src/sim.c +++ b/src/sim.c @@ -42,6 +42,7 @@ #include smsutil.h #include simutil.h #include storage.h +#include stkutil.h #define

[PATCH 2/8][RFC] Set polling interval depending on whether calls are active.

--- include/voicecall.h |2 ++ src/sim.c | 37 +++-- src/voicecall.c |5 + 3 files changed, 42 insertions(+), 2 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 6ceb3d8..dcce91a 100644 --- a/include/voicecall.h

[PATCH 4/8][RFC] Remove post-sim atoms after SIM is extracted.

--- src/modem.c | 48 1 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index b935328..6dfa73a 100644 --- a/src/modem.c +++ b/src/modem.c @@ -52,6 +52,7 @@ enum ofono_property_type { struct ofono_modem {

[PATCH 5/8][RFC] STATUS, FETCH and TERMINAL RESPONSE for AT driver.

Fix ENVELOPE implementation. --- drivers/atmodem/sim.c | 286 ++--- 1 files changed, 273 insertions(+), 13 deletions(-) diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c index 89ddcc6..d6f08b4 100644 --- a/drivers/atmodem/sim.c +++

[PATCH 8/8][RFC] Enable SIM polling in atgen and phonesim drivers.

--- plugins/atgen.c|6 +- plugins/phonesim.c |6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/plugins/atgen.c b/plugins/atgen.c index 7e760bc..ea322fb 100644 --- a/plugins/atgen.c +++ b/plugins/atgen.c @@ -156,12 +156,16 @@ static int atgen_disable(struct

Re: [PATCH 1/8][RFC] Add functions to notify core of SIM insertion/removal or request polling.

Hi Denis, On 18 March 2010 00:01, Denis Kenzior denk...@gmail.com wrote: Implement optional polling.  Polling is mandatory according to the specification but on most hardware it will me impractical because there will be vendor specific unsolicited notifications that can be used instead.  

[PATCH] Return network's USSD reponses from the Respond method instead of signalling

--- doc/supplementaryservices-api.txt |2 +- src/ussd.c| 31 --- 2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/doc/supplementaryservices-api.txt b/doc/supplementaryservices-api.txt index 23796c1..115e2ff 100644 ---

[PATCH] Fix ampersand commands check

Also remove a trailing tab. --- gatchat/gatserver.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gatchat/gatserver.c b/gatchat/gatserver.c index 031e542..839ebe4 100644 --- a/gatchat/gatserver.c +++ b/gatchat/gatserver.c @@ -570,9 +570,9 @@ static int

[PATCH 1/2] phonesim: Add a simple USSD UI.

This is not the best UI in the world... --- src/control.cpp | 40 +++- src/control.h |6 ++-- src/controlbase.ui | 70 +++ src/hardwaremanipulator.cpp | 19 ++-

[PATCH 2/8] Functions to notify core of SIM insertion/removal.

Make every plugin generate a sim inserted event on start. For devices with removable card, the event should be emitted after the plugin detects such event. --- include/sim.h |3 +- plugins/atgen.c|6 +++- plugins/calypso.c |6 +++- plugins/em770.c|6 +++-

[PATCH 3/8] Add an atom for STK, move envelope command to stk driver.

--- Makefile.am |4 +- drivers/atmodem/sim.c | 77 --- include/sim.h |3 - include/stk.h | 71 + src/cbs.c | 10 ++- src/modem.c |1 + src/ofono.h |4 +- src/sim.c | 37

[PATCH 4/8] Retrieve/forget emergency numbers on SIM insert/remove.

--- src/voicecall.c | 65 +-- 1 files changed, 58 insertions(+), 7 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 8bf6379..b6e0226 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -54,6 +54,7 @@ struct ofono_voicecall

[PATCH 5/8] Remove post-sim atoms after SIM is extracted.

--- src/modem.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 7cdd9c4..45c2bc4 100644 --- a/src/modem.c +++ b/src/modem.c @@ -53,6 +53,7 @@ enum ofono_property_type { struct ofono_modem {

[PATCH 6/8] Add SIM Present property.

--- src/sim.c | 117 - 1 files changed, 77 insertions(+), 40 deletions(-) diff --git a/src/sim.c b/src/sim.c index 41ddd13..6bd846f 100644 --- a/src/sim.c +++ b/src/sim.c @@ -271,6 +271,7 @@ static DBusMessage

[PATCH 7/8] Add AT driver for STK atom.

--- Makefile.am |1 + drivers/atmodem/atmodem.c |2 + drivers/atmodem/atmodem.h |3 + drivers/atmodem/stk.c | 258 + plugins/atgen.c |2 + plugins/phonesim.c|3 + 6 files changed, 269

[PATCH 3/3][RfC] Add a BTLV encoding test.

--- unit/test-simutil.c | 52 +++ 1 files changed, 52 insertions(+), 0 deletions(-) diff --git a/unit/test-simutil.c b/unit/test-simutil.c index 2c8cb30..8a90ad1 100644 --- a/unit/test-simutil.c +++ b/unit/test-simutil.c @@ -81,6 +81,57 @@ static

Re: [PATCH 1/3] Fix CTLV three-byte tag parsing.

On 22 April 2010 10:11, Andrzej Zaborowski andrew.zaborow...@intel.com wrote:         * If byte 1 of the tag is equal to 0x7F, then the tag is encoded -        * on the following two bytes, with bit 8 of the 2nd byte of the tag -        * being the CR flag. +        * on the following two

[PATCH] Fix CTLV three-byte tag parsing.

--- src/simutil.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/simutil.c b/src/simutil.c index 31b21c7..f994455 100644 --- a/src/simutil.c +++ b/src/simutil.c @@ -210,7 +210,7 @@ void comprehension_tlv_iter_init(struct comprehension_tlv_iter *iter,

[PATCH 4/3][RfC] Add encoding for the four TERMINAL RESPONSEs.

This patch adds encoding support for the TERMINAL RESPONSEs of the four commands that we already support decoding of, and the three CTLVs that these TERMINAL RESPONSEs use. It's untested and is just a proposal. --- src/stkutil.c | 262 +

Re: [PATCH 2/3][RfC] Add utilities for encoding BTLVs and CTLVs.

Hi, On 23 April 2010 22:09, Denis Kenzior denk...@gmail.com wrote: So I think for the case of the encoder we should bite the bullet and use something like a g_byte_array.  It will be really hard for us to guess the correct buffer size. Ok with me, although most of the time we have a limit of

Re: [PATCH 2/6] stkutil: Move advance of ctlv to decicated proactive commands parser

Hi Yang, On 26 April 2010 12:29, Yang Gu yang...@intel.com wrote: Not all the proactive commands have comprehension tlv other than command details and device identities. So the appropriate code should be moved to decicated parser if needed. Maybe parse_dataobj() would be a better place?

[PATCH 2/4][RFC] gatchat: Allow cancelling a running command.

Users need to be extra careful using the cancel functions because there's a potential race condition where an OK or ERROR for the command being cancelled arrives just the same moment the next command in the queue is being submitted, and is treated as a response to that command. Ideally we would

[PATCH 3/4] gatchat: Emit notification when command is sent to modem.

Function g_at_chat_send_with_callback takes an additional parameter that is a function to call when command is sent to hardware. --- gatchat/gatchat.c | 35 +++ gatchat/gatchat.h | 17 + 2 files changed, 44 insertions(+), 8 deletions(-) diff

[PATCH] phonesim: Time out +CSIM when no SIM present.

Send an ERROR after some time from receiving a AT+CSIM when card is not inserted. Implement cancelling pending commands. --- src/phonesim.cpp | 25 - src/phonesim.h | 10 ++ 2 files changed, 34 insertions(+), 1 deletions(-) diff --git a/src/phonesim.cpp

Re: [PATCH 2/4][RFC] gatchat: Allow cancelling a running command.

Hi Denis, On 30 April 2010 04:53, Denis Kenzior denk...@gmail.com wrote: Users need to be extra careful using the cancel functions because there's a potential race condition where an OK or ERROR for the command being cancelled arrives just the same moment the next command in the queue is

Re: [PATCH 3/4] gatchat: Emit notification when command is sent to modem.

a g_at_chat_set_submit_notify function that modifies an already submitted command. Removing the destroy callback from g_at_chat_send would require changing all the many uses of it. Regards, Andrew From 4f00c2907c22f07d39d6c2823d9137bee4c6fea6 Mon Sep 17 00:00:00 2001 From: Andrzej Zaborowski andrew.zaborow...@intel.com Date

[PATCH] Add a Calypso STK driver.

--- Makefile.am |3 +- drivers/calypsomodem/calypsomodem.c |2 + drivers/calypsomodem/calypsomodem.h |3 + drivers/calypsomodem/stk.c | 274 +++ plugins/phonesim.c | 46 +- 5 files changed, 318

Re: FW: How to start ofono-phonesim in ubuntu-10.04 -reg

Hi Krishna, On 7 May 2010 14:45, krishna k id_kish...@live.in wrote: I am using NOKIA E71 phone as a modem through usb cable... ... still i am not getting the gui... You're talking about two things here: using a real modem, and using phonesim. Phonesim emulates a modem, so you don't need the

[PATCH v2 1/6] Don't remove atoms when state goes from INSERTED to NOT PRESENT.

--- src/modem.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/modem.c b/src/modem.c index 8319702..0d0cb2a 100644 --- a/src/modem.c +++ b/src/modem.c @@ -1132,13 +1132,16 @@ static void modem_sim_ready(void *user, enum ofono_sim_state new_state)

[PATCH v2 3/6] sim-poll: Count timeout from the moment STATUS is sent to modem.

--- drivers/atmodem/sim-poll.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/atmodem/sim-poll.c b/drivers/atmodem/sim-poll.c index bd2caa6..111dce8 100644 --- a/drivers/atmodem/sim-poll.c +++ b/drivers/atmodem/sim-poll.c @@ -198,20 +198,27 @@

[PATCH 4/6] atmodem/sim.c: Pass allowed response prefixes to gatchat.

Not doing this creates a race condition where any notification comming in in the middle of a sequence of commands may be counted as a response to one of the commands and get lost. Instead gatchat could be changed to give priority to registered unsolicited responses if a line matches one of the

[PATCH 5/6] Add mbmmodem STK driver.

Tested with a F3607gw data card. --- Makefile.am |3 +- drivers/mbmmodem/mbmmodem.c |2 + drivers/mbmmodem/mbmmodem.h |3 + drivers/mbmmodem/stk.c | 254 +++ plugins/mbm.c | 45 +++- 5 files changed, 302

[PATCH 1/8] Add utilities for encoding BTLVs and CTLVs.

This version is simplified and avoids memcpy'ing when encoding BER-TLVs, at the cost of robustness. Every BER-TLV now needs to be closed using .._next() or .._optimize() before it's valid. --- src/simutil.c | 316 + src/simutil.h | 50

[PATCH 2/8] Add a BER-TLV encoding test.

--- unit/test-simutil.c | 59 -- 1 files changed, 56 insertions(+), 3 deletions(-) diff --git a/unit/test-simutil.c b/unit/test-simutil.c index 2c8cb30..49a40cd 100644 --- a/unit/test-simutil.c +++ b/unit/test-simutil.c @@ -48,16 +48,15 @@ const

[PATCH 3/8] Add STK-specific CTLV encoding utilities.

--- src/stkutil.c | 155 + 1 files changed, 155 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 50fa4c1..e51090c 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2343,3 +2343,158 @@ void

[PATCH 4/8] Encoding of the four TERMINAL RESPONSE pdus.

--- src/stkutil.c | 171 + src/stkutil.h | 45 +++ 2 files changed, 216 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index e51090c..1205f40 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -2498,3

[PATCH 7/8] test-stkutil: Add unit test for Get Input response encoding.

--- unit/test-stkutil.c | 778 +++ 1 files changed, 778 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 7574fa1..2f2a725 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -2142,6 +2142,717 @@

[PATCH 3/4] mbm: Register sim toolkit atom in mbm plugin.

--- plugins/mbm.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/plugins/mbm.c b/plugins/mbm.c index c67c7a5..3a87f79 100644 --- a/plugins/mbm.c +++ b/plugins/mbm.c @@ -37,6 +37,7 @@ #include ofono/devinfo.h #include ofono/netreg.h #include ofono/sim.h +#include

[PATCH 01/27] Add utilities for encoding BTLVs and CTLVs.

This version merges ber_tlv_builder_next and _set_tag into one function, same for comprehension tlvs. The ber_tlv_iter and ber_tlv_builder structs are not merged because the pointers in _iter need to be const else ugly casting is needed. --- src/simutil.c | 310

[PATCH 06/27] stkutil: Add Get Inkey response builder.

--- src/stkutil.c | 88 - src/stkutil.h | 16 ++ 2 files changed, 103 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 6f5dc7b..29a1760 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -36,7 +36,8

[PATCH 08/27] stkutil: Add Get Input response builder.

--- src/stkutil.c |6 ++ src/stkutil.h |5 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 29a1760..c3c30ab 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3192,6 +3192,12 @@ unsigned int stk_pdu_from_response(const struct

[PATCH 09/27] test-stkutil: Add Get Input response tests.

--- unit/test-stkutil.c | 709 +++ 1 files changed, 709 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index b042f62..932e364 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -10610,6 +10610,648

[PATCH 14/27] stkutil: Add Poll Interval response builder support.

--- src/stkutil.c |6 ++ src/stkutil.h |5 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index e45164a..1f32a5b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3201,6 +3201,12 @@ unsigned int stk_pdu_from_response(const struct

[PATCH 15/27] test-stkutil: Add Poll Interval response tests.

--- unit/test-stkutil.c | 67 +++ 1 files changed, 67 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index afe002e..1304714 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -11392,6 +11392,66 @@

[PATCH 16/27] stkutil: Add Refresh response builder support.

--- src/stkutil.c |2 ++ src/stkutil.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 1f32a5b..9d9cfa6 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3207,6 +3207,8 @@ unsigned int stk_pdu_from_response(const struct

[PATCH 17/27] test-stkutil: Add Refresh response tests.

--- src/stkutil.c |2 +- unit/test-stkutil.c | 304 +++ 2 files changed, 305 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 9d9cfa6..d0c11a6 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3207,7

[PATCH 18/27] stkutil: Add Set Up Menu response builder support.

--- src/stkutil.c |1 + src/stkutil.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index d0c11a6..798e2a9 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3208,6 +3208,7 @@ unsigned int stk_pdu_from_response(const struct

[PATCH 19/27] test-stkutil: Add Set Up Menu response tests.

--- unit/test-stkutil.c | 70 +++ 1 files changed, 70 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 953cb03..ed18bbf 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -11716,6 +11716,66 @@

[PATCH 20/27] stkutil: Add Select Item response builder.

--- src/stkutil.c | 21 + src/stkutil.h |5 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 798e2a9..cf22361 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3047,6 +3047,21 @@ static inline gboolean

[PATCH 21/27] test-stkutil: Add Select Item response tests.

--- unit/test-stkutil.c | 334 +++ 1 files changed, 334 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index ed18bbf..e84a99a 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -11776,6 +11776,300

[PATCH 22/27] stkutil: Add Set Up Call response builder.

--- src/stkutil.c | 33 + src/stkutil.h |9 + 2 files changed, 42 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index cf22361..4e813ec 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3129,6 +3129,20 @@ static gboolean

[PATCH 23/27] test-stkutil: Add Set Up Call response tests.

--- unit/test-stkutil.c | 262 +++ 1 files changed, 262 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index e84a99a..20c30cb 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -12070,6 +12070,234

[PATCH 24/27] stkutil: Add Polling Off response builder support.

--- src/stkutil.c |2 ++ src/stkutil.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index 4e813ec..30c9425 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -3264,6 +3264,8 @@ unsigned int stk_pdu_from_response(const struct

[PATCH 25/27] test-stkutil: Add a Polling Off response test.

--- unit/test-stkutil.c | 24 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index 20c30cb..ece14f8 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -12298,6 +12298,26 @@ static const struct

[PATCH 26/27] smsutil: Expose SMS timestamp encoding utility.

The function can be re-used in stkutil.c, similarly to sms_decode_scts. --- src/smsutil.c | 14 +++--- src/smsutil.h |3 +++ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/smsutil.c b/src/smsutil.c index 17e0e0e..6f8e9c5 100644 --- a/src/smsutil.c +++

  1   2   3   4   5   >