Re: [PATCH] rilmodem: fix a problem that manager_dial_callback is never called

2021-12-16 Thread Denis Kenzior
Hi Xiaoyi, On 12/16/21 03:30, Xiaoyi Chen wrote: This problem does not happen each time when dialing. It's only observed with some sim cards under certain network. The time sequence to reproduce the problem is: - send dial request - receive unsol event call state changed - send clcc poll

Re: [PATCH] rilmodem: fix handling both of SUCCESS AND FAILURE

2021-12-16 Thread Denis Kenzior
Hi JongSeok, On 12/16/21 04:48, JongSeok Won wrote: Hi denis, Here is patch for mulfunctioning when failure of RIL Command, RIL_REQUEST_SET_UNSOL_CELL_INFO_LIST_RATE, is occurred. I changed the commit description slightly and.. Best Regards, JongSeok --- drivers/rilmodem/netmon.c | 4

Re: drivers/qmimodem/gprs.c:create_wds_cb() ofono_gprs_set_cid_range(gprs, 1, 1) <-- hard coded range doesn't work with all SIM cards

2021-12-15 Thread Denis Kenzior
Hi Doug, On 12/15/21 10:55, dburr...@miovision.com wrote: This hardcoded range of possible CIDs doesn't quite make to me, can someone explain this? I've got a Verizon SIM card and its default profile index is 3, this falls outside the range set for possible CIDs and therefore can't activate

Re: [PATCH] rilmodem: fix register of unsolicited notify

2021-12-13 Thread Denis Kenzior
Hi Xiaovi, On 12/13/21 2:35 AM, Xiaoyi Chen wrote: --- drivers/rilmodem/stk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list -- ofono@ofono.org To unsubscribe send an email to

Re: [PATCH] quectel: get devinfo

2021-12-13 Thread Denis Kenzior
Hi Sean, What do you think about this: [0] In attr_cb() the +10 to attr pointer I need to do better. While looking at the code, in attr_cb() do we leak the attr string? I can't find where it's free'd :) No, the string is declared as const char in both attr_cb and at_util_parse_attr(). So

Re: [PATCH] quectel: get devinfo

2021-12-07 Thread Denis Kenzior
Hi Sean, Good plan :) I have been looking at it. [0] Yep, that looks like a good start. Should I catch the callback directly in atmodem/devinfo.c instead? You could try to intercept this in attr_cb itself. But you'd need access to vendor selector somehow. Perhaps a custom data

Re: [PATCH] quectel: get devinfo

2021-12-06 Thread Denis Kenzior
Hi Sean, On 12/6/21 3:50 AM, Sean Nyekjaer wrote: Quectel devices returns "Revision:" before the manufacture and revision. Via dbus: "Manufacturer" s "Revision: MTK 0828" "Revision" s "Revision: M95FAR02A08" --- plugins/quectel.c | 2 ++ 1 file changed, 2 insertions(+) Applied. But you

Re: Upgrade to version 1.32 broken 4G LTE connection

2021-11-25 Thread Denis Kenzior
Hi Jupiter, On 11/25/21 12:15 AM, Jupiter wrote: Hi, Could anyone advise why the dbus worked fine in 1.30 but it is no longer working in 1.32? Are there any changes in API? 1.30 is about 2 years old now. But I don't recall any API changes. Mostly bug fixes and driver improvements. #

Re: Race condition with LTE on QMI

2021-11-16 Thread Denis Kenzior
Hi Andrew, On 11/15/21 6:37 PM, Andrew Murray wrote: Hello, I'm using a SIM7600 USB modem (QMI) with Connman and Ofono, however I've found that I don't get a connection on first boot. I've debugged this and have some clues as to why... On first boot (or every boot with a read-only

Re: Bug/Oversight in gatchat/gatresult.c with negative numbers

2021-08-06 Thread Denis Kenzior
Hi Alex, Yeah I think you are right and I am getting really irritated with them giving me the run-around tbh. I sympathize, been there ;) Yeah ok - what name do you suggest? So there's a few things you can do actually: - We do have g_at_result_next_unquoted_string. You could try using

Re: Bug/Oversight in gatchat/gatresult.c with negative numbers

2021-08-06 Thread Denis Kenzior
Hi Alex, OK - they say it's fine and you say it's not. I don't have the time to be the middle-man here. I'm fairly certain your vendor's firmware is not following the relevant standards, but it sounds like they don't want to fix it. What can I do? :) Although I'd like to, clearly I

Re: Bug/Oversight in gatchat/gatresult.c with negative numbers

2021-08-06 Thread Denis Kenzior
Hi Alex, Denis - I am being directed to the ITU 36.133 spec here https://portal.3gpp.org/desktopmodules/Specifications/SpecificationDetails.aspx?specificationId=2420 Sure, same document/section where 27.007 refers to for . But unfortunately 27.007 only defines the range 0..97 where 0 is

Re: Bug/Oversight in gatchat/gatresult.c with negative numbers

2021-08-03 Thread Denis Kenzior
Hi Alex, I have been chasing this up with Quectel and they tell me this the correct implementation. "QCOPS and QENG command show the RSSI、RSRP and SINR value of the network, this is in accordance with the 3GPP TS regulations, so it is normal for negative numbers to be displayed.image" So

Re: [PATCH] simfs: Fix reads beyond the first block

2021-07-30 Thread Denis Kenzior
Hi Slava, On 7/30/21 10:52 AM, Slava Monich wrote: On 30/07/2021 18.37, Denis Kenzior wrote: Hi Slava, On 7/30/21 7:07 AM, Slava Monich wrote: ---   src/simfs.c | 17 -   1 file changed, 8 insertions(+), 9 deletions(-) Funny how long this bug has been lurking around

Re: [PATCH] simfs: Fix reads beyond the first block

2021-07-30 Thread Denis Kenzior
Hi Slava, On 7/30/21 7:07 AM, Slava Monich wrote: --- src/simfs.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) Funny how long this bug has been lurking around. diff --git a/src/simfs.c b/src/simfs.c index 3d4f6283..cf770265 100644 --- a/src/simfs.c +++

Re: Documentation on when to free structures in/after callbacks

2021-07-30 Thread Denis Kenzior
Hi Alex, On 7/30/21 9:24 AM, ajlen...@dynamicdevices.co.uk wrote: Thanks Denis that helps. I see I need to learn a bit and get my head around this. For example I find this really confusing: cbd = req_cb_data_ref(cbd); if (g_at_chat_send(nmd->chat, "AT+CESQ", cesq_prefix,

Re: Documentation on when to free structures in/after callbacks

2021-07-30 Thread Denis Kenzior
Hi Alex, On 7/30/21 8:21 AM, ajlen...@dynamicdevices.co.uk wrote: I'm not sure what you mean? What exactly do you think needs freeing? Strange. I am lookinga at the drivers and sometimes unref functions are provided into other functions and sometimes not So you're talking about callbacks

Re: Documentation on when to free structures in/after callbacks

2021-07-28 Thread Denis Kenzior
Hi Alex, On 7/28/21 11:32 AM, ajlen...@dynamicdevices.co.uk wrote: Hi all, I'm trying to write a driver for Quectel modems as I need some specific bits and bobs - mainly signal strengths for the serving cell and neighbourhood cells I can't quite get my head around when I am supposed to

Re: Bug/Oversight in gatchat/gatresult.c with negative numbers

2021-07-27 Thread Denis Kenzior
Hi Alex, On 7/20/21 11:11 AM, Alex J Lennon wrote: Hi all, I'm doing a bit of work with Ofono again, extending support for a Quectel EG91 - handling additional cell strength information which seems necessary for LTE. I'm using Quectel's AT+QCOPS which is returning some negative signal

Re: [PATCH] gemalto: radio-settings: cleanup

2021-07-27 Thread Denis Kenzior
Hi Sergey, On 7/23/21 12:00 PM, Sergey Matyukevich wrote: Enum ofono_radio_access_mode has been replaced by unsigned int. This change allows to move handling of all the modes into 'switch' in the function gemalto_set_rat_mode. --- drivers/gemaltomodem/radio-settings.c | 15 ++- 1

Re: [PATCH 2/3] plugins: gemalto: add radio-settings atom

2021-07-15 Thread Denis Kenzior
Hi Sergey, On 7/4/21 10:53 AM, Sergey Matyukevich wrote: Instantiate Gemalto radio-settings atom in post_sim. --- plugins/gemalto.c | 2 ++ 1 file changed, 2 insertions(+) Patch 2 & 3 applied, thanks. Regards, -Denis ___ ofono mailing list --

Re: [PATCH 1/3] gemalto: add radio-settings driver

2021-07-15 Thread Denis Kenzior
Hi Sergey, On 7/4/21 10:53 AM, Sergey Matyukevich wrote: Add support for Gemalto specific radio settings. --- Makefile.am | 1 + drivers/gemaltomodem/gemaltomodem.c | 2 + drivers/gemaltomodem/gemaltomodem.h | 3 + drivers/gemaltomodem/radio-settings.c

[ANNOUNCE] IRC moved to OFTC

2021-06-15 Thread Denis Kenzior
Hello, Due to recent changes on freenode IRC network, we have decided to move the IRC channel to OFTC. Please update your IRC clients to the new channel at irc://irc.oftc.net/#ofono. We will keep the #ofono channel on Freenode for now to help with the transition. Regards, -Denis

Re: [PATCH 2/3] radio-settings: Add handling of dual mode technology preference

2021-06-01 Thread Denis Kenzior
Hi Sean, On 5/31/21 6:49 AM, Sean Nyekjaer wrote: Allow setting of "lte,gsm" mode, for modems that doesn't support ANY mode. --- src/radio-settings.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/radio-settings.c b/src/radio-settings.c index 7283aa98..e2e5f33b 100644 ---

Re: Quectel EC200T USB: Problems with context activation

2021-05-20 Thread Denis Kenzior
Hi Sergei, On 5/19/21 6:35 PM, Sergei Golubtsov wrote: Hi Denis, Thank you very much for your quick and helpful reply. The problem is a bit vulgar actually. That's a shame that I took your time for that but I have another question as I am not sure about the findings below. no worries. I

Re: Quectel EC200T USB: Problems with context activation

2021-05-19 Thread Denis Kenzior
Hi Sergei, On 5/18/21 4:19 PM, Sergei Golubtsov wrote: Hi Denis and all, I have some problems with the context activation on Quectel EC200T USB in chinese network although in russian networks the modem works fine. I have the following during the activation: 2021-05-18T23:35:50.624972+03:00

Re: [PATCH v5 0/4]

2021-05-14 Thread Denis Kenzior
Hi Jonas, On 5/12/21 4:17 AM, Jonas Bonn wrote: Hi Denis, If we're going to get anywhere with this, the onus probably falls on you to do some cleanup work on these patches.  I'll write some comments on the patches and maybe you can munge those into the commit messages...? What now? ;)

Re: [PATCH] sim-auth: Parse auth response according to TS 31.102

2021-05-03 Thread Denis Kenzior
Hi Slava, On 5/3/21 9:04 AM, Slava Monich wrote: --- So what is this trying to fix? I mean I can understand 1 line patch fixes that come without a description. These tend to be self-evident. 300+ line diff needs a least some explanation. src/sim-auth.c | 34 ++-

Re: [PATCH] simutil: Fill unused part of AID with FFs

2021-04-30 Thread Denis Kenzior
Hi Slava, On 4/29/21 11:09 AM, Slava Monich wrote: Correct handling of short AIDs will take more than that, but leaving part of the array uninitialized is wrong in any case. --- src/simutil.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/simutil.c b/src/simutil.c index

Re: [PATCH] build: require glib >= 2.60

2021-04-30 Thread Denis Kenzior
On 3/8/21 3:33 AM, JongSeok Won wrote: g_utf8_validate_len() is support after glib 2.60 --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Regards, -Denis ___ ofono mailing list -- ofono@ofono.org To

Re: [PATCH 1/2] sim-auth: Remove watch if open_channel fails

2021-04-30 Thread Denis Kenzior
Hi Slava, On 4/26/21 3:17 AM, Slava Monich wrote: Otherwise open_channel won't be called again after a failure. --- src/sim-auth.c | 2 ++ 1 file changed, 2 insertions(+) Both applied, thanks. Regards, -Denis ___ ofono mailing list --

Re: [PATCH] build: require glib >= 2.60

2021-03-05 Thread Denis Kenzior
Hi, -PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.32, dummy=yes, - AC_MSG_ERROR(GLib >= 2.32 is required)) +PKG_CHECK_MODULES(GLIB, glib-2.0 >= 2.60, dummy=yes, + AC_MSG_ERROR(GLib >= 2.60 is required)) This patch doesn't apply: denkenz@localhost ~/ofono-master $ git am ~/merge/\[PATCH\]\ build\:\

Re: [PATCH v1 5/5] Use tabs as Denis required

2021-02-23 Thread Denis Kenzior
Hi Jupiter, On 2/22/21 10:46 PM, Bing Jupiter wrote: From: Jupiter Please make sure your authorship information is updated in the commit meta-data as well for all the patches you're submitting. --- drivers/atmodem/vendor.h | 2 +- drivers/qmimodem/gprs.c | 26

Re: [PATCH 1/4] SARA R4 QMI support

2021-02-22 Thread Denis Kenzior
Hi Jupiter, On 2/22/21 4:14 AM, Jupiter wrote: From: jupiter Please provide a complete and properly capitalized real name with your submission, otherwise I can't apply it. --- plugins/udevng.c | 41 + 1 file changed, 41 insertions(+) diff

Re: [PATCH] qmimodem: Add USSD indication support

2021-02-22 Thread Denis Kenzior
Hi Alexey, On 2/19/21 9:30 AM, Alexey Andreyev wrote: Sorry for a noob html format, retrying from a custom client as plaintext: Hello! My first patch, feel free to criticize :) This is to handle the USSD Indication messages with the qmimodem driver. Higher-level KDE Plasma Mobile issue:

Re: [PATCH phonesim 6/7] Port to Qt 6

2021-01-25 Thread Denis Kenzior
Hi Jonah, On 1/18/21 10:46 AM, Jonah Brüchert wrote: --- CMakeLists.txt | 10 +++--- src/CMakeLists.txt | 6 +- src/control.cpp | 8 +++- src/hardwaremanipulator.cpp | 1 - src/phonesim.cpp| 2 +- src/qsimcommand.cpp |

Re: [PATCH phonesim 3/7] Remove autotools build system

2021-01-25 Thread Denis Kenzior
Hi Jonah, On 1/18/21 10:46 AM, Jonah Brüchert wrote: --- INSTALL | 236 Makefile.am | 79 --- bootstrap | 3 - bootstrap-configure | 9 -- configure.ac| 49 - 5 files changed, 376

Re: [PATCH phonesim 5/7] qwsppdu: Port QDateTime deprecations

2021-01-25 Thread Denis Kenzior
Hi Jonah, On 1/18/21 10:46 AM, Jonah Brüchert wrote: --- src/qwsppdu.cpp | 8 1 file changed, 8 insertions(+) Applied, thanks. Regards, -Denis ___ ofono mailing list -- ofono@ofono.org To unsubscribe send an email to

Re: [PATCH phonesim 2/7] Use quotes to include local header files

2021-01-25 Thread Denis Kenzior
Hi Jonah, On 1/18/21 10:46 AM, Jonah Brüchert wrote: Co-authored-by: Alexander Akulich --- src/aidapplication.cpp| 4 ++-- src/callmanager.cpp | 4 ++-- src/conformancesimapplication.cpp | 2 +- src/control.h | 2 +-

Re: [PATCH v3 2/3] sim: validate IMS private identity

2021-01-19 Thread Denis Kenzior
Hi Sergey, On 1/16/21 1:21 PM, Sergey Matyukevich wrote: Make sure that IMS private identity is a valid UTF8 string before setting sim->impi field. Otherwise ofono may crash on dbus assert when SIM properties are reported via org.ofono.SimManager interface. --- src/sim.c | 3 ++- 1 file

Re: [PATCH v3 1/3] simutil: add validate_utf8_tlv

2021-01-19 Thread Denis Kenzior
Hi Sergey, On 1/16/21 1:21 PM, Sergey Matyukevich wrote: Add helper to validate if TLV value is a valid UTF8 string. Note that both null-terminated and non null-terminated UTF8 strings are considered valid. --- src/simutil.c | 14 ++ src/simutil.h | 1 + 2 files changed, 15

Re: [PATCH v2] sim: validate IMS private identity

2021-01-15 Thread Denis Kenzior
Hi Sergey, On 1/15/21 2:34 PM, Sergey Matyukevich wrote: Make sure that IMS private identity is a valid UTF8 string before setting sim->impi field. Otherwise ofono may crash on dbus assert when SIM properties are reported via org.ofono.SimManager interface. --- src/sim.c | 3 ++- 1 file

Re: [PATCH v2] sim: validate IMS private identity

2021-01-15 Thread Denis Kenzior
Hi Sergey, On 1/15/21 1:56 PM, Sergey Matyukevich wrote: Make sure that IMS private identity is a valid UTF8 string before setting sim->impi field. Otherwise ofono may crash on dbus assert when SIM properties are reported via org.ofono.SimManager interface. --- src/sim.c | 3 ++- 1 file

Re: [PATCH] sim: validate IMS private identity

2021-01-15 Thread Denis Kenzior
Hi Sergey, This field may not be defined for ISIM in use. In this case the field still can be read from ISIM, though it will not contain a valid UTF8 string. For instance, it may contain 255 0xFF bytes. Ugh, seems like the SIM vendor can't follow RFC's either? 31.103 Section 4.2.2 says:

Re: [PATCH] sim: validate IMS private identity

2021-01-15 Thread Denis Kenzior
Hi Sergey, On 1/15/21 10:38 AM, Sergey Matyukevich wrote: Make sure that IMPI is a valid UTF8 string before attempting to report it via DBus. Otherwise ofono may crash on dbus assert. This field may not be defined for ISIM in use. In this case the field still can be read from ISIM, though it

Re: [PATCH v2 3/3] gemalto: netmon measurements scaling

2021-01-15 Thread Denis Kenzior
Hi Sergey, On 1/15/21 10:25 AM, Sergey Matyukevich wrote: Gemalto modem reports raw measurements in dBm. Reported values may include negative numbers. Meanwhile oFono follows ETSI TS 27.007, so negative numbers do not really exist at the API level. Modify gemalto netmon driver to report

Re: [RFC PATCH 0/2] gemalto: netmon driver

2021-01-11 Thread Denis Kenzior
Hi Sergey, On 1/10/21 1:44 PM, Sergey Matyukevich wrote: Hello Denis and all, This patch series implements netmon driver for gemalto modems that are able to provide basic measurements using AT+CQS and AT^SMONI commands. This patch series is intendedly marked as RFC. In addition to general I

Re: [RFC PATCH 1/2] gemalto: add netmon driver

2021-01-11 Thread Denis Kenzior
Hi Sergey, On 1/10/21 1:44 PM, Sergey Matyukevich wrote: Implement network monitoring driver for gemalto modems that are able to provide serving cell information and basic measurements using AT+CQS and AT^SMONI commands. --- Makefile.am | 3 +-

Re: [PATCH v2] quectel: adding support for the Quectel EC200 USB modem series

2021-01-07 Thread Denis Kenzior
Hi Sergei, On 1/7/21 2:40 PM, s.e.golubt...@gmail.com wrote: From: Sergei Golubtsov Support for the Quectel EC200 USB modem series has been added. The model identification AT command has been added as the first step in the communication with a Quectel USB modem. --- plugins/quectel.c | 128

Re: [PATCH v2] ppp: using RX ACCM = 0 by default

2021-01-07 Thread Denis Kenzior
Hi Sergei, On 1/7/21 2:40 PM, s.e.golubt...@gmail.com wrote: From: Sergei Golubtsov Some modems such as Quectel EC200T do not honor the default value for the Async-Control-Character-Map (ACCM) configuration option defined in RFC 1548 6.2 as 0x. This patch suggests to use RX ACCM = 0

Re: [PATCH v2] gsmdial: adding support for selection of authentication method

2021-01-07 Thread Denis Kenzior
Hi Sergei, On 1/7/21 2:40 PM, s.e.golubt...@gmail.com wrote: From: Sergei Golubtsov Selection capability for authentication method via a command line argument has been added --- gatchat/gsmdial.c | 16 1 file changed, 16 insertions(+) @@ -369,6 +370,17 @@ static void

Re: Quectel EC200T USB: Problems with context activation

2021-01-06 Thread Denis Kenzior
Hi Sergei, So far, all modems on this planet have honored the default properly... Sorry for my misunderstanding. I should have read the RFC better but this aspect is defined properly only in the following clause - "TheConfiguration Option is used to inform the peer which control

Re: Quectel EC200T USB: Problems with context activation

2021-01-04 Thread Denis Kenzior
Hi Sergei, On 1/2/21 3:52 AM, Sergei Golubtsov wrote: Hi Denis, Happy New Year. Apologies for the late response, I was in holiday mode. The log from my previous message clearly shows that the problem is that the modem stopped escaping control characters (<0x20) with 0x7d when

Re: [PATCH ppp] ppp: Apply configuration options from a DCE request if ACK it

2021-01-04 Thread Denis Kenzior
Hi Sergei, On 1/1/21 3:04 PM, s.e.golubt...@gmail.com wrote: From: Sergei Golubtsov Apply configuration options if the DCE sends a PPP LCP configure request and the DTE is going to ACK the request. Otherwise some options such as the ACCM may not correspond to the configuration negotiated with

Re: [PATCH] gsmdial: add support for different authentication methods selection

2021-01-04 Thread Denis Kenzior
Hi Sergei, On 1/1/21 3:12 PM, s.e.golubt...@gmail.com wrote: From: Sergei Golubtsov Selection capability for authentication method via a command line argument has been added --- gatchat/gsmdial.c | 13 + 1 file changed, 13 insertions(+) denkenz@localhost ~/ofono-master $

Re: [PATCH] quectel: add support of Quectel EC200 USB modem

2021-01-04 Thread Denis Kenzior
Hi Sergei, On 1/1/21 3:17 PM, s.e.golubt...@gmail.com wrote: From: Sergei Golubtsov Support of Quectel EC200 USB modem series has been added. The model identification AT command has been added as the first step in the communication with a Quectel modem. --- plugins/quectel.c | 49

Re: Quectel EC200T USB: Problems with context activation

2020-12-31 Thread Denis Kenzior
Hi Sergei, I still cannot understand why ofono does not try to use PAP if the authentication method is set to CHAP by default (because no method set while context creation) and it is "obvious" that PAP should be used. pppd does this BTW, that's why I assumed that it could be "obvious". I am

Re: [PATCH v2 0/2] gemalto: gprs context driver updates

2020-12-30 Thread Denis Kenzior
Hi Sergey, On 12/26/20 2:56 PM, Sergey Matyukevich wrote: Hi Denis and all, This is the second version of the patches updating gemalto gprs context driver. Major changes include support for automatic context activation and support for gprs context authentication settings. Regards, Sergey v1

Re: Quectel EC200T USB: Problems with context activation

2020-12-30 Thread Denis Kenzior
Hi Sergei, On 12/30/20 4:00 AM, Sergei Golubtsov wrote: Hello Denis, > Are the username and password set properly on the context? Yes, they are. root@131D2F4C5254324B:~# /usr/lib/ofono/test/list-contexts [ /quectel_0 ]     [ /quectel_0/context1 ]         Name = Россия         Active = 0  

Re: Quectel EC200T USB: Problems with context activation

2020-12-29 Thread Denis Kenzior
Hi Sergei, On 12/29/20 11:56 AM, Sergei Golubtsov wrote: Changing the authentication method to pap did not help. Please help. Are the username and password set properly on the context? And you may want to share the log of oFono activating the context configured for PAP. Regards, -Denis

Re: [pulseaudio-discuss] Proposal for a new API and usage of Bluetooth HSP and HFP profiles on Linux

2020-12-24 Thread Denis Kenzior
Hi Pali, I think you will need to do this regardless. Otherwise I fail to see how you prevent one 'agent' from consuming AT commands it shouldn't be. This is a possibility you need to consider, whether it happens by accident or maliciously. Some subset of AT commands are needed to parse

Re: [pulseaudio-discuss] Proposal for a new API and usage of Bluetooth HSP and HFP profiles on Linux

2020-12-24 Thread Denis Kenzior
Hi Pali, There have been one or two implementations of AG role fully external to oFono. These implementations simply used the existing oFono APIs to drive the modem. bluez & pulseaudio developers told me that it would be a good idea to avoid implementing a new AT parser for telephony stack.

Re: [pulseaudio-discuss] Proposal for a new API and usage of Bluetooth HSP and HFP profiles on Linux

2020-12-24 Thread Denis Kenzior
Hi Pali, But would you accept patches which exports DBus API e.g. for displaying text on HFP headset with embedded display? Or patches which implements 3 different way for reporting battery level status of HFP headset? And API for sending "computer battery level" to HFP headset? Or implementing

Re: [pulseaudio-discuss] Proposal for a new API and usage of Bluetooth HSP and HFP profiles on Linux

2020-12-24 Thread Denis Kenzior
Hi Pali, Yes, I see. Also there are devices without HFP support, only with HSP. pulseaudio support also these devices and pulseaudio is not going to drop support for them. Last time when I looked at ofono, it has no HSP support. Is ofono going to add support for HSP? No. But would you

Re: [pulseaudio-discuss] Proposal for a new API and usage of Bluetooth HSP and HFP profiles on Linux

2020-12-24 Thread Denis Kenzior
Hi Pali, I'm not sure what logic around HSP you really care about. It is just a single button press in the end. CSR features (battery status level, ...) and CSR codec selection (e.g. AuriStream). Also some apple extensions are used in HSP profile. Since HFP can do everything that HSP can

Re: [pulseaudio-discuss] Proposal for a new API and usage of Bluetooth HSP and HFP profiles on Linux

2020-12-24 Thread Denis Kenzior
Hi Pali, On 12/16/19 3:15 AM, Pali Rohár wrote: Hi! On Monday 16 December 2019 00:11:04 Luiz Augusto von Dentz wrote: Hi Pali, On Thu, Dec 5, 2019 at 11:32 AM Pali Rohár wrote: On Monday 02 December 2019 19:45:12 Pali Rohár wrote: On Monday 02 December 2019 19:01:11 Tanu Kaskinen wrote:

Re: [PATCH 3/5] gemalto: gprs: support automatic context activation

2020-12-23 Thread Denis Kenzior
Hi Sergey, Are you sure you don't want to wait until swwan_cb to return success to the core? AT^SWWAN can still fail...? AT^SWWAN command is yet another way to activate a PDP context. AT commands spec for this modem is a bit vague about SWWAN details, but according to other materials from

Re: [PATCH 5/5] gemalto: gprs: support authentication settings

2020-12-22 Thread Denis Kenzior
Hi Sergey, On 12/21/20 2:01 PM, Sergey Matyukevich wrote: From: Sergey Matyukevich Add support for gprs contexts with username, password, as well as specific authentication type. --- drivers/gemaltomodem/gprs-context.c | 54 - 1 file changed, 53 insertions(+), 1

Re: [PATCH 3/5] gemalto: gprs: support automatic context activation

2020-12-22 Thread Denis Kenzior
Hi Sergey, On 12/21/20 2:01 PM, Sergey Matyukevich wrote: From: Sergey Matyukevich Implement read_settings function to get configuration for automatic contexts. Fix the issue uncovered by added support for automatic context activation: do not use AT+CGACT for the contexts handled by AT^SWWAN.

Re: [PATCH 1/5] plugin: gemalto: fix source of gprs notifications

2020-12-22 Thread Denis Kenzior
Hi Sergey, On 12/21/20 2:01 PM, Sergey Matyukevich wrote: Modem USB interface does not receive certain gprs context notifications. Fix gprs chat: use Application USB interface to receive all the modem notifications. --- plugins/gemalto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] huawei, util: Fix a couple of implicit enum conversions

2020-12-22 Thread Denis Kenzior
Hi Richard, On 12/20/20 5:18 AM, richard.rojf...@gmail.com wrote: From: Richard Röjfors GCC 10 warns about a couple of implicit conversions; huawei: Member from the incorrect enum was returned, both had the value 0, so the code would still work. drivers/huaweimodem/radio-settings.c: In

Re: [PATCH v3] quectel: Power on/off with a gpio pulse

2020-10-06 Thread Denis Kenzior
Hi Lars, On 10/6/20 5:10 AM, poesc...@lemonage.de wrote: From: Lars Poeschel Current implementation uses a gpio level of 1 for powering on quectel modems using a gpio and a level of 0 for powering off. Normally quectel modems are powered on or off by a gpio pulse on their PWR_KEY pin. They

Re: [PATCH] quectel: Possibility to switch power by gpio level

2020-10-02 Thread Denis Kenzior
Hi Lars, On 10/2/20 7:49 AM, poesc...@lemonage.de wrote: From: Lars Poeschel This does apply on top of my previous patch: [PATCH v2] quectel: Power on/off with a gpio pulse I think you might as well just combine the two... Regards, -Denis ___

Re: [PATCH v2] quectel: Power on/off with a gpio pulse

2020-10-02 Thread Denis Kenzior
Hi Lars, On 10/1/20 6:42 AM, poesc...@lemonage.de wrote: From: Lars Poeschel Current implementation uses a gpio level of 1 for powering on quectel modems using a gpio and a level of 0 for powering off. This is wrong. Quectel modems use pulses for either power on and power off. They turn on by

Re: [PATCH 2/2] quectel: Power on/off with a gpio pulse

2020-09-30 Thread Denis Kenzior
Hi Lars, Can this be done using g_timeout instead? This was indeed not the first solution I tried. But I used the l_timeout_ thing that is used all over in quectel.c. I could not get this to work in a way I was satisfied with. When I send a SIGTERM to the ofono process close_serial is called

Re: [PATCH 1/1] remove obsolete m4 macro

2020-09-29 Thread Denis Kenzior
Hi Nikhil, On 8/25/20 3:12 PM, Nikhil Jha wrote: As per https://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html LT_INIT should be used instead. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis

Re: [PATCH] common: APN with a dot in second position are not invalid

2020-09-29 Thread Denis Kenzior
Hi Christophe, On 9/28/20 2:38 AM, Christophe Ronco wrote: APN with a dot in second position (example: "t.est") are wrongly considered invalid. --- src/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Regards, -Denis

Re: [PATCH 3/3] droid 4: Add probing.

2020-09-15 Thread Denis Kenzior
Hi Pavel, On 9/15/20 8:23 AM, Pavel Machek wrote: Probe Droid 4 modem. This should result in basic support working. --- Makefile.am | 3 + plugins/droid.c | 206 +++ plugins/udevng.c | 31 + 3 files changed, 240

Re: [PATCH 2/3] droid 4: special handling for SMSes

2020-09-15 Thread Denis Kenzior
Hi Pavel, On 9/15/20 8:23 AM, Pavel Machek wrote: Droid 4 modem is "special" (aka broken) so and getting incoming SMSes to work is quite tricky. This should get it right. --- drivers/atmodem/sms.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 1/3] droid 4: add special handling required for voice calls and SIM

2020-09-15 Thread Denis Kenzior
Hi Pavel, On 9/15/20 8:23 AM, Pavel Machek wrote: Droid 4 modem is "special" (aka broken) so it seems to need a bit of error handling. --- drivers/atmodem/sim.c | 1 + drivers/atmodem/vendor.h| 1 + drivers/atmodem/voicecall.c | 4 3 files changed, 6 insertions(+) @@

Re: [PATCH v3] Support weird modem in Motorola Droid 4

2020-09-14 Thread Denis Kenzior
Hi Pavel, On 9/10/20 8:05 AM, Pavel Machek wrote: This is basic support for modem in Droid 4, accessed over ttyUSB4. That interface is unfortunately quite broken, so we need to force very specific SMS mode. Can you separate this into at least a couple of patches per our patch submission

Re: Supporting modem in Droid 4

2020-09-09 Thread Denis Kenzior
Hi Pavel, On 9/9/20 6:35 AM, Pavel Machek wrote: Hi! Two months I sent patch for Droid 4 support in ofono: https://www.mail-archive.com/ofono@ofono.org/msg19590.html I got no replies. Could I get some comments? Should I try to resend? Please resend. Looks like they got buried in a thread

Re: [PATCH v3] atmodem: Detect usage of AT+CGEREP

2020-09-01 Thread Denis Kenzior
Hi Lars, On 9/1/20 4:21 AM, poesc...@lemonage.de wrote: From: Lars Poeschel Currently AT+CGEREP=2,1 is sent in case we don't know what the modem needs. (default case) Not all modems understand this. So, we first query what the modem supports with AT+CGEREP=? and then use this information to

Re: [PATCH v2] atmodem: Detect usage of AT+CGEREP

2020-08-31 Thread Denis Kenzior
Hi Lars, On 8/31/20 8:24 AM, poesc...@lemonage.de wrote: From: Lars Poeschel Currently AT+CGEREP=2,1 is sent in case we don't know what the modem needs. (default case) Not all modems understand this. So, we first query what the modem supports with AT+CGEREP=? and then use this information to

Re: [PATCH 1/2] atmodem: Detect usage of AT+CGEREP

2020-08-25 Thread Denis Kenzior
Hi Lars, So in theory this could be written like: int max = -1; iter_open_list(); while (iter_next_range(, , )) { if (max2 > max) max = max2; } iter_close_list(); I can do this and it does indeed work! :-) This may be my personal thing, but I find this not very

Re: [PATCH v2] atmodem: Signal quality on quectel serial modems

2020-08-25 Thread Denis Kenzior
Hi Lars, On 8/21/20 4:24 AM, poesc...@lemonage.de wrote: From: Lars Poeschel As the default way of getting the signal quality with +CIND is also unstable on quectel serial modems (the same as on quectel EC21). In fact the signal quality is only updated on cell changes. Those trigger a manual

Re: [PATCH 1/2] atmodem: Detect usage of AT+CGEREP

2020-08-20 Thread Denis Kenzior
Hi Lars, So why not just run iter_next_range in a loop? it actually understands both lists and ranges. See cind_support_cb() for an example. Ok, I can do this i a loop if you want. + /* if min1 == max1 we had no range but a list and that +* means we are interested in the

Re: [RFC PATCH] atmodem: Signal quality on quectel serial modems

2020-08-19 Thread Denis Kenzior
Hi Lars, On 8/19/20 7:43 AM, poesc...@lemonage.de wrote: From: Lars Poeschel As the default way of getting the signal quality with +CIND is also unstable on quectel serial modems (the same as on quectel EC21). In fact the signal quality is only updated on cell changes. Those trigger a manual

Re: [PATCH 1/2] atmodem: Detect usage of AT+CGEREP

2020-08-19 Thread Denis Kenzior
Hi Lars, On 8/19/20 7:13 AM, poesc...@lemonage.de wrote: From: Lars Poeschel Currently AT+CGEREP=2,1 is sent in case we don't know what the modem needs. (default case) Not all modems understand this. So, we first query what the modem supports with AT+CGEREP=? and then use this information to

Re: [PATCH 2/2] atmodem: Deactivate AT+CPSB for quectel serial modems

2020-08-19 Thread Denis Kenzior
Hi Lars, On 8/19/20 7:13 AM, poesc...@lemonage.de wrote: From: Lars Poeschel There are at the moment two quectel modems in ofono vendored as OFONO_VENDOR_QUECTEL_SERIAL: The M95 and the MC60. Both modems are GSM only modems, and their official documentation does not mention the AT+CPSB

Re: [PATCH v2 0/3] gemalto: USB ethernet data path for ELS81x

2020-08-19 Thread Denis Kenzior
Hi Sergey, On 8/18/20 3:43 PM, Sergey Matyukevich wrote: Hi Denis and all, This patch series enables USB ethernet data path for gemalto modems that support this feature, in particular for ELS81x devices. All three applied (minus the S-o-B tags). Thanks! Regards, -Denis

Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-18 Thread Denis Kenzior
Hi Martin, Instead of this dance of opening / closing the chat in order to force-cancel the 'AT' command queued in gemalto_enable(), maybe there should be something in GAtChat itself to handle this case. There's also the retry logic used on quectel modems with auto-detection of baud

Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-17 Thread Denis Kenzior
Hi Sergey, On 8/15/20 4:43 PM, Sergey Matyukevich wrote: Function gemalto_modem_ready attempts to restart AT chat data->app after incomplete shutdown. As a result, new AT chat does not work as expected loosing AT commands. Signed-off-by: Sergey Matyukevich --- plugins/gemalto.c | 8

Re: [RFC PATCH 1/4] drivers: gemalto: add gprs-context driver

2020-08-17 Thread Denis Kenzior
Hi Sergey, On 8/15/20 4:43 PM, Sergey Matyukevich wrote: Some gemalto modems provide USB ethernet interfaces for data path. Implement gprs-context driver for such modems to send data via USB ethernet rather than fallback to PPP. Signed-off-by: Sergey Matyukevich --- Makefile.am

Re: [PATCH v4] gprs: Quectel EC21 does not understand AT+CPSB

2020-08-17 Thread Denis Kenzior
Hi Lars, On 8/17/20 2:58 AM, poesc...@lemonage.de wrote: From: Lars Poeschel The Quectel EC21 modem does not understand the AT+CPSB command, and we did not find a suitable replacement in the Quectel_EC25_AT_Commands_Manual_V1.3.pdf AT+CPSB gives an error on this modem, so we just skip it. ---

Re: [PATCH v3] gprs: Quectel EC21 does not understand AT+CPSB

2020-08-13 Thread Denis Kenzior
Hi Lars, On 8/13/20 8:33 AM, poesc...@lemonage.de wrote: From: Lars Poeschel The Quectel EC21 modem does not understand the AT+CPSB command, so aquire the current packet switched bearer from quectel proprietary QIND:"act" URC. --- drivers/atmodem/gprs.c | 49

Re: [PATCH v2 3/3] gprs: Quectel EC21 does not understand AT+CPSB

2020-08-12 Thread Denis Kenzior
Hi Lars, oFono driver interface is based on 27.007. So that means values defined in 27.007 do not need to be 'converted'. You can simply feed them in directly if they follow 27.007. Well, yes. I saw this. But unfortunately at this point what is expected are the 27.007 values from AT+CPSB

Re: [PATCH v2 3/3] gprs: Quectel EC21 does not understand AT+CPSB

2020-08-11 Thread Denis Kenzior
Hi Lars, On 8/11/20 6:42 AM, poesc...@lemonage.de wrote: From: Lars Poeschel The Quectel EC21 modem does not understand the AT+CPSB command, so aquire the current packet switched bearer from CGREG URC. --- drivers/atmodem/gprs.c | 32 ++-- 1 file changed, 30

Re: [PATCH v2 1/3] Add a vendor OFONO_VENDOR_QUECTEL_EC2X

2020-08-11 Thread Denis Kenzior
Hi Lars, On 8/11/20 6:42 AM, poesc...@lemonage.de wrote: From: Lars Poeschel The distinction between OFONO_VENDOR_QUECTEL and OFONO_VENDOR_QUECTEL_SERIAL does not suffice for EC21/EC25 in some places, so introduce and use a new vendor: OFONO_VENDOR_QUECTEL_EC2X --- drivers/atmodem/sim.c

Re: [PATCH 4/5] quectel: Try to update voltage only, when received "vbatt"

2020-08-07 Thread Denis Kenzior
Hi Lars, On 8/4/20 7:38 AM, poesc...@lemonage.de wrote: From: Lars Poeschel As there are some more sources of +QIND: activated, do now only update voltage when we get the +QIND: "vbatt",-1 but not on things like +QIND: "act","LTE" or +QIND: "csq",20,99 --- plugins/quectel.c | 8 +--- 1

  1   2   3   4   5   6   7   8   9   10   >