Re: [PATCH] ublox:netmon: support +UCGED and get EARFCN, EBAND and CQI

Hi Denis, list, Sorry for my late response, was traveling. I'll address all the comments and fix the delayed register this week. Thanks again. On 19 December 2016 at 17:59, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > On 12/16/2016 04:05 AM, Djalal Harouni wrote:

Re: [PATCH 5/5] ublox:netmon: support +UCGED and get EARFCN, EBAND and CQI

HI Denis, On 13 December 2016 at 18:38, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > > On 12/13/2016 05:05 AM, Djalal Harouni wrote: >> >> This adds support for +UCGED mode 2 and for now we collect only >> EARFCN, EBAND and CQI. Later we will foll

[PATCH] ublox:netmon: support +UCGED and get EARFCN, EBAND and CQI

This adds support for +UCGED mode 2 and for now we collect only EARFCN, EBAND and CQI. Later we will follow up with +UCGED mode 3. Some ublox modems supports +UCGED mode 2 and others only +UCGED mode 3 depending on the firmware. --- drivers/ubloxmodem/netmon.c | 210

Re: [PATCH 0/5] ubloxmodem support +UCGED mode 2

Hi Denis, On 13 December 2016 at 18:39, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > >> Djalal Harouni (5): >> netmon: add NETMON_INFO_{EARFCN|EBAND|CQI} >> doc: document netmon EARFCN, EBand and CQI properties >> netmon: handle

[PATCH 5/5] ublox:netmon: support +UCGED and get EARFCN, EBAND and CQI

This adds support for +UCGED mode 2 and for now we collect only EARFCN, EBAND and CQI. Later we will follow up with +UCGED mode 3. Some ublox modems supports +UCGED mode 2 and others only +UCGED mode 3 depending on the firmware. --- drivers/ubloxmodem/netmon.c | 195

[PATCH 3/5] netmon: handle OFONO_NETMON_INFO_{EARFCN|EBAND|CQI}

--- src/netmon.c | 21 + 1 file changed, 21 insertions(+) diff --git a/src/netmon.c b/src/netmon.c index bb39586..6476783 100644 --- a/src/netmon.c +++ b/src/netmon.c @@ -211,6 +211,27 @@ void ofono_netmon_serving_cell_notify(struct ofono_netmon *netmon,

[PATCH 4/5] test:netmon: support EARFCN, Eband and CQI in testing scripts

--- test/get-serving-cell-info | 12 1 file changed, 12 insertions(+) diff --git a/test/get-serving-cell-info b/test/get-serving-cell-info index 94e1c54..7a5d898 100755 --- a/test/get-serving-cell-info +++ b/test/get-serving-cell-info @@ -31,6 +31,9 @@ rscp =

[PATCH 1/5] netmon: add NETMON_INFO_{EARFCN|EBAND|CQI}

Add the following types to use with ublox modems +UCGED command. EARFCN: E-UTRA Absolute Radio Frequency Channel Number. EBand: E-UTRA operating Band. CQI: Channel Quality Indicator. --- include/netmon.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/netmon.h b/include/netmon.h

[PATCH 2/5] doc: document netmon EARFCN, EBand and CQI properties

Documentation for: EARFCN: E-UTRA Absolute Radio Frequency Channel Number. EBand: E-UTRA operating Band. CQI: Channel Quality Indicator. --- doc/networkmonitor-api.txt | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/networkmonitor-api.txt b/doc/networkmonitor-api.txt

Re: [PATCH v3 4/7] ubloxmodem: add the netmon driver

Hi Denis, On 1 December 2016 at 18:18, Denis Kenzior wrote: > Hi Djalal, > >> >> >> OK thank you for the explanation. I did go with ref counting since >> they are easy to use and I will follow up later with +UCGED which has >> different behaviour depending on firmware

Re: [PATCH v3 7/7] test: support OFONO_NETMON_INFO_{RXLEV|RSCP|ECN0|RSRQ|RSRP}

Hi Denis, On 30 November 2016 at 16:56, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > On 11/30/2016 06:31 AM, Djalal Harouni wrote: >> >> Display the following fields if they are returned. >> >> RXLEV: Received Signal Strength >&g

Re: [PATCH v3 4/7] ubloxmodem: add the netmon driver

Hi Denis, On 30 November 2016 at 16:55, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > > On 11/30/2016 06:31 AM, Djalal Harouni wrote: >> >> This adds a netmon driver for ublox. The driver support both +COPS and >> +CESQ commands to return the

[PATCH v4 4/7] ubloxmodem: add the netmon driver

This adds a netmon driver for ublox. The driver support both +COPS and +CESQ commands to return the previously added ofono netmon types: RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power Current revision

[PATCH v3 4/7] ubloxmodem: add the netmon driver

This adds a netmon driver for ublox. The driver support both +COPS and +CESQ commands to return the previously added ofono netmon types: RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power ---

[PATCH v3 2/7] netmon: handle OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP} in D-Bus

Handle the previously added types in D-Bus. Documentation for these values is in next patch. --- src/netmon.c | 28 1 file changed, 28 insertions(+) diff --git a/src/netmon.c b/src/netmon.c index eb18b9c..2a8c524 100644 --- a/src/netmon.c +++ b/src/netmon.c @@

[PATCH v3 6/7] build: build the ublox netmon driver

--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 3d7774b..07adeab 100644 --- a/Makefile.am +++ b/Makefile.am @@ -383,6 +383,7 @@ builtin_sources += drivers/atmodem/atutil.h \ drivers/ubloxmodem/ubloxmodem.h \

[PATCH v3 3/7] doc: documentation for OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP}

This adds documentation for the following fields in networkmonitor-api.txt RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power --- doc/networkmonitor-api.txt | 22 ++ 1 file changed, 22

[PATCH v3 7/7] test: support OFONO_NETMON_INFO_{RXLEV|RSCP|ECN0|RSRQ|RSRP}

Display the following fields if they are returned. RXLEV: Received Signal Strength RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power --- test/get-serving-cell-info | 20 1 file

[PATCH v3 1/7] netmon: add OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP}

Add more ofono netmon info types that will be served through the netmon interface. The main user of this now will be the ublox modem. RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power Patches using these

[PATCH v3 0/7] ubloxmodem add netmon interface

fixes to follow the coding style. v2 is here: https://lists.ofono.org/pipermail/ofono/2016-November/016685.html V1 is here: https://lists.ofono.org/pipermail/ofono/2016-November/016671.html Djalal Harouni (7): netmon: add OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP} netmon: handle

Re: [PATCH 4/7] ubloxmodem: add the netmon driver

On 30 November 2016 at 13:13, Djalal Harouni <dja...@endocode.com> wrote: > This adds a netmon driver for ublox. The driver support both +COPS and > +CESQ commands to return the previously added ofono netmon types: > > RSCP: Received Signal Code Power > ECN0: Receive

[PATCH 3/7] doc: documentation for OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP}

This adds documentation for the following fields in networkmonitor-api.txt RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power --- doc/networkmonitor-api.txt | 22 ++ 1 file changed, 22

[PATCH 1/7] netmon: add OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP}

Add more ofono netmon info types that will be served through the netmon interface. The main user of this now will be the ublox modem. RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power Patches using these

[PATCH 7/7] test: support OFONO_NETMON_INFO_{RXLEV|RSCP|ECN0|RSRQ|RSRP}

Display the following fields if they are returned. RXLEV: Received Signal Strength RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power --- test/get-serving-cell-info | 20 1 file

[PATCH v2 0/5] ubloxmodem add netmon interface

failed or sending +CESQ failed. Otherwise we report the result and make sure to free cbd. * Various fixes to follow the coding style. Djalal Harouni (7): netmon: add OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP} netmon: handle OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP} in D-Bus doc: documentation

[PATCH 6/7] build: build the ublox netmon driver

--- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 3d7774b..07adeab 100644 --- a/Makefile.am +++ b/Makefile.am @@ -383,6 +383,7 @@ builtin_sources += drivers/atmodem/atutil.h \ drivers/ubloxmodem/ubloxmodem.h \

[PATCH 2/7] netmon: handle OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP} in D-Bus

Handle the previously added types in D-Bus. Documentation for these values is in next patch. --- src/netmon.c | 28 1 file changed, 28 insertions(+) diff --git a/src/netmon.c b/src/netmon.c index eb18b9c..2a8c524 100644 --- a/src/netmon.c +++ b/src/netmon.c @@

[PATCH 5/7] ubloxmodem: register and initialize the netmon driver

--- plugins/ublox.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugins/ublox.c b/plugins/ublox.c index 6d77df8..2ced577 100644 --- a/plugins/ublox.c +++ b/plugins/ublox.c @@ -38,6 +38,7 @@ #include #include #include +#include #include #include @@ -323,6 +324,8 @@ static

[PATCH 4/7] ubloxmodem: add the netmon driver

This adds a netmon driver for ublox. The driver support both +COPS and +CESQ commands to return the previously added ofono netmon types: RSCP: Received Signal Code Power ECN0: Received Energy Ratio RSRQ: Reference Signal Received Quality RSRP: Reference Signal Received Power ---

Re: [PATCH 3/5] ubloxmodem: add the netmon driver

Hi Denis, On 29 November 2016 at 18:32, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > > On 11/25/2016 08:00 AM, dja...@endocode.com wrote: >> >> From: Djalal Harouni <dja...@endocode.com> >> >> This adds a netmon driver for ublox. The

Re: [PATCH 4/5] ubloxmodem: intialize and register the netmon driver

On 29 November 2016 at 17:53, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > On 11/25/2016 08:00 AM, dja...@endocode.com wrote: >> >> From: Djalal Harouni <dja...@endocode.com> >> >> This patch allows to intialize and register the ublox

Re: [PATCH 2/5] netmon: handle OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP|OPERATOR} in D-Bus

Hi Denis, On 29 November 2016 at 17:49, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > On 11/25/2016 08:00 AM, dja...@endocode.com wrote: >> >> From: Djalal Harouni <dja...@endocode.com> >> >> Handle the previously added

Re: [PATCH 1/5] netmon: add OFONO_NETMON_INFO_{RSCP|ECN0|RSRQ|RSRP|OPERATOR}

Hi Denis, On 29 November 2016 at 17:43, Denis Kenzior <denk...@gmail.com> wrote: > Hi Djalal, > > > On 11/25/2016 08:00 AM, dja...@endocode.com wrote: >> >> From: Djalal Harouni <dja...@endocode.com> >> >> Add more ofono netmon info types tha