[PATCH v4 0/2] Add support for modem handled setup call proactive command

end/session end is received. Also, noticed there is a break missing in the ofono_stk_proactive_command_handled_notify for STK_COMMAND_TYPE_SEND_SS case. Fix for that will be provided as a separate patch. Note: This version of the patch is not tested. Thanks and Regards, Jeevaka Jeevaka

[PATCH v4 2/2] stk: Handle set up call in handled_notify

--- src/stk.c | 166 +++-- 1 files changed, 140 insertions(+), 26 deletions(-) diff --git a/src/stk.c b/src/stk.c index e8ffb42..e85e595 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1790,6 +1790,45 @@ static void confirm_call_cb(enum

[PATCH v4 1/2] voicecall: api for set/clear alpha and icon id

--- src/ofono.h |6 + src/voicecall.c | 65 +++ 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 6524806..808a8f1 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -266,6 +266,12 @@ int

RE: [PATCH] ifxmodem: emergency number list support

Hi, Hi Jeevaka, I'm Nicolas Paccou, I'm in charge of validating the changes applied in new oFono release. Unfortunately, I have not the hardware to be able to regress your patch: Add support for handling IFX emergency number list I wanted to know if you have tested your patch on IFX modem

[PATCH 0/2] Add support for modem handled setup call proactive command

end/session end is received. Thanks and Regards, Jeevaka Jeevaka Badrappan (2): voicecall: api for set/clear alpha and icon id stk: Handle set up call in handled_notify src/ofono.h |6 +++ src/stk.c | 113 +- src/voicecall.c

[PATCH 1/2] voicecall: api for set/clear alpha and icon id

--- src/ofono.h |6 + src/voicecall.c | 62 +++ 2 files changed, 68 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 6524806..808a8f1 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -266,6 +266,12 @@ int

[PATCH 2/2] stk: Handle set up call in handled_notify

--- src/stk.c | 113 +++-- 1 files changed, 110 insertions(+), 3 deletions(-) diff --git a/src/stk.c b/src/stk.c index e8ffb42..a204e45 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1790,6 +1790,45 @@ static void confirm_call_cb(enum

[PATCH 2/4] voicecall: api for set/clear alpha and icon id

--- src/ofono.h |6 src/voicecall.c | 76 +++ 2 files changed, 82 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 6524806..808a8f1 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -266,6 +266,12 @@ int

[PATCH 0/4] Add support for modem handled setup call proactive command

and dial request are freed when the command end/session end is received. Thanks and Regards, Jeevaka Jeevaka Badrappan (4): include: Add driver api for user confirmation voicecall: api for set/clear alpha and icon id stk: Handle set up call in handled_notify ifxmodem: add support

[PATCH 1/4] include: Add driver api for user confirmation

--- include/stk.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/stk.h b/include/stk.h index c276c84..60636b5 100644 --- a/include/stk.h +++ b/include/stk.h @@ -47,6 +47,7 @@ struct ofono_stk_driver { void (*terminal_response)(struct ofono_stk *stk,

[PATCH 4/4] ifxmodem: add support for user_confirmation in stk

--- drivers/ifxmodem/stk.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/stk.c b/drivers/ifxmodem/stk.c index f08cf47..d2082c4 100644 --- a/drivers/ifxmodem/stk.c +++ b/drivers/ifxmodem/stk.c @@ -173,6 +173,16 @@ error:

[PATCH 3/4] stk: Handle set up call in handled_notify

--- src/stk.c | 122 +++- 1 files changed, 119 insertions(+), 3 deletions(-) diff --git a/src/stk.c b/src/stk.c index 4df23b5..6cc3be3 100644 --- a/src/stk.c +++ b/src/stk.c @@ -77,6 +77,8 @@ struct ofono_stk { struct timeval

Re: [PATCH 3/4] stk: Handle set up call in handled_notify

Hi, @@ -529,7 +531,12 @@ static void stk_alpha_id_set(struct ofono_stk *stk, static void stk_alpha_id_unset(struct ofono_stk *stk) { - stk_agent_request_cancel(stk-current_agent); + /* + * If there is no default agent, then current agent also will be NULL. + * So, call

[PATCH] stk: Fix crash seen in stk_alpha_id_unset

If there is no default agent, then current agent also will be NULL. So, call stk_agent_request_cancel only when there is a valid current agent. --- src/stk.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/src/stk.c b/src/stk.c index 4df23b5..e8ffb42 100644 ---

Re: [PATCH 2/4] voicecall: api for set/clear alpha and icon id

Hi Denis, } +if (vc-dial_req) { +v-message = vc-dial_req-message; +v-icon_id = vc-dial_req-icon_id; + +vc-dial_req-message = NULL; +vc-dial_req-call = v; + +newcall-phone_number.type = vc-dial_req-ph.type; +

Re: [PATCH 3/4] stk: Handle set up call in handled_notify

Hi Denis, +static void proactive_command_handled_end(struct ofono_stk *stk) +{ +stk-modem_handled_cmd = FALSE; + +if (stk-pending_cmd == NULL) +return; + +switch(stk-pending_cmd-type) { +case STK_COMMAND_TYPE_SETUP_CALL: +{ +struct

Re: [PATCH 2/4] voicecall: api for set/clear alpha and icon id

Hi Denis, + +number = phone_number_to_string(req-ph); + +if (!strcmp(number, 112)) { +struct ofono_modem *modem = __ofono_atom_get_modem(vc-atom); + +__ofono_modem_inc_emergency_mode(modem); +} I think we should do this step in the block of code in

[PATCH 0/4] Add support for modem handled setup call proactive command

Hi, Following set of patches adds support for modem handled setup call proactive command. Regards, Jeevaka Jeevaka Badrappan (4): include: Add driver api for user confirmation voicecall: api for set/clear alpha and icon id stk: Handle set up call in handled_notify ifxmodem: add

[PATCH 2/4] voicecall: api for set/clear alpha and icon id

--- src/ofono.h |5 + src/voicecall.c | 21 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/ofono.h b/src/ofono.h index 6524806..118d762 100644 --- a/src/ofono.h +++ b/src/ofono.h @@ -266,6 +266,11 @@ int __ofono_voicecall_dial(struct

[PATCH 3/4] stk: Handle set up call in handled_notify

--- src/stk.c | 108 +++- 1 files changed, 106 insertions(+), 2 deletions(-) diff --git a/src/stk.c b/src/stk.c index 9575f0e..26faa11 100644 --- a/src/stk.c +++ b/src/stk.c @@ -77,6 +77,8 @@ struct ofono_stk { struct timeval

[PATCH 4/4] ifxmodem: add support for user_confirmation in stk

--- drivers/ifxmodem/stk.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/stk.c b/drivers/ifxmodem/stk.c index f08cf47..d2082c4 100644 --- a/drivers/ifxmodem/stk.c +++ b/drivers/ifxmodem/stk.c @@ -173,6 +173,16 @@ error:

Re: [PATCH] ifxmodem: emergency number list support

Hi Denis, + +if (!g_at_result_iter_next_number(iter, total_cnt)) +return; + +if (!g_at_result_iter_next_string(iter, number)) +return; + +/* Skip the category, valid in simpresent and mcc fields */ What is this comment referring to? Following fields

[PATCH v2] ifxmodem: emergency number list support

--- drivers/ifxmodem/voicecall.c | 88 ++ 1 files changed, 88 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 87a48e6..bd2c6c3 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH] ifxmodem: emergency number list support

--- drivers/ifxmodem/voicecall.c | 95 ++ 1 files changed, 95 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 87a48e6..0aa83e4 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH v4 1/4] include: Add ofono_voicecall_en_list_notify api

--- include/voicecall.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 6ae06a9..a373c64 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -135,6 +135,9 @@ struct ofono_voicecall_driver {

[PATCH v4 2/4] voicecall: refactor emergency number list handling

--- src/voicecall.c | 143 --- 1 files changed, 72 insertions(+), 71 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 469b939..b0f15fd 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -46,8 +46,9 @@ struct ofono_voicecall

[PATCH v4 0/4] Support of Network / Modem updated emergency numbers

Hi, Following set of patch adds the support for emergency number list update from the network/modem in the oFono core. Regards, Jeevaka Jeevaka Badrappan (4): include: Add ofono_voicecall_en_list_notify api voicecall: refactor emergency number list handling voicecall: network emergency

[PATCH v4 3/4] voicecall: network emergency number list support

--- src/voicecall.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index b0f15fd..19ef479 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -49,6 +49,7 @@ struct ofono_voicecall { GHashTable *en_list; /*

[PATCH v4 4/4] TODO: Mark Network/Modem EN update task as done

--- TODO | 11 --- doc/features.txt | 18 ++ 2 files changed, 10 insertions(+), 19 deletions(-) diff --git a/TODO b/TODO index 85c5ad1..3491436 100644 --- a/TODO +++ b/TODO @@ -289,17 +289,6 @@ Sim Toolkit Complexity: C2 Owner: Philippe Nunes

[PATCH v3 2/4] voicecall: refactor emergency number list handling

--- src/voicecall.c | 135 --- 1 files changed, 68 insertions(+), 67 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 3e8fa46..60b8db5 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -46,8 +46,9 @@ struct ofono_voicecall

[PATCH v3 1/4] include: Add ofono_voicecall_en_list_notify api

--- include/voicecall.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 5e6da02..73eee26 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -140,6 +140,9 @@ struct ofono_voicecall_driver {

[PATCH v3 0/4] Support for emergency number list from network/modem

matches with the received emergency number list from modem, dbus property change will be signalled. If this should be avoided, then it needs to be decided whether the check should be added in core or for each modem. Regards, Jeevaka Jeevaka Badrappan (4): include: Add ofono_voicecall_en_list_notify

[PATCH v3 2/4] voicecall: refactor emergency number list handling

--- src/voicecall.c | 135 --- 1 files changed, 68 insertions(+), 67 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index b1d5586..d7d8424 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -46,8 +46,9 @@ struct ofono_voicecall

[PATCH v3 3/4] voicecall: network emergency number list support

--- src/voicecall.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index d7d8424..42ff6dc 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -2162,6 +2162,13 @@ check: set_new_ecc(vc); } +void

[PATCH v3 4/4] ifxmodem: emergency number list support

--- drivers/ifxmodem/voicecall.c | 99 ++ 1 files changed, 99 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 87a48e6..0841165 100644 --- a/drivers/ifxmodem/voicecall.c +++

[RFC PATCH 0/9] Emergency Mode

mode deactivated. - Modem remains in online mode. Post sim and post online atoms are not created. Regards, Jeevaka Jeevaka Badrappan (9): dbus: Add __ofono_error_emergency_active include: add ofono_modem_get_emergency_mode api modem: add ofono_modem_get_emergency_mode api

[RFC PATCH 2/9] include: add ofono_modem_get_emergency_mode api

--- include/modem.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/modem.h b/include/modem.h index a92eb88..5a34370 100644 --- a/include/modem.h +++ b/include/modem.h @@ -53,6 +53,8 @@ ofono_bool_t ofono_modem_get_powered(struct ofono_modem *modem);

[RFC PATCH 3/9] modem: add ofono_modem_get_emergency_mode api

--- src/modem.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 26468e8..2b49770 100644 --- a/src/modem.c +++ b/src/modem.c @@ -86,6 +86,7 @@ struct ofono_modem { void*driver_data; char

[RFC PATCH 6/9] modem: modem state decoupled from rf state

--- src/modem.c | 80 -- 1 files changed, 55 insertions(+), 25 deletions(-) diff --git a/src/modem.c b/src/modem.c index 72937a3..126c0e6 100644 --- a/src/modem.c +++ b/src/modem.c @@ -416,26 +416,34 @@ static void

[RFC PATCH 4/9] modem: add Emergency property

--- src/modem.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 2b49770..0aef463 100644 --- a/src/modem.c +++ b/src/modem.c @@ -669,6 +669,7 @@ void __ofono_modem_append_properties(struct ofono_modem *modem, int i;

[RFC PATCH 5/9] modem: add increment/decrement emergency mode api

--- src/modem.c | 36 src/ofono.h |3 +++ 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 0aef463..72937a3 100644 --- a/src/modem.c +++ b/src/modem.c @@ -2050,3 +2050,39 @@ ofono_bool_t

[RFC PATCH 7/9] modem: restrict operations allowed in emergency

--- src/modem.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/modem.c b/src/modem.c index 126c0e6..49b3314 100644 --- a/src/modem.c +++ b/src/modem.c @@ -662,6 +662,9 @@ static DBusMessage *set_property_online(struct ofono_modem *modem, if

[RFC PATCH 9/9] voicecall: add emergency mode handling

--- src/voicecall.c | 20 +++- 1 files changed, 19 insertions(+), 1 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index f25c770..04be551 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -1281,8 +1281,14 @@ static void manager_dial_callback(const struct

[RFC PATCH 8/9] voicecall: generalise emergency call check

--- src/voicecall.c | 14 +- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 4932ffa..f25c770 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -337,14 +337,10 @@ static gint number_compare(gconstpointer a, gconstpointer b)

[PATCH] TODO: set owner of Emergency Calls task

--- TODO |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/TODO b/TODO index f8926a3..5189111 100644 --- a/TODO +++ b/TODO @@ -389,6 +389,7 @@ Emergency Calls Priority: High Complexity: C2 + Owner: Jeevaka Badrappan jeevaka.badrap...@elektrobit.com - Country

[PATCH v2 1/4] include: Add ofono_voicecall_en_list_notify api

--- include/voicecall.h |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index 5e6da02..477b226 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -140,6 +140,9 @@ struct ofono_voicecall_driver {

[PATCH v2 0/4] Support for emergency number list from network/modem

matches with the received emergency number list from modem, dbus property change will be signalled. If this should be avoided, then it needs to be decided whether the check should be added in core or for each modem. Regards, Jeevaka Jeevaka Badrappan (4): include: Add ofono_voicecall_en_list_notify

[PATCH v2 2/4] voicecall: refactor emergency number list handling

--- src/voicecall.c | 32 1 files changed, 24 insertions(+), 8 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index b1d5586..826e10c 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -47,7 +47,8 @@ struct ofono_voicecall { GSList

[PATCH v2 4/4] ifxmodem: emergency number list support

--- drivers/ifxmodem/voicecall.c | 98 ++ 1 files changed, 98 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 87a48e6..a92ac11 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH v2 3/4] voicecall: network emergency number list support

--- src/voicecall.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/src/voicecall.c b/src/voicecall.c index 826e10c..e3b1135 100644 --- a/src/voicecall.c +++ b/src/voicecall.c @@ -2172,6 +2172,19 @@ check: set_new_ecc(vc); } +void

[PATCH 0/2] Add support for emergency number list from modem

with the received emergency number list from modem, dbus property change will be signalled. If this should be avoided, then it needs to be decided whether the check should be added in core or for each modem. Regards, Jeevaka Jeevaka Badrappan (2): voicecall: add ofono_voicecall_en_list_notify api

[PATCH 1/2] voicecall: add ofono_voicecall_en_list_notify api

--- include/voicecall.h |3 +++ src/voicecall.c | 12 2 files changed, 15 insertions(+), 0 deletions(-) diff --git a/include/voicecall.h b/include/voicecall.h index f00eb08..3710646 100644 --- a/include/voicecall.h +++ b/include/voicecall.h @@ -140,6 +140,9 @@ struct

[PATCH 2/2] ifxmodem: add support for emergency number list

--- drivers/ifxmodem/voicecall.c | 98 ++ 1 files changed, 98 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 87a48e6..a92ac11 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH 1/1] stk: Fix getenv failure case

--- src/stk.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/stk.c b/src/stk.c index 68b6240..94ad396 100644 --- a/src/stk.c +++ b/src/stk.c @@ -2177,8 +2177,9 @@ static void get_lang(struct stk_response *rsp, struct ofono_stk *stk) l = getenv(LANG);

[PATCH 0/1] Handle getenv failure case

. Distribution will be informed to start ofono after the locale is set. Regards, Jeevaka Jeevaka Badrappan (1): stk: Fix getenv failure case src/stk.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) ___ ofono mailing list ofono@ofono.org http

[PATCH] unit: fix broken alpha id unit test cases

--- unit/test-stkutil.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/unit/test-stkutil.c b/unit/test-stkutil.c index f1cad78..aa62aac 100644 --- a/unit/test-stkutil.c +++ b/unit/test-stkutil.c @@ -129,7 +129,10 @@ static inline void check_address(const struct

[PATCH 0/1] Fix issue in ifx nitz time reporting

and also only once as expected. Regards, Jeevaka Jeevaka Badrappan (1): atmodem: fix issue in time reporting with ifx drivers/atmodem/network-registration.c | 25 +++-- 1 files changed, 23 insertions(+), 2 deletions(-) ___ ofono

[PATCH 1/1] atmodem: fix issue in time reporting with ifx

--- drivers/atmodem/network-registration.c | 25 +++-- 1 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/atmodem/network-registration.c b/drivers/atmodem/network-registration.c index 4913611..0dbc72d 100644 --- a/drivers/atmodem/network-registration.c

[PATCH v2 0/1] Fix issue in ifx nitz time reporting

and also only once as expected. Regards, Jeevaka Jeevaka Badrappan (1): atmodem: fix issue in time reporting with ifx drivers/atmodem/network-registration.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) ___ ofono

[PATCH 0/1] Limits the send sms retry to network timeout

if the failure is only due to network timeout. For all the other failure cases, retry is not done. Regards, Jeevaka Jeevaka Badrappan (1): sms: limit the sms sending retry src/sms.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) ___ ofono

[PATCH 1/1] sms: limit the sms sending retry

--- src/sms.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/sms.c b/src/sms.c index 01f54dd..c4f8b54 100644 --- a/src/sms.c +++ b/src/sms.c @@ -47,6 +47,7 @@ #define SETTINGS_GROUP Settings #define TXQ_MAX_RETRIES 4 +#define NETWORK_TIMEOUT 332 static

[PATCH 0/1] Limits the send sms retry to network timeout

if the failure is only due to network timeout. For all the other failure cases, retry is not done. Regards, Jeevaka Jeevaka Badrappan (1): sms: limit the sms sending retry src/sms.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) ___ ofono

[PATCH 0/1] Fixes issue with Get Inkey variable timeout

Hi, As per the ETSI TS 102 384 specification 27.22.4.2.8 section, duration data object needs to be sent as part of the Get Inkey terminal response for No response from user result. Regards, Jeevaka Jeevaka Badrappan (1): stk: fix issue with Get Inkey variable timeout src/stk.c | 28

[PATCH 1/1] stk: fix issue with Get Inkey variable timeout

--- src/stk.c | 28 ++-- 1 files changed, 26 insertions(+), 2 deletions(-) diff --git a/src/stk.c b/src/stk.c index e933e4e..68b6240 100644 --- a/src/stk.c +++ b/src/stk.c @@ -1396,7 +1396,19 @@ static void request_confirmation_cb(enum stk_agent_result result,

[PATCH 0/2] Fix issue with null data object

Hi, As per the specification, if the alpha identifier is provided by the UICC and is a null data object (i.e. length = '00' and no value part), this is an indication that the terminal should not give any information to the user. Regards, Jeevaka Jeevaka Badrappan (2): stk: fix issue with null

[PATCH 1/2] stk: fix issue with null data object

As per the specification, if alphad identifier is provided and is a null data object, no information should be given to the user. --- src/stk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/stk.c b/src/stk.c index e933e4e..3d736dd 100644 --- a/src/stk.c +++

[PATCH 2/2] stkutil: fix issue with null data object

--- src/stkutil.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index abd1c99..66b2924 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -308,7 +308,7 @@ static gboolean parse_dataobj_alpha_id(struct comprehension_tlv_iter *iter,

[PATCH 0/4] Update the cell broadcast properties

Jeevaka Badrappan (4): cbs: remove EmergencyType property cbs: rename EmergencyBroadcast property doc: Update the cell broadcast properties test: update the cell broadcast property doc/cell-broadcast-api.txt | 17 ++--- src/cbs.c | 44

[PATCH 1/4] cbs: remove EmergencyType property

--- src/cbs.c | 35 ++- 1 files changed, 6 insertions(+), 29 deletions(-) diff --git a/src/cbs.c b/src/cbs.c index d99f250..36cca48 100644 --- a/src/cbs.c +++ b/src/cbs.c @@ -98,7 +98,6 @@ static void cbs_dispatch_base_station_id(struct ofono_cbs *cbs, const

[PATCH 2/4] cbs: rename EmergencyBroadcast property

--- src/cbs.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/cbs.c b/src/cbs.c index 36cca48..8bbae21 100644 --- a/src/cbs.c +++ b/src/cbs.c @@ -97,8 +97,9 @@ static void cbs_dispatch_base_station_id(struct ofono_cbs *cbs, const char *id)

[PATCH 3/4] doc: Update the cell broadcast properties

--- doc/cell-broadcast-api.txt | 17 ++--- 1 files changed, 6 insertions(+), 11 deletions(-) diff --git a/doc/cell-broadcast-api.txt b/doc/cell-broadcast-api.txt index 52618eb..5f6b4d6 100644 --- a/doc/cell-broadcast-api.txt +++ b/doc/cell-broadcast-api.txt @@ -36,19 +36,14 @@

[PATCH 4/4] test: update the cell broadcast property

--- test/monitor-ofono |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/monitor-ofono b/test/monitor-ofono index 8570c34..b803aa2 100755 --- a/test/monitor-ofono +++ b/test/monitor-ofono @@ -161,7 +161,7 @@ if __name__ == '__main__':

[RFC] doc: Add support for CMAS/EU-Alert

--- doc/cell-broadcast-api.txt | 26 +- 1 files changed, 17 insertions(+), 9 deletions(-) diff --git a/doc/cell-broadcast-api.txt b/doc/cell-broadcast-api.txt index 52618eb..71b2516 100644 --- a/doc/cell-broadcast-api.txt +++ b/doc/cell-broadcast-api.txt @@ -36,19

[PATCH] network: Remove unused SetProperty

--- doc/network-api.txt | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/doc/network-api.txt b/doc/network-api.txt index 4cb6366..db8da75 100644 --- a/doc/network-api.txt +++ b/doc/network-api.txt @@ -12,16 +12,6 @@ Methods dict GetProperties()

[PATCH 0/1] Update possible errors

Hi, Following patch updates the possible errors to the api documentation. Possible error values are updated based on currently returned errors. Regards, Jeevaka Jeevaka Badrappan (1): doc: Update possible errors doc/audio-settings-api.txt |2 - doc/call-barring-api.txt

[PATCH 1/1] doc: Update possible errors

--- doc/audio-settings-api.txt |2 - doc/call-barring-api.txt | 31 ++ doc/call-forwarding-api.txt| 16 +++ doc/call-meter-api.txt | 14 ++ doc/call-settings-api.txt |8 ++ doc/call-volume-api.txt

[PATCH 0/1] Fix issue in ifxmodem set rat mode

Jeevaka Badrappan (1): ifxmodem: fix issue in set rat mode drivers/ifxmodem/radio-settings.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

[PATCH 1/1] ifxmodem: fix issue in set rat mode

--- drivers/ifxmodem/radio-settings.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/ifxmodem/radio-settings.c b/drivers/ifxmodem/radio-settings.c index fd590ae..bd292c5 100644 --- a/drivers/ifxmodem/radio-settings.c +++ b/drivers/ifxmodem/radio-settings.c

[PATCH] ifx: Remove modem selftest

Command used for self test is not working for all versions of the modem firmware. --- plugins/ifx.c | 65 +--- 1 files changed, 2 insertions(+), 63 deletions(-) diff --git a/plugins/ifx.c b/plugins/ifx.c index a41fc36..527a8c4 100644 ---

[PATCH] ifxmodem: add CNAP support

--- drivers/ifxmodem/voicecall.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 30e6991..87a48e6 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH] atmodem: close the list in clvl_range_query

--- drivers/atmodem/call-volume.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/atmodem/call-volume.c b/drivers/atmodem/call-volume.c index 6d87276..1e32a69 100644 --- a/drivers/atmodem/call-volume.c +++ b/drivers/atmodem/call-volume.c @@ -114,6 +114,7 @@ static

[PATCH v4 1/1] ifxmodem: move call creation to xcallstat_notify

--- drivers/ifxmodem/voicecall.c | 172 -- 1 files changed, 98 insertions(+), 74 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 648f46b..30e6991 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH v4 0/1] Refactor call status handling

Hi, Since XCALLSTAT reports the voice call status information and call id, creation of the call is moved inside xcallstat_notify function. Regards, Jeevaka Jeevaka Badrappan (1): ifxmodem: move call creation to xcallstat_notify drivers/ifxmodem/voicecall.c | 172

[PATCH 0/2] Add handling of XCOLP and refactor call status handling

of call status information and also removes the CRING handling. Regards, Jeevaka Jeevaka Badrappan (2): ifxmodem: add handling of XCOLP notification ifxmodem: refactor handling of call status drivers/ifxmodem/voicecall.c | 240 +++--- 1 files changed, 109

[PATCH 1/2] ifxmodem: add handling of XCOLP notification

--- drivers/ifxmodem/voicecall.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index f66815a..d31fa70 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH v2 0/5] Make use of defined call_status enum

Hi, Following set of patches makes use of the defined call_status enum instead of using the actual defined values. Regards, Jeevaka Jeevaka Badrappan (5): atmodem: use defined call_status enum hfpmodem: Use defined call_status enum huaweimodem: Use defined call_status enum ifxmodem

[PATCH v2 1/5] atmodem: use defined call_status enum

--- drivers/atmodem/voicecall.c | 51 +++ 1 files changed, 32 insertions(+), 19 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index 583e037..56fd858 100644 --- a/drivers/atmodem/voicecall.c +++

[PATCH v2 2/5] hfpmodem: Use defined call_status enum

--- drivers/hfpmodem/voicecall.c | 12 +++- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c index a87ddbe..f247bea 100644 --- a/drivers/hfpmodem/voicecall.c +++ b/drivers/hfpmodem/voicecall.c @@ -33,7 +33,7 @@

[PATCH v2 3/5] huaweimodem: Use defined call_status enum

--- drivers/huaweimodem/voicecall.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/huaweimodem/voicecall.c b/drivers/huaweimodem/voicecall.c index 53377d9..1800763 100644 --- a/drivers/huaweimodem/voicecall.c +++

[PATCH v2 5/5] stemodem: Use defined call_status enum

--- drivers/stemodem/voicecall.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c index 4a3a83d..b8fcf5b 100644 --- a/drivers/stemodem/voicecall.c +++ b/drivers/stemodem/voicecall.c @@ -255,8 +255,10

[PATCH v2 4/5] ifxmodem: Use defined call_status enum

--- drivers/ifxmodem/voicecall.c | 33 + 1 files changed, 21 insertions(+), 12 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index e7f72fc..5ff3bcc 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH 1/7] coding-style: Don't use hex with shift operator

--- doc/coding-style.txt | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/doc/coding-style.txt b/doc/coding-style.txt index 40bb36b..287e9e9 100644 --- a/doc/coding-style.txt +++ b/doc/coding-style.txt @@ -294,6 +294,18 @@ void foo() // Wrong { } +M16:

[PATCH 2/7] atmodem: M16 coding style fix

--- drivers/atmodem/voicecall.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index 56fd858..ee055da 100644 --- a/drivers/atmodem/voicecall.c +++ b/drivers/atmodem/voicecall.c @@ -168,7 +168,7 @@ static

[PATCH 3/7] hfpmodem: M16 coding style fix

--- drivers/hfpmodem/voicecall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/hfpmodem/voicecall.c b/drivers/hfpmodem/voicecall.c index f247bea..e5121f4 100644 --- a/drivers/hfpmodem/voicecall.c +++ b/drivers/hfpmodem/voicecall.c @@ -229,7 +229,7 @@ static

[PATCH 4/7] ifxmodem: M16 coding style fix

--- drivers/ifxmodem/voicecall.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index 5ff3bcc..f66815a 100644 --- a/drivers/ifxmodem/voicecall.c +++ b/drivers/ifxmodem/voicecall.c @@ -160,7 +160,7 @@

[PATCH 5/7] stemodem: M16 coding style fix

--- drivers/stemodem/voicecall.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/stemodem/voicecall.c b/drivers/stemodem/voicecall.c index b8fcf5b..ca275cd 100644 --- a/drivers/stemodem/voicecall.c +++ b/drivers/stemodem/voicecall.c @@ -148,8 +148,8 @@

[PATCH 6/7] modem: M16 coding style fix

--- src/modem.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modem.c b/src/modem.c index 8e243d8..6cb8fab 100644 --- a/src/modem.c +++ b/src/modem.c @@ -121,7 +121,7 @@ unsigned int __ofono_modem_callid_next(struct ofono_modem *modem) unsigned int i;

[PATCH] ifxmodem: refactor call status notifications

--- drivers/ifxmodem/voicecall.c | 197 +++--- 1 files changed, 90 insertions(+), 107 deletions(-) diff --git a/drivers/ifxmodem/voicecall.c b/drivers/ifxmodem/voicecall.c index f66815a..c6e3878 100644 --- a/drivers/ifxmodem/voicecall.c +++

[PATCH 0/5] Make use of defined call_status enum

Hi, Following set of patches makes use of the defined call_status enum instead of using the actual defined values. Regards, Jeevaka Jeevaka Badrappan (5): atmodem: use defined call_status enum hfpmodem: Use defined call_status enum huaweimodem: Use defined call_status enum ifxmodem

[PATCH 1/5] atmodem: use defined call_status enum

--- drivers/atmodem/voicecall.c | 51 +++ 1 files changed, 32 insertions(+), 19 deletions(-) diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c index 583e037..42b44fa 100644 --- a/drivers/atmodem/voicecall.c +++

  1   2   3   4   >