Re: [PATCH 3/3] Fix release clcc_source when voicecall driver is removed

2009-12-04 Thread Denis Kenzior
Hi Zhenhua,

 Release the timer to avoid invoking the callback function after
 voicecall driver is removed.

Patch has been applied.  Thanks.

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH 3/3] Fix release clcc_source when voicecall driver is removed

2009-12-03 Thread Zhenhua Zhang
Release the timer to avoid invoking the callback function after
voicecall driver is removed.
---
 drivers/atmodem/voicecall.c |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/drivers/atmodem/voicecall.c b/drivers/atmodem/voicecall.c
index 1f8e0d1..e210454 100644
--- a/drivers/atmodem/voicecall.c
+++ b/drivers/atmodem/voicecall.c
@@ -921,6 +921,9 @@ static void at_voicecall_remove(struct ofono_voicecall *vc)
 {
struct voicecall_data *vd = ofono_voicecall_get_data(vc);
 
+   if (vd-clcc_source)
+   g_source_remove(vd-clcc_source);
+
g_slist_foreach(vd-calls, (GFunc) g_free, NULL);
g_slist_free(vd-calls);
 
-- 
1.6.5.2

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono