Re: [V3 PATCH 2/3] PPP: Use default ACCM (0xffffffff) to trasmit package

[Denis Kenzior]

Hi Martin,

On 02/12/2011 03:41 AM, martin...@intel.com wrote:
 From: Martin Xu martin...@intel.com
 
 Using my Huawei EM770W modem, if set ACCM as 0x, RXJ-
 event breaks PPP link, after IP package transmit for a while.
 Using default ACCM, the issue can be fixed.
 I tested it at China Unicom networks.
 ---
  gatchat/ppp_lcp.c |8 +---
  1 files changed, 5 insertions(+), 3 deletions(-)
 
 diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c
 index cc3e231..91a8b67 100644
 --- a/gatchat/ppp_lcp.c
 +++ b/gatchat/ppp_lcp.c
 @@ -105,8 +105,7 @@ static void lcp_generate_config_options(struct lcp_data 
 *lcp)
  
  static void lcp_reset_config_options(struct lcp_data *lcp)
  {
 - lcp-req_options = REQ_OPTION_ACCM;
 - lcp-accm = 0;
 + /* Using the default ACCM */
  
   lcp_generate_config_options(lcp);
  }
 @@ -147,6 +146,7 @@ static void lcp_rca(struct pppcp_data *pppcp, const 
 struct pppcp_packet *packet)
   ppp_option_iter_init(iter, packet);
  
   while (ppp_option_iter_next(iter) == TRUE) {
 + const guint8 *data = ppp_option_iter_get_data(iter);
   switch (ppp_option_iter_get_type(iter)) {
   case ACCM:
   /*
 @@ -155,7 +155,9 @@ static void lcp_rca(struct pppcp_data *pppcp, const 
 struct pppcp_packet *packet)
* which control characters MUST remain mapped when
* the peer sends them.
*/
 - ppp_set_recv_accm(pppcp_get_ppp(pppcp), 0);
 +
 + ppp_set_recv_accm(pppcp_get_ppp(pppcp),
 + pppcpget_host_long(data));

make --no-print-directory all-am
  CC gatchat/ppp_lcp.o
cc1: warnings being treated as errors
gatchat/ppp_lcp.c: In function ‘lcp_rca’:
gatchat/ppp_lcp.c:160: error: implicit declaration of function
‘pppcpget_host_long’
make[1]: *** [gatchat/ppp_lcp.o] Error 1
make: *** [all] Error 2


   break;
   default:
   break;

Regards,
-Denis
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

[V3 PATCH 2/3] PPP: Use default ACCM (0xffffffff) to trasmit package

[martin . xu]

From: Martin Xu martin...@intel.com

Using my Huawei EM770W modem, if set ACCM as 0x, RXJ-
event breaks PPP link, after IP package transmit for a while.
Using default ACCM, the issue can be fixed.
I tested it at China Unicom networks.
---
 gatchat/ppp_lcp.c |8 +---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c
index cc3e231..91a8b67 100644
--- a/gatchat/ppp_lcp.c
+++ b/gatchat/ppp_lcp.c
@@ -105,8 +105,7 @@ static void lcp_generate_config_options(struct lcp_data 
*lcp)
 
 static void lcp_reset_config_options(struct lcp_data *lcp)
 {
-   lcp-req_options = REQ_OPTION_ACCM;
-   lcp-accm = 0;
+   /* Using the default ACCM */
 
lcp_generate_config_options(lcp);
 }
@@ -147,6 +146,7 @@ static void lcp_rca(struct pppcp_data *pppcp, const struct 
pppcp_packet *packet)
ppp_option_iter_init(iter, packet);
 
while (ppp_option_iter_next(iter) == TRUE) {
+   const guint8 *data = ppp_option_iter_get_data(iter);
switch (ppp_option_iter_get_type(iter)) {
case ACCM:
/*
@@ -155,7 +155,9 @@ static void lcp_rca(struct pppcp_data *pppcp, const struct 
pppcp_packet *packet)
 * which control characters MUST remain mapped when
 * the peer sends them.
 */
-   ppp_set_recv_accm(pppcp_get_ppp(pppcp), 0);
+
+   ppp_set_recv_accm(pppcp_get_ppp(pppcp),
+   pppcpget_host_long(data));
break;
default:
break;
-- 
1.6.1.3

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono