Re: question for concatenated message

[Aki Niemi]

ke, 2009-12-02 kello 05:11 +0100, ext Denis Kenzior kirjoitti:
  But in oFono didn't match above:
  For UCS2 is (255 * 66), default alphabet is (253* 153)
 
 oFono uses 16 bit sequence by default, so at least in the case of UCS2 it is 
 correct.

I think we should default to 8bit reference numbers, or at least make
this configurable. I've not seen 16bit ref numbers used much in the
wild.

Same applies to other dangerous encoding features, like language
variants. There should probably be a configuration option, or env
variable for distributors to easily enable/disable these as need be.

BTW, in smsutil.h, struct sms_assembly_node has guint8 ref, which in
sms_assembly_add_fragment() gets assigned a value from guint16.

Cheers,
Aki

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Re: question for concatenated message

[Aki Niemi]

ke, 2009-12-02 kello 18:55 +0100, ext Denis Kenzior kirjoitti:
  it was clear that we need /etc/ofono/main.conf at some point, but before
  getting into it, I prefer that we collect configurable options that we
  include and their preferred defaults. So feel free to propose what
  should be configured by the system integrators.
 
 Honestly I can't think of too many right now besides what has already been 
 discussed:
   - 16 bit vs 8 bit reference number for SMS concatenation headers
   - GSM dialect for encoding (this is currently not used)
 
 Hence this is a low priority item until this list becomes a bit more 
 substantial.

I agree.

Besides, the first item is quite a trivial patch, I think. Attaching it
here for interested parties.

Cheers,
Aki

From b5dd2963e7d5e36d5626773b53df3fa11cf03b2f Mon Sep 17 00:00:00 2001
From: Aki Niemi aki.ni...@nokia.com
Date: Thu, 3 Dec 2009 09:07:33 +0200
Subject: [PATCH] Default to using 8bit reference numbers

---
 src/sms.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/sms.c b/src/sms.c
index de7e0fb..00a9090 100644
--- a/src/sms.c
+++ b/src/sms.c
@@ -419,7 +419,7 @@ static DBusMessage *sms_send_message(DBusConnection *conn, DBusMessage *msg,
 	if (valid_phone_number_format(to) == FALSE)
 		return __ofono_error_invalid_format(msg);
 
-	msg_list = sms_text_prepare(text, 0, TRUE, ref_offset);
+	msg_list = sms_text_prepare(text, 0, FALSE, ref_offset);
 
 	if (!msg_list)
 		return __ofono_error_invalid_format(msg);
-- 
1.6.0.4

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono