Re: [PATCH] Add call-volume interface to allow user adjust speaker and mic volume

2009-09-29 Thread Denis Kenzior
Hi Zhenhua, Your patch has been applied. I refactored much of it afterwards :) Let me know if I have broken something. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

RE: [PATCH] Add call-volume interface to allow user adjust speaker and mic volume

2009-09-27 Thread Zhang, Zhenhua
Hi Marcel, Marcel Holtmann wrote: > Hi Zhenhua, > >> +#define CALL_VOLUME_INTERFACE "org.ofono.CallVolume" > > we have to stop doing this. Start using this: > > #define FOO_INTERFACE OFONO_SERVICE ".FooInterface" > >> +static void call_volume_unregister(struct ofono_atom *atom); > > That for

Re: [PATCH] Add call-volume interface to allow user adjust speaker and mic volume

2009-09-25 Thread Marcel Holtmann
Hi Zhenhua, > Makefile.am |4 +- > include/call-volume.h | 67 + > src/call-volume.c | 374 > + > src/ofono.h |1 + > 4 files changed, 444 insertions(+), 2 deletions(-) > create mode 100644 include/call-v

[PATCH] Add call-volume interface to allow user adjust speaker and mic volume

2009-09-25 Thread Zhang, Zhenhua
Hi, Attached is the patch to add call-volume interface for Ofono. It exposes two properties: 'SpeakerVolume' and 'MicrophoneVolume' to allow user could control phone volume through lower level driver. The ofono_call_volume_notify() is used to report call volume property change notification to the