Re: [PATCH] sim: validate IMS private identity

2021-01-15 Thread Denis Kenzior
Hi Sergey, This field may not be defined for ISIM in use. In this case the field still can be read from ISIM, though it will not contain a valid UTF8 string. For instance, it may contain 255 0xFF bytes. Ugh, seems like the SIM vendor can't follow RFC's either? 31.103 Section 4.2.2 says: "For

Re: [PATCH] sim: validate IMS private identity

2021-01-15 Thread Sergey Matyukevich
Hi Denis, > > Make sure that IMPI is a valid UTF8 string before attempting > > to report it via DBus. Otherwise ofono may crash on dbus assert. > > This field may not be defined for ISIM in use. In this case the > > field still can be read from ISIM, though it will not contain > > a valid UTF8 str

Re: [PATCH] sim: validate IMS private identity

2021-01-15 Thread Denis Kenzior
Hi Sergey, On 1/15/21 10:38 AM, Sergey Matyukevich wrote: Make sure that IMPI is a valid UTF8 string before attempting to report it via DBus. Otherwise ofono may crash on dbus assert. This field may not be defined for ISIM in use. In this case the field still can be read from ISIM, though it wil

[PATCH] sim: validate IMS private identity

2021-01-15 Thread Sergey Matyukevich
Make sure that IMPI is a valid UTF8 string before attempting to report it via DBus. Otherwise ofono may crash on dbus assert. This field may not be defined for ISIM in use. In this case the field still can be read from ISIM, though it will not contain a valid UTF8 string. For instance, it may conta