Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-18 Thread Denis Kenzior
Hi Guillaume, and can someone please run the unit tests if we are touching this: /testutil/Invalid Conversions: ** ERROR:unit/test-util.c:362:test_invalid: assertion failed: (res == NULL) Aborted (core dumped) The purpose of this test was to check if we were failing to convert an invalid GSM

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-18 Thread Guillaume Zajac
Hi, On 18/07/2012 14:31, Marcel Holtmann wrote: Hi Guillaume, + /* + * According to the 3GPP specifications 23.038 + * section 6.2.1.1: + * In the case there is no character in the extension + * table, the character of the main default alphabet + * table or the character from the National Lang

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-18 Thread Marcel Holtmann
Hi Guillaume, > + /* > + * According to the 3GPP specifications 23.038 > + * section 6.2.1.1: > + * In the case there is no character in the extension > + * table, the character of the main default alphabet > + * table or the character from the National Language > >>>

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-18 Thread Guillaume Zajac
Hi Denis, On 17/07/2012 04:09, Denis Kenzior wrote: Hi Guillaume, + /* + * According to the 3GPP specifications 23.038 + * section 6.2.1.1: + * In the case there is no character in the extension + * table, the character of the main default alphabet + * table or the character from the National

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-17 Thread Denis Kenzior
Hi Guillaume, + /* + * According to the 3GPP specifications 23.038 + * section 6.2.1.1: + * In the case there is no character in the extension + * table, the character of the main default alphabet + * table or the character from the National Language + * Locking Shift Table should be displayed.

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-17 Thread Guillaume Zajac
Hi Denis, On 16/07/2012 02:49, Denis Kenzior wrote: Hi Guillaume, On 07/16/2012 09:34 AM, Guillaume Zajac wrote: --- src/util.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/util.c b/src/util.c index aecc790..41ef3d4 100644 --- a/src/util.c ++

Re: [PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-16 Thread Denis Kenzior
Hi Guillaume, On 07/16/2012 09:34 AM, Guillaume Zajac wrote: --- src/util.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/util.c b/src/util.c index aecc790..41ef3d4 100644 --- a/src/util.c +++ b/src/util.c @@ -628,8 +628,16 @@ char *convert_gsm_

[PATCH] util: Fix GSM to UTF8 conversion mechanism

2012-07-16 Thread Guillaume Zajac
--- src/util.c | 17 ++--- 1 files changed, 14 insertions(+), 3 deletions(-) diff --git a/src/util.c b/src/util.c index aecc790..41ef3d4 100644 --- a/src/util.c +++ b/src/util.c @@ -628,8 +628,16 @@ char *convert_gsm_to_utf8_with_lang(const unsigned char *text, long len,