Re: [PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Aki Niemi
Hi Rémi,

2011/1/19 Rémi Denis-Courmont remi.denis-courm...@nokia.com:
 ---
  doc/connman-api.txt |   10 ++
  1 files changed, 10 insertions(+), 0 deletions(-)

 diff --git a/doc/connman-api.txt b/doc/connman-api.txt
 index 22e02e5..13f622c 100644
 --- a/doc/connman-api.txt
 +++ b/doc/connman-api.txt
 @@ -77,6 +77,16 @@ Properties   boolean Attached [readonly]
                        be available, e.g. receiving SMS over packet radio
                        or network initiated PDP activation.

 +               string Bearer [readonly, optional]
 +
 +                       Contains the data bearer technology as reported by the
 +                       GPRS service registration (if known).
 +
 +                       Possible values are:
 +                       gsm, edge, umts, hsdpa, hsupa,
 +                       hspa (HSDPA and HSUPA at the same time) and
 +                       lte
 +

Should this also report 'none'? At least CPSB can report that a
context is idle, i.e., no bearer associated with it.

Cheers,
Aki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Rémi Denis-Courmont
On Thursday 20 January 2011 10:06:50 ext Aki Niemi, you wrote:
 Hi Rémi,
 
 2011/1/19 Rémi Denis-Courmont remi.denis-courm...@nokia.com:
  ---
   doc/connman-api.txt |   10 ++
   1 files changed, 10 insertions(+), 0 deletions(-)
  
  diff --git a/doc/connman-api.txt b/doc/connman-api.txt
  index 22e02e5..13f622c 100644
  --- a/doc/connman-api.txt
  +++ b/doc/connman-api.txt
  @@ -77,6 +77,16 @@ Properties   boolean Attached [readonly]
 be available, e.g. receiving SMS over packet radio
 or network initiated PDP activation.
  
  +   string Bearer [readonly, optional]
  +
  +   Contains the data bearer technology as reported
  by the +   GPRS service registration (if known).
  +
  +   Possible values are:
  +   gsm, edge, umts, hsdpa, hsupa,
  +   hspa (HSDPA and HSUPA at the same time) and
  +   lte
  +
 
 Should this also report 'none'? At least CPSB can report that a
 context is idle, i.e., no bearer associated with it.

Right.

-- 
Rémi Denis-Courmont
Nokia Devices RD, Maemo Software, Helsinki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Rémi Denis-Courmont
---
 doc/connman-api.txt |   10 ++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/doc/connman-api.txt b/doc/connman-api.txt
index 22e02e5..22c59dc 100644
--- a/doc/connman-api.txt
+++ b/doc/connman-api.txt
@@ -77,6 +77,16 @@ Properties   boolean Attached [readonly]
be available, e.g. receiving SMS over packet radio
or network initiated PDP activation.
 
+   string Bearer [readonly, optional]
+
+   Contains the data bearer technology as reported by the
+   GPRS service registration (if known).
+
+   Possible values are:
+   none, gsm, edge, umts, hsdpa, hsupa,
+   hspa (HSDPA and HSUPA at the same time) and
+   lte
+
boolean Suspended [readonly, optional]
 
Contains whether the GPRS service is suspended.
-- 
1.7.1

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: [PATCH 5/6] GPRS: document bearer property

2011-01-20 Thread Marcel Holtmann
Hi Remi,

  doc/connman-api.txt |   10 ++
  1 files changed, 10 insertions(+), 0 deletions(-)

patch has been applied and in this case I would have preferred to have a
doc: prefix.

Regards

Marcel


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


[PATCH 5/6] GPRS: document bearer property

2011-01-19 Thread Rémi Denis-Courmont
---
 doc/connman-api.txt |   10 ++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/doc/connman-api.txt b/doc/connman-api.txt
index 22e02e5..13f622c 100644
--- a/doc/connman-api.txt
+++ b/doc/connman-api.txt
@@ -77,6 +77,16 @@ Properties   boolean Attached [readonly]
be available, e.g. receiving SMS over packet radio
or network initiated PDP activation.
 
+   string Bearer [readonly, optional]
+
+   Contains the data bearer technology as reported by the
+   GPRS service registration (if known).
+
+   Possible values are:
+   gsm, edge, umts, hsdpa, hsupa,
+   hspa (HSDPA and HSUPA at the same time) and
+   lte
+
boolean Suspended [readonly, optional]
 
Contains whether the GPRS service is suspended.
-- 
1.7.1

___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono