Re: [PATCH v5 1/4] Detect SARA R4 QMI device

Hi Denis, On 12/05/2021 09:40, Bing Jupiter wrote: A comment along these lines might be appropriate: Unlike other uBlox, the SARA R4 is actually a Qualcomm part and supports the QMI protocol mostly as implemented in ofono. The AT command set for this modem does not correspond to that used

Re: [PATCH v5 1/4] Detect SARA R4 QMI device

Hello, I didn't go through the whole patch but I think you mixed 4 spaces with tab. The same problem exist in your 4 patches. Best Regards, Christophe On 5/12/21 9:40 AM, Bing Jupiter wrote: > --- > plugins/udevng.c | 42 ++ > 1 file changed, 42

[PATCH v5 1/4] Detect SARA R4 QMI device

--- plugins/udevng.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/plugins/udevng.c b/plugins/udevng.c index 34ac1cc0..46bf5532 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -1194,6 +1194,46 @@ static gboolean setup_ublox(struct