Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread andrzej zaborowski
2009/10/25 andrzej zaborowski : > Now that I think of it if the current status is 'searching' then > possibly there's no point calling driver->set_attached (see second > patch). I repeated the same typo in this patch, attached is a corrected version, sorry. Regards From d0f0331ea8d3f8c4df75069cfc

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread andrzej zaborowski
2009/10/25 Denis Kenzior : >> > Lets suppose status=registered arrives and we're already attached.  Here >> > attached will be set to FALSE, Attached property will be set to false and >> > emitted.  gprs_netreg_update will presumably reset Attached back to True. >> >> Now I see it and you're absolu

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread Denis Kenzior
Hi, > > Lets suppose status=registered arrives and we're already attached. Here > > attached will be set to FALSE, Attached property will be set to false and > > emitted. gprs_netreg_update will presumably reset Attached back to True. > > Now I see it and you're absolutely right to be alerted, I

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread andrzej zaborowski
Hi, 2009/10/24 Denis Kenzior : >> > in set_registration_status: >> >        attached = (status != NETWORK_REGISTRATION_STATUS_REGISTERED && >> >                        status != NETWORK_REGISTRATION_STATUS_ROAMING); >> >        if (gprs->attached != (int) attached && >> >                        !(

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread Denis Kenzior
Hi Andrew, > 2009/10/24 andrzej zaborowski : > > 2009/10/24 Denis Kenzior : > >> Ok, so I took the patch and hacked on it for a while. I disagreed with > >> how you split up responsibilities, so much of the logic got moved into > >> the core and the driver was simplified. > > By the way I notice

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread Denis Kenzior
Hi Andrew, > > in set_registration_status: > >attached = (status != NETWORK_REGISTRATION_STATUS_REGISTERED && > >status != NETWORK_REGISTRATION_STATUS_ROAMING); > >if (gprs->attached != (int) attached && > >!(gprs->flags & GPRS_FLAG_AT

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread Andrzej Zaborowski
2009/10/24 andrzej zaborowski : > 2009/10/24 Denis Kenzior : >> Ok, so I took the patch and hacked on it for a while.  I disagreed with how >> you split up responsibilities, so much of the logic got moved into the core >> and the driver was simplified. By the way I notice that in most atoms' _crea

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-24 Thread andrzej zaborowski
Hi, 2009/10/24 Denis Kenzior : > Ok, so I took the patch and hacked on it for a while.  I disagreed with how > you split up responsibilities, so much of the logic got moved into the core > and the driver was simplified. Yes, there were a couple of possible choices, I chose to align with how the l

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-23 Thread Denis Kenzior
Hi Andrew, > Hi, > here's a one-big-patch that adds the DataConnectionManager interface > according to doc/dataconnectionmanager-api.txt without any glue for > the multiplexer or PPP setup. Only AT backend is implemented. Ok, so I took the patch and hacked on it for a while. I disagreed with ho

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-16 Thread Denis Kenzior
Hi Andrew, > 2009/10/12 Andrzej Zaborowski : > > here's a one-big-patch that adds the DataConnectionManager interface > > according to doc/dataconnectionmanager-api.txt without any glue for > > the multiplexer or PPP setup. Only AT backend is implemented. > > This patch depends on 0001 attached,

Re: [RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-12 Thread Andrzej Zaborowski
2009/10/12 Andrzej Zaborowski : > here's a one-big-patch that adds the DataConnectionManager interface > according to doc/dataconnectionmanager-api.txt without any glue for > the multiplexer or PPP setup.  Only AT backend is implemented. This patch depends on 0001 attached, other patches are small

[RFC] GPRS context setup and teardown (doc/dataconnectionmanager-api.txt)

2009-10-12 Thread Andrzej Zaborowski
Hi, here's a one-big-patch that adds the DataConnectionManager interface according to doc/dataconnectionmanager-api.txt without any glue for the multiplexer or PPP setup. Only AT backend is implemented. One issue with the AT implementation of the api is that "Powered" (a read-write property) can