Re: ofono patch review policy?

2011-03-01 Thread George Matveev
Hi Aki,

thanx for clarifying this to me (and possibly others).

Could you please have a look (when you have a minute or so)
into that (rather cosmetic) patch and let me know if it's good enough
to be applied or if I should (fix and) re-submit.

Ha det så bra,
George

> Hi George,
>
> 2011/3/1 George Matveev :
>> on February 6, I submitted a patch (isimodem):
>>
>> http://lists.ofono.org/pipermail/ofono/2011-February/008635.html
>>
>> But it is already March and the patch has never been reviewed nor
>> formally
>> rejected.
>
> Sorry, I had missed that.
>
>> Other people had asked similar questions regarding their patches
>> recently
>> on #ofono IRC.
>>
>> It would be nice to understand if there's any patch review
>> policy/procedure in this project?
>
> Currently, patch submitters are kindly asked to follow through. That
> is, if the patch doesn't receive attention, to resubmit, and bug the
> maintainers long enough for them to review the patch.
>
> It's not optimal, but the inflow is quite big at the moment, and I
> have been for instance (among other duties) quite busy with the
> wgmodem2.5 patches.
>
> Cheers,
> Aki
> ___
> ofono mailing list
> ofono@ofono.org
> http://lists.ofono.org/listinfo/ofono
>


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


Re: ofono patch review policy?

2011-03-01 Thread Aki Niemi
Hi George,

2011/3/1 George Matveev :
> on February 6, I submitted a patch (isimodem):
>
> http://lists.ofono.org/pipermail/ofono/2011-February/008635.html
>
> But it is already March and the patch has never been reviewed nor formally
> rejected.

Sorry, I had missed that.

> Other people had asked similar questions regarding their patches recently
> on #ofono IRC.
>
> It would be nice to understand if there's any patch review
> policy/procedure in this project?

Currently, patch submitters are kindly asked to follow through. That
is, if the patch doesn't receive attention, to resubmit, and bug the
maintainers long enough for them to review the patch.

It's not optimal, but the inflow is quite big at the moment, and I
have been for instance (among other duties) quite busy with the
wgmodem2.5 patches.

Cheers,
Aki
___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono


ofono patch review policy?

2011-03-01 Thread George Matveev
Hi,

on February 6, I submitted a patch (isimodem):

http://lists.ofono.org/pipermail/ofono/2011-February/008635.html

But it is already March and the patch has never been reviewed nor formally
rejected.

Other people had asked similar questions regarding their patches recently
on #ofono IRC.

It would be nice to understand if there's any patch review
policy/procedure in this project?

Br,
George


___
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono