Re: [PATCH 2/4] xmm7modem: drop executable bit from C source file

2018-02-14 Thread Jonas Bonn
On 02/05/2018 05:20 PM, Denis Kenzior wrote: Hi Jonas, On 02/04/2018 04:55 PM, Jonas Bonn wrote: ---   drivers/xmm7modem/ims.c | 0   1 file changed, 0 insertions(+), 0 deletions(-)   mode change 100755 => 100644 drivers/xmm7modem/ims.c Applied, thanks. What about the other three patches?

Re: [PATCH 0/5] Add Bluetooth HFP memory index dialing V3

2018-02-14 Thread Philippe De Swert
Hi Denis, On 13/02/2018, Denis Kenzior wrote: > I went ahead and applied the entire series. I did fix up a few minor > style & whitespace issues. And the unneeded strcat I forgot to remove ;) Thanks! Philippe ___ ofono mailing

GPRS Attach/Detach

2018-02-14 Thread Nikolas Sepos
Hello ofono maintainers, i had an issue with a modem and the GPRS attach/detach command. It was hanging my modem for 3 seconds (modem issue not ofono). So in order to work around it i implemented attach and detach as NoOp (not sending AT+CGATT=0/1) but still had to callback to ofono that i am

Re: GPRS Attach/Detach

2018-02-14 Thread Denis Kenzior
Hi Nikolas, I had to remove the `else if (have_active_contexts(gprs) == TRUE) { ... }` block because when attached was TRUE i still had active context and i didn't want it to be deactivated. This particular logic was added in commit: 154f4aca65b3b419239be75d0def276bd7f4dc8e As the

Re: [PATCH] udevng: Add OFONO_PATHNAME property to set modem dbus path name

2018-02-14 Thread Denis Kenzior
Hi Pau, On 02/13/2018 01:53 PM, Pau Espin Pedrol wrote: The current udevng.c implementation sets dbus path names for modems based on type and a number incremented seuqntially for each new modem found. As a result, the dbus path for a given device is non deterministic, since it depends on the

Re: [PATCH 2/4] xmm7modem: drop executable bit from C source file

2018-02-14 Thread Denis Kenzior
Hi Jonas, What about the other three patches?  Are they being silently rejected or did they just fall off the radar? In particular, patch 1/4 is important... They're not ignored, but I'm not competent enough to review the build system changes. They need to be acked by Marcel first who

Re: [PATCH] udevng: Add OFONO_PATHNAME property to set modem dbus path name

2018-02-14 Thread Pau Espin Pedrol
Hi Denis, On 14/02/18 18:04, Denis Kenzior wrote: This sounds like a very specific non-real world usecase, right?  I mean why don't you simply compare the IMEI if you really care? First of all, I like thinking that I'm part of the real world! As far as I understand the IMEI is available in

Re: [PATCH] udevng: Add OFONO_PATHNAME property to set modem dbus path name

2018-02-14 Thread Denis Kenzior
Hi Pau, As far as I understand the IMEI is available in org.ofono.Modem.GetProperties "Serial" property. To be able to access this information, I need to previously power on the modem (SetProperty Powered true), otherwise it doesn't show up. Which means that for an ofono user, it is a