[PATCH v5 0/4]

Cleaned up comments and resubmit Bing Jupiter (4): Detect SARA R4 QMI device Detect SARA R4 QMI device Detect SARA R4 QMI device Detect SARA R4 QMI device drivers/atmodem/vendor.h | 1 + drivers/qmimodem/gprs.c | 10 ++ plugins/gobi.c | 11 ++-

[PATCH v5 3/4] Detect SARA R4 QMI device

--- drivers/qmimodem/gprs.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/qmimodem/gprs.c b/drivers/qmimodem/gprs.c index 896a9e4c..fa20b809 100644 --- a/drivers/qmimodem/gprs.c +++ b/drivers/qmimodem/gprs.c @@ -26,6 +26,7 @@ #include #include #include +#include

[PATCH v5 4/4] Detect SARA R4 QMI device

--- plugins/gobi.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/plugins/gobi.c b/plugins/gobi.c index 9b5d7cff..5472dd83 100644 --- a/plugins/gobi.c +++ b/plugins/gobi.c @@ -47,6 +47,7 @@ #include #include #include +#include #include #include @@

[PATCH v5 2/4] Detect SARA R4 QMI device

--- drivers/atmodem/vendor.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/atmodem/vendor.h b/drivers/atmodem/vendor.h index 82284e44..38613679 100644 --- a/drivers/atmodem/vendor.h +++ b/drivers/atmodem/vendor.h @@ -48,6 +48,7 @@ enum ofono_vendor {

Re: [PATCH v5 1/4] Detect SARA R4 QMI device

Hello, I didn't go through the whole patch but I think you mixed 4 spaces with tab. The same problem exist in your 4 patches. Best Regards, Christophe On 5/12/21 9:40 AM, Bing Jupiter wrote: > --- > plugins/udevng.c | 42 ++ > 1 file changed, 42

[PATCH v5 1/4] Detect SARA R4 QMI device

--- plugins/udevng.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/plugins/udevng.c b/plugins/udevng.c index 34ac1cc0..46bf5532 100644 --- a/plugins/udevng.c +++ b/plugins/udevng.c @@ -1194,6 +1194,46 @@ static gboolean setup_ublox(struct

Re: [PATCH v5 2/4] Detect SARA R4 QMI device

Add vendor tag for uBlox SARA R4 modems. This device is actually a Qualcomm part so it doesn't fall under the uBlox category of devices, at all. /Jonas On 12/05/2021 09:40, Bing Jupiter wrote: --- drivers/atmodem/vendor.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v5 1/4] Detect SARA R4 QMI device

Hi Denis, On 12/05/2021 09:40, Bing Jupiter wrote: A comment along these lines might be appropriate: Unlike other uBlox, the SARA R4 is actually a Qualcomm part and supports the QMI protocol mostly as implemented in ofono. The AT command set for this modem does not correspond to that used

Re: [PATCH v5 0/4]

Hi Denis, If we're going to get anywhere with this, the onus probably falls on you to do some cleanup work on these patches. I'll write some comments on the patches and maybe you can munge those into the commit messages...? Bing Jupiter has been running this modem (uBlox SARA R4) for well

Re: [PATCH v5 3/4] Detect SARA R4 QMI device

The SARA R4 modem detaches permanently from the network when the NAS Detach action is called. This is problematic because ofono calls Detach when network connectivity is temporarily lost resulting in the modem never attempting to reattach again when the network once again becomes available.

Re: [PATCH v5 4/4] Detect SARA R4 QMI device

Hi Denis, This patch is fine, with one little fix below. Patch message: All QMI devices are currently piggy-backing on the 'gobi' driver to set up the QMI atoms. For the SARA R4, this works with the addition of a quirk. This patch adds the handling of a SARA R4 quirk to the 'gobi' driver.