Re: MNC/MCC as string?

2009-06-11 Thread Marcel Holtmann
Hi Jan, The attributes are really only for informational purposes only. The user would not base his decision on the mcc/mnc, but on the operator name. So before we start changing the D-Bus APIs, we need to answer these two questions: - Can a country/administrative

Re: MNC/MCC as string?

2009-06-11 Thread Marcel Holtmann
Hi Denis, I wasn't aware of this and so it might be better to just expose these as an operator id string. So we might not even split into MCC/MNC at all since it is meaning less anyway. I'm tending to agree, which is why I wanted to start the conversation. By the way, just so that

The very first oFono release

2009-07-10 Thread Marcel Holtmann
Hello everyone, I just went ahead and tagged version 0.1 of oFono. We have announced this project about 3 month ago, but the actual code base is a little bit older of course. And at some point we have to start making releases :) http://www.kernel.org/pub/linux/network/ofono/ Not

Re: [PATCH RESEND] add zoned debug support

2009-08-11 Thread Marcel Holtmann
Hi Andres, This adds debug flags so that when users are debugging, they can pass arguments to --debug to specify what they want shown. --debug without any args defaults to prior behavior. --- include/log.h | 11 +-- src/log.c | 11 +++ src/main.c| 25

Re: GPRS support for Ofono

2009-09-01 Thread Marcel Holtmann
Hi Denis, So as it happens I had also been brainstorming a GPRS API for the last several days. And somewhat spontaneously a GPRS api discussion happened on IRC between myself, Marcel and Ismo. The following GPRS API proposal is a result of this discussion. I'd like all interested to

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Remi, Our current assumption is that the basic setup of IP address, netmask and broadcast are done by oFono. Only routing and DNS are up to other programs like ConnMan for example. WHAAT? No way. There is just no way. We need to support letting the calling program configure

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Ismo, of this discussion. I'd like all interested to comment. What needs improvement? What is missing? What should be removed? Here are some comments. Some of the comments were already present in the IRC discussion, but I'll repeat them here anyway. First of all, the both Denis's

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Aki, Powered = on and RoamingAllowed = yes and Roaming = true will lead to auto-attach. Powered = on and RoamingAllowed = no and Roaming = true will lead to detach. Powered = on and Roaming = false will lead to auto-attach. Powered = off will lead to detach. Why is

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Remi, I mentioned that already. We do wanna store something like Type that says internet, mms, wap etc. The only comment here was that for network initiated context we have no idea of its intent. And we do not want to. The attachment to the GPRS network in this proposal is bit

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Aki, AFAIK, attach status of GPRS has both regulatory aspects to consider (some operators require always attached vs. some prohibit it) as well as power consumption issues (auto-attach might draw more power than on-demand, although there's an inverse effect on latency). These are

RE: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Waldo, I am still not seeing the point in what suspended will do for us and the UI. And that Maemo 5 exposed such a state in the UI is not an argument to keep doing it. I asked this before, what are we suppose to be doing when we get signaled suspended? User, as well as

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Remi, Actually this one is missing from the API proposal. Marcel already wanted the context type (internet, mms, wap, etc) information. I've updated the proposed API in git. This is not going to work. Depending on the operator, you may have more than one type for a single

RE: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Waldo, I know why you want this, but I'm still against the counter being an oFono driver API. There needs to be a proper kernel interface that signals the application when an interface has gone away with the rx/tx details. This way we handle this generically for all modems

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Denis, The reason is simple, Nokia modems suspend GPRS when scanning (or registering), simply because the operation will take roughly three times as long with GPRS attached. You will find this feature in current phones, too. Then ideally you should have two scan modes,

Re: GPRS support for Ofono

2009-09-02 Thread Marcel Holtmann
Hi Remi, It's probably difficult if the PC client is allowed to redefine GPRS contexts, but otherwise oFono should at least be able to report the total tx/rx for the context's it has defined. The BT DUN / USB bridge could call into oFono and trigger a poll of all the stats to update

Re: [PATCH 1/2] G1: Add initial HTC G1 modem support

2009-09-02 Thread Marcel Holtmann
Hi Andreas, G1 plugin is based on generic_at, with a bunch of stuff dropped and simplified. We use AT+CFUN=1 for powering on rather than having a configurable init string. We also manually set the default state during init (the G1 appears to start in mode V0 by default). The device

Re: [PATCH 2/2] G1: Add a G1 syntax for parsing

2009-09-02 Thread Marcel Holtmann
Hi Andreas, This is based on the generic_at parser, with unnecessary stuff removed. The G1 routinely screws up CRLFs, so the parser needs to account for that. This parser ignores leading CRLFs (which is what reference-ril does as well), as well as trailing LFs (which are sometimes left

Re: [PATCH] G1: Add an SMS quirk for CNMI mode

2009-09-02 Thread Marcel Holtmann
Hi Andres, The G1 doesn't support mode2, despite advertising it. The G1 chokes w/ an Error 303 when we specify NMI mode 2. Adding a quirk to drop that mode from the supported list (just use mode 1) allows the G1 to properly deal with SMS. --- drivers/atmodem/sms.c| 19

Comments about ofono-0.4 release

2009-09-02 Thread Marcel Holtmann
Hi guys, since we had so much movement in the source code, I went ahead and tagged a new version. So welcome our 0.4 release. The internal modem driver and feature frameworks got a whole re-write, but I am not going into that details here. Go and join the IRC if you really care about it ;) With

Support for GSM data cards

2009-09-03 Thread Marcel Holtmann
Hi guys, so I started working on udev integration and auto-detection and pushed a few new drivers into the upstream oFono repository. It know has drivers for Android/HTC G1, Ericsson MBM, Option HSO, Novatel and Huawai modems. An example of three devices attached to the same system would look

Re: failed to start ofonod....

2009-09-24 Thread Marcel Holtmann
Hi Lihan, I also face the problem when I install ofono on a new machine. Unable to hop onto D-Bus I run as root, but the same error as WuYongbo and no configure directory “ofono” under /etc By the way, I manually installed dbus-1-dev and dbus-glib-1-dev, unless

Re: [Patch]Unref GIOChannel in g_at_chat_new_from_tty

2009-09-24 Thread Marcel Holtmann
Hi Zhenhua, Attached is the patch to unref GIOChannel in g_at_chat_new_from_tty. If the GAtChat is created from g_at_chat_new, the reference count of channel is increased by g_io_add_watch_full(channel), so we need to unref it. If GAtChat is failed to create, we also need to unref channel

Re: [PATCH] Autotool improvements.

2009-10-09 Thread Marcel Holtmann
Hi guys, Bootstrap script now tries to use explicitly versioned automake, which makes life easier with scratchbox and friends. Bootstrap also uses autoreconf instead of explictly running various autotools. As autoreconf already uses those variables, I wonder why not just call it and be

Re: [PATCH] Replace Glib type with standard C type

2009-10-24 Thread Marcel Holtmann
Hi Denis, Below patch is to replace Glib type with standard C type in hfpmodem.h, like guint, guint8, etc. Patch has been applied. Thanks. please double check the author name is in the right format. Firstname Lastname and not Lastname, Firstname what Exchange always messes up. Git will

Re: [PATCH 1/2] Added functionality to remove modem from system, if needed.

2009-10-29 Thread Marcel Holtmann
Hi Ryan, --- test/enable-modem |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/test/enable-modem b/test/enable-modem index 0f9f604..d44783d 100755 --- a/test/enable-modem +++ b/test/enable-modem @@ -1,6 +1,7 @@ #!/usr/bin/python import dbus +import

Re: Patch on unsupported AT command

2009-11-13 Thread Marcel Holtmann
Hi Yang, If some unsupported AT command is issued, different modem may have their own response. Now at my hand is a Huawei modem (EM770W), and it returns COMMAND NOT SUPPORT. In my case, this modem doesn't support AT+CGAUTO=0 in atmodem/gprs.c. Current oFono will hang there for it's

Re: Patch on unsupported AT command

2009-11-13 Thread Marcel Holtmann
Hi Denis, I think this might need a GAtChat quirk function where we can add extra terminator responses that will be recognized. And maybe even translated into something meaningful. Originally I had the terminators freely definable on the GAtChat + some hardcoded ones, but abandoned

RE: Patch on unsupported AT command

2009-11-17 Thread Marcel Holtmann
Hi Yang, I think this might need a GAtChat quirk function where we can add extra terminator responses that will be recognized. And maybe even translated into something meaningful. Originally I had the terminators freely definable on the GAtChat + some hardcoded ones, but

Re: Patch on unsupported AT command

2009-11-17 Thread Marcel Holtmann
Hi Denis, +g_at_chat_add_terminator(chat, +EXT ERROR:, 11, FALSE); +g_at_chat_add_terminator(chat, +CME ERROR:, 11, FALSE); +g_at_chat_add_terminator(chat, +CMS ERROR:, 11, FALSE); +g_at_chat_add_terminator(chat, NO ANSWER, -1, FALSE); +g_at_chat_add_terminator(chat,

Re: Palm Pre modem plugin

2009-11-21 Thread Marcel Holtmann
Hi Morphis, I saw you added some time ago support for the Palm Pre MSM Modem. I am working on the FSO (http://www.freesmartphone.org/) side to support this kind of MSM modem as well. I am are currently stucked with the binary protocol spoken between modem and userland in

Re: Palm Pre modem plugin

2009-11-21 Thread Marcel Holtmann
Hi Morphis, I saw you added some time ago support for the Palm Pre MSM Modem. I am working on the FSO (http://www.freesmartphone.org/) side to support this kind of MSM modem as well. I am are currently stucked with the binary protocol spoken between

Re: Palm Pre modem plugin

2009-11-22 Thread Marcel Holtmann
Hi guys, The forth and worring is that a developer may be forced to use ofono, as the target device has some closed parts necessary for the os that does not work anymore if you remove ofono and use FSO. Please do not post these crazy conspiracy theories here. oFono is GPLed for exactly

Re: Palm Pre modem plugin

2009-11-22 Thread Marcel Holtmann
Hi Morphis, I am currently working on the implementation of the basics I found out about the protocol. I split the whole code into two projects: msmcommd and libmsmcomm. msmcommd is a daemon which does all the link layer protocol handling which is required to speak probably

RE: Patch on unsupported AT command

2009-11-22 Thread Marcel Holtmann
Hi Yang, looks good so far, but ... +static gboolean check_terminator(struct terminator_info *info, char *line) +{ + if ((info-len == -1 !strcmp(line, info-terminator)) || + (info-len 0 !strncmp(line, info-terminator, info-len))) + return TRUE; +

Re: [PATCH] Add mpty field to ofono_call

2009-11-23 Thread Marcel Holtmann
Hi Zhenhua, A field 'mpty' is added to ofono_call so that we can know whether the call belongs to multiparty call or not. According to 27.007 7.18, it is a defined return value of AT+CLCC. --- drivers/atmodem/atutil.c |4 +++- include/types.h |1 + 2 files changed, 4

Re: Palm Pre modem plugin

2009-11-23 Thread Marcel Holtmann
Hi Nicola, The forth and worring is that a developer may be forced to use ofono, as the target device has some closed parts necessary for the os that does not work anymore if you remove ofono and use FSO. Please do not post these crazy conspiracy theories here. oFono is GPLed for

Re: Patch on unsupported AT command

2009-11-23 Thread Marcel Holtmann
Hi Denis, This is first of all violating the coding style with the indentation on the second line of the if, but it is also way too complicated. There is actually a reason for this. if (info-len == -1 !strcmp(line, info-terminator) return TRUE; This part checks

First release with GPRS support

2009-11-23 Thread Marcel Holtmann
Hello everyone, I just tagged, pushed and uploaded 0.11 release of oFono. Besides the usual bug fixes in various areas, this comes now with GPRS support. If you happen to have a Ericsson MBM or Option HSO based modem, then you under lucky ones who can try GPRS support. To configure your Primary

Re: [PATCH] Added test script to enter pin to sim card.

2009-11-24 Thread Marcel Holtmann
Hi Ryan, --- test/enter-pin.py | 28 1 files changed, 28 insertions(+), 0 deletions(-) create mode 100755 test/enter-pin.py don't forget to modify EXTRA_DIST of Makefile.am and please remove the .py suffix. We don't do that with our test scripts. diff --git

RE: Patch on unsupported AT command

2009-11-24 Thread Marcel Holtmann
Hi Yang, Maybe it is too early in the morning to do code review, but this should be doing the same, but be a lot simpler to read ;) You're absolutely right. In this way, the code is more readable. Please review again. both patches have been applied. Thanks. Regards Marcel

Re: Huawei E220 + Data Connection Manager

2009-12-01 Thread Marcel Holtmann
Hi Mitsutaka, I'm trying to implement for Huawei E220 using Data Connection Manager. I understand GPRS data conneciton is working in progress. But I don't know much connection sequence that. So I'd like to tell me how should I approach. and I guess data connection in the following. If I

Re: GPRS support for Ofono

2009-12-07 Thread Marcel Holtmann
Hi Ismo, since we have the upstream GPRS support for MBM and HSO devices, it would be great to have this for Phonet, too. I tried to work on the patch, but without proper documentation it is impossible. So please adapt it to the current upstream and resend it. Yes, the GPRS ISI support

Re: light test report for oFono v0.11

2009-12-07 Thread Marcel Holtmann
Hi Elvam Test Environment --- general PC (pre-installed FC11) - oFono v0.11, oFono v0.10 - phonesim package --- please update to Fedora 12 since I changed the actual build requirements for oFono to a more recent libudev

Re: GPRS support for Ofono

2009-12-10 Thread Marcel Holtmann
Hi Remi, I haven't had time to look at the context stuff yet. It's just worse. oFono is enforcing an integer ID on any primary context. This is again an idiosyncrasy of AT commands. With ISI modems, the context ID space is managed by the modem, so oFono does not get to choose. In

Merry Christmas to everyone

2009-12-24 Thread Marcel Holtmann
Hello everyone, and Santa is coming to town and bringing the 0.15 release with him. Many thanks to all contributors during this year. We had 28 different contributors with all together 1464 commits in the public repository which goes back as far as April. The line count summary for a project

Re: [PATCH 1/1] add netmask to hso gprs-context driver

2009-12-24 Thread Marcel Holtmann
Hi Martin, diff --git a/drivers/hsomodem/gprs-context.c b/drivers/hsomodem/gprs-context.c index 0526fcc..721a017 100644 --- a/drivers/hsomodem/gprs-context.c +++ b/drivers/hsomodem/gprs-context.c @@ -47,6 +47,8 @@ #define AUTH_BUF_LENGTH OFONO_GPRS_MAX_USERNAME_LENGTH + \

Re: [RFC 1/3] STE-plugin: Add vendor STE

2010-01-17 Thread Marcel Holtmann
Hi Sjur, This patch add STE as vendor, and a few adjustments needed in atmodem for ST-Ericsson modem. --- drivers/atmodem/gprs.c | 15 +-- drivers/atmodem/vendor.h |5 + plugins/modemconf.c |5 + 3 files changed, 23 insertions(+), 2 deletions(-)

Re: [RFC 3/3] STE-plugin: Adding STE plugin

2010-01-17 Thread Marcel Holtmann
Hi Sjur, Added implementation for STE modem; STE modem driver, and STE specific drivers for gprs, network registration and voice call. This patch uses CAIF sockets. CAIF patch for net-next-2.6 will be contributed on net...@vger.kernel.org soon. can you please split these into smaller

RE: [RFC 3/3] STE-plugin: Adding STE plugin

2010-01-18 Thread Marcel Holtmann
Hi Sjur, Thank you for your feedback. We hope to get new patch-set out tomorrow with most of your comments fixed. sounds great. It might make sense to have a local copy of the required structure and constants to allow an easier complication. Of course this depends on having CAIF at

Re: [RFC v2 0/7] STE-plugin: Second RFC on STE patch-set

2010-01-19 Thread Marcel Holtmann
Hi Sjur, This is the second RFC on the STE driver.Most review comments should be included, except for using glib for XML parsing and changes to voice-call termination. We'll have to get back to this later. we are getting to closer to something that can be merged as a first draft and then

Re: [RFC v2 3/7] STE-plugin: STE modem driver definition

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Updates after review: Removed overriding of functions. --- snip + +#ifdef HAVE_CONFIG_H +#include config.h +#endif + +#include glib.h +#include gatchat.h What are these two includes for? +#define OFONO_API_SUBJECT_TO_CHANGE +#include ofono/plugin.h +#include ofono/types.h

Re: [RFC v2 4/7] STE-plugin: Add STE plugin

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Added check on return value of socket() and connect() calls. Use gsm_permissive syntax all the time. Added ATE0 in initialization. snip +#ifdef HAVE_CONFIG_H +#include config.h +#endif + +#include errno.h +#include stdlib.h + +#include glib.h +#include gatchat.h +#include

Re: [RFC v2 5/7] STE-plugin: Voice-call driver.

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Updates after review: Use at_util_call_compare. So far, we have only done the trivial changes to voice call driver. We agree on moving more of the state logic to core, but this is complex and we need more time to discuss and look into this, particularly regarding call release.

Re: [RFC v2 6/7] STE-plugin: Add CAIF header files in gcaif.

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Adding CAIF header files. These should be removed when CAIF is included Linux kernel. please put them into drivers/stemodem/ instead as I explained in the other email. And make sure they are before its actual usage in the patch series. Regards Marcel

Re: [RFC v2 7/7] STE-plugin: GPRS driver.

2010-01-19 Thread Marcel Holtmann
Hi Sjur, Updates after review: Removed setting of IP-address, netmask etc. when creating the IP interface. Split caif_if_create_remove() into , caif_if_create() and caif_if_remove(). Declared interface as array in conn_info struct, and removed memory allocation. Removed switching of syntax

Re: [PATCH] Add HFP support through BlueZ

2010-01-27 Thread Marcel Holtmann
Hi Gustavo, It uses BlueZ through to get HFP working following the org.bluez.HandsfreeGateway and org.bluez.HandsfreeAgent from the BlueZ D-Bus API. You need the HFP suport into BlueZ and the new dbus 1.3 with fd-passing support. Many thanks to Zhenhua Zhang zhenhua.zh...@intel.com for

Re: [PATCH] Add STE voice call support.

2010-01-28 Thread Marcel Holtmann
Hi Sjur, --- Makefile.am |1 + drivers/stemodem/stemodem.c |2 + drivers/stemodem/stemodem.h |3 + drivers/stemodem/voicecall.c | 596 ++ plugins/ste.c|2 +- 5 files changed, 603 insertions(+), 1

Re: RFC: API for Neighbouring Cell Info

2010-01-31 Thread Marcel Holtmann
Hi Jussi, Honestly I don't like either approach, the Agent pattern would be a much better fit here. This would allow us to specify the polling/update interval and stop neighbor cell updates when no one is interested in them. In my experience, the positioning guys don't need

Re: [PATCH 2/2] Fix: Check if interface exists before creating it.

2010-02-01 Thread Marcel Holtmann
Hi Sjur, diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index c178fb6..79e697b 100644 --- a/drivers/stemodem/gprs-context.c +++ b/drivers/stemodem/gprs-context.c @@ -187,9 +187,11 @@ static gboolean caif_if_create(const char *interface, unsigned int connid)

Re: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-01 Thread Marcel Holtmann
Hi Sjur, diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index 6743aba..c178fb6 100644 --- a/drivers/stemodem/gprs-context.c +++ b/drivers/stemodem/gprs-context.c @@ -416,7 +416,7 @@ static void ste_gprs_activate_primary(struct ofono_gprs_context *gc, {

RE: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-01 Thread Marcel Holtmann
Hi Sjur, len = sprintf(buf, AT+CGDCONT=%u,\IP\, ctx-cid); if (ctx-apn) snprintf(buf + len, sizeof(buf) - len - 3, ,\%s\, ctx-apn); + /* Set username and password. Must be done after context creation */ + len = strlen(buf); + sprintf(buf+len,

RE: [PATCH 2/2] Fix: Check if interface exists before creating it.

2010-02-01 Thread Marcel Holtmann
Hi Sjur, diff --git a/drivers/stemodem/gprs-context.c b/drivers/stemodem/gprs-context.c index c178fb6..79e697b 100644 --- a/drivers/stemodem/gprs-context.c +++ b/drivers/stemodem/gprs-context.c @@ -187,9 +187,11 @@ static gboolean caif_if_create(const char *interface, unsigned int

Re: [PATCH 1/2] Fix: Username and Password must be set after context is created.

2010-02-01 Thread Marcel Holtmann
Hi Denis, And we might wanna check if MBM cards behave similar and ensure that STE and MBM cards use a similar code flow. When testing this EIAAUW fails if there are no prior PDP context on the modem. Most likely this is the case with the MBM module as well, but I have not

Re: [PATCH 1/3] Add radio settings atom and driver API

2010-02-04 Thread Marcel Holtmann
Hi Aki, +Properties string Mode [read-write] + + The current radio access selection mode, also known + as network preference. + + The possible values are: + dual Radio access selection is done +

Re: [PATCH 1/3] Add radio settings atom and driver API

2010-02-04 Thread Marcel Holtmann
Hi Aki, +Propertiesstring Mode [read-write] + +The current radio access selection mode, also known +as network preference. + +The possible values are: +dualRadio access selection is done +

Re: [PATCH 1/3] Add radio settings atom and driver API

2010-02-04 Thread Marcel Holtmann
Hi Aki, Yeah, perhaps the property should be called TechnologyPreference with values any, 2G, 3G, 4G. For now at least. so what about the magic CDMA + UMTS combo chips. We basically have to reload the firmware with these. Would be nice to figure out on how that can be done. Not

Re: [PATCH 1/1] install data file

2010-03-10 Thread Marcel Holtmann
Hi Martin, Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index fcee5e6..007d5b9 100644 --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,7 @@ INCLUDES = -I$(top_srcdir)/src -I$(top_builddir)/src CLEANFILES =

Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-11 Thread Marcel Holtmann
Hi Denis, +struct ppp_link * g_at_ppp_new(GIOChannel *modem); +void g_at_ppp_open(struct ppp_link *link); +void g_at_ppp_set_connect_function(struct ppp_link *link, + GAtPPPConnectFunc callback, gpointer user_data); +void g_at_ppp_set_disconnect_function(struct

Re: [patch 6/6] Allow gsmdial to use gatchat ppp support

2010-03-14 Thread Marcel Holtmann
Hi Kristen, Add option to use PPP to gsmdial. Index: ofono/gatchat/gsmdial.c === --- ofono.orig/gatchat/gsmdial.c 2010-03-10 16:58:09.773080389 -0800 +++ ofono/gatchat/gsmdial.c 2010-03-10 17:06:45.071975512 -0800 @@

Re: [PATCH] Add support of Huawei EM770 modem

2010-03-16 Thread Marcel Holtmann
Hi Yang, Comparing with general Huawei modem, EM770 is a full feature modem that supports voicecall, phonebook, call forwarding, call barring, etc. --- Makefile.am|3 + plugins/huawei-em770.c | 226 plugins/ofono.rules

Re: [PATCH] Add support of Huawei EM770 modem

2010-03-16 Thread Marcel Holtmann
Hi Yang, Comparing with general Huawei modem, EM770 is a full feature modem that supports voicecall, phonebook, call forwarding, call barring, etc. --- Makefile.am |3 + plugins/em770.c | 226 +++ plugins/ofono.rules |1

Re: [PATCH 3/4] Add parser for file list objects

2010-03-16 Thread Marcel Holtmann
Hi Yang, --- src/stkutil.c | 42 ++ src/stkutil.h |6 ++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index ceba2d5..9f3bc0b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -406,6

Re: [PATCH 4/4] Add parser for location information objects

2010-03-16 Thread Marcel Holtmann
Hi Yang, src/simutil.c |2 +- src/simutil.h |1 + src/stkutil.c | 40 +--- src/stkutil.h |9 + 4 files changed, 48 insertions(+), 4 deletions(-) diff --git a/src/simutil.c b/src/simutil.c index d9383b7..65ffa36 100644 ---

Re: [patch 5/6] IP support for PPP

2010-03-16 Thread Marcel Holtmann
Hi Kristen, +/** IPCP support / +enum { + /* supported codes */ + IPCP_SUPPORTED_CODES= (1 CONFIGURE_REQUEST) | + (1 CONFIGURE_ACK) | + (1 CONFIGURE_NAK) | + (1

Re: [PATCH 2/4] Handle the conversion failure when parsing item

2010-03-16 Thread Marcel Holtmann
Hi Denis, + if (utf8 == NULL) + return FALSE; + + item-text = utf8; Why bother with utf8 variable? Just do if (item-text == NULL) return FALSE; I actually find this acceptable because 'item' is a return structure, so we should avoid

Re: [patch 6/6] Allow gsmdial to use gatchat ppp support

2010-03-17 Thread Marcel Holtmann
Hi Kristen, static GAtChat *control; static GAtChat *modem; static GMainLoop *event_loop; +static GAtPPP *ppp; I hate myself for this nitpick, but please group GAtPPP *ppp with the others before the mainloop variable. +static void print_ip_address(guint32 ip_addr) +{ + struct

Re: [patch 3/6] LCP support

2010-03-17 Thread Marcel Holtmann
Hi Kristen, Makefile.am |6 - gatchat/gatppp.c | 53 + gatchat/gatppp_internal.h |8 + gatchat/gatppplcp.c | 244 ++ this should be gatchat/ppp_lcp.c +void __ppp_set_auth(GAtPPP *ppp, guint8*

Re: [patch 5/6] IP support for PPP

2010-03-18 Thread Marcel Holtmann
Hi Kristen, +static guint32 bytes_to_32(guint8 *bytes) +{ + union addr { + guint8 bytes[4]; + guint32 word; + } a; + + memcpy(a.bytes, bytes, 4); + return(ntohl(a.word)); +} This works, but is pretty ugly. Doesn't GLib has functions to

Re: [patch 1/6] Add PPP protocol support with HDLC framing

2010-03-20 Thread Marcel Holtmann
Hi Kristen, This patch implements the basic PPP protocol. LCP, NCP etc. are handled in a different patch. --- Makefile.am |4 gatchat/gatppp.c | 133 gatchat/gatppp.h | 59 +++ gatchat/ppp.c| 455

Re: [patch 6/6] Allow gsmdial to use gatchat ppp support

2010-03-20 Thread Marcel Holtmann
Hi Kristen, Add option to use PPP to gsmdial. --- gatchat/gsmdial.c | 90 -- 1 file changed, 87 insertions(+), 3 deletions(-) Index: ofono/gatchat/gsmdial.c === ---

Re: [PATCH 0/6] PPP Patches v3

2010-03-22 Thread Marcel Holtmann
Hi Kristen, Changes since v2 - corrected whitespace. all the patches have been applied. So form now on please send smaller patches as soon as you have them ready and tested. If you need comments or have questions, you can use the mailing list as well. some additional comments from my

Re: [PATCH 6/6] Add PPP option to gsmdial

2010-03-23 Thread Marcel Holtmann
Hi Gustavo, +static void connect_cb(gboolean ok, GAtResult *result, gpointer user_data) +{ + GIOChannel *channel; + + if (!ok) { + g_print(Unable to define context\n); + exit(1); I guess we should not call exit here. Just return. it is a test program. So

Re: [PATCH 0/6] PPP Patches v3

2010-03-23 Thread Marcel Holtmann
Hi Kristen, And there was another problem with one variable being guint16, but the is_option casts it back to guint8. We can't really have that. Once you start casting on that scale the compiler will not warn you about type mismatches or if the value of argument is too big for its type.

Re: [PATCH 0/6] PPP Patches v3

2010-03-23 Thread Marcel Holtmann
Hi Kristen, And there was another problem with one variable being guint16, but the is_option casts it back to guint8. We can't really have that. Once you start casting on that scale the compiler will not warn you about type mismatches or if the value of argument is too big for its

Re: [PATCH 0/3] fix memory leaks in PPP

2010-03-24 Thread Marcel Holtmann
Hi Kristen, Fix a few memory leaks in PPP Kristen Carlson Accardi (3): fix memory leaks in option handling fix memory leaks after ppp_transmit fix memory leak in ppp_auth gatchat/ppp_auth.c |1 + gatchat/ppp_cp.c | 51 +--

Issue with PPP auth and empty username/password

2010-03-24 Thread Marcel Holtmann
Hi Kristen, I started tested the PPP code and run into a simple crash when not providing username and password. This should be possible. Program terminated with signal 11, Segmentation fault. #0 0x003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6 (gdb) bt #0 0x003457e7f2f2 in

Quick report from PPP testing

2010-03-24 Thread Marcel Holtmann
Hi Kristen, so I just downloaded the Linux kernel via the PPP connection with my Rogers' Novatel UMTS stick. : \r\n+CGREG: 2,1,FE38,EBA6\r\n\r\nOK\r\n Registered to GPRS network, roaming=False : ATD*99***1#\r : \r\nCONNECT HSDPA 7.2\r\n oops -- found acked option 2 we didn't request Unknown

Re: [PATCH 0/4] add PPP_DEAD and PPP_TERMINATE support

2010-03-25 Thread Marcel Holtmann
Hi Kristen, These patches complete implementation of the PPP_DEAD and PPP_TERMINATE phases, as well as allow this to be tested via gsmdial. Kristen Carlson Accardi (4): remove unneeded debug statement add tracing for PPP terminate path separate memory cleanup from PPP shutdown

Re: [PATCH] ppp: change debug output to include control protocol prefix

2010-03-25 Thread Marcel Holtmann
Hi Kristen, gatchat/ppp_cp.c | 12 ++-- gatchat/ppp_cp.h | 10 +- gatchat/ppp_lcp.c | 12 ++-- gatchat/ppp_net.c | 12 ++-- 4 files changed, 35 insertions(+), 11 deletions(-) patch has been applied. Thanks. Regards Marcel

Re: Issue with PPP auth and empty username/password

2010-03-27 Thread Marcel Holtmann
Hi Kristen, I started tested the PPP code and run into a simple crash when not providing username and password. This should be possible. Program terminated with signal 11, Segmentation fault. #0 0x003457e7f2f2 in __strlen_sse2 () from /lib64/libc.so.6 (gdb) bt #0

Re: [PATCH 0/2] ppp authentication bug fixes (resend)

2010-03-27 Thread Marcel Holtmann
Hi Kristen, Here are a couple bug fixes for the PPP authentication. First patch fixes the seg fault when the secret is empty, as reported by marcel. Second, if we do fail to authenticate, we need to change ppp phases to terminate the link. Kristen Carlson Accardi (2): ppp: allow empty

Re: Access to SIM card when Modem is not Powered

2010-03-30 Thread Marcel Holtmann
Hi Pekka, I've been porting the N900 modem control code to oFono. The semantics of Powered is fine with respect of the atoms, in other words, if the modem crashes and boots itself, all the atoms are flushed nicely. When powering up, the Powered can be set to true when the modem is

Re: Access to SIM card when Modem is not Powered

2010-03-30 Thread Marcel Holtmann
Hi Pekka, That is also a problem. The other problem is that the party controlling the modem power state is supposed to keep GPIO lines in known position for a while after the modem has indicated it has been powered down. In an N900 running maemo, a daemon called sscd does that. sscd

PPP LCP configuration issue

2010-04-01 Thread Marcel Holtmann
Hi Kristen, so I added some debug code to actually print the options during the configuration stage. And something seems to be wrong here. lcp: pppcp_open_event: current state 0:INITIAL lcp: pppcp_up_event: current state 1:STARTING lcp: pppcp_initialize_restart_count: current state 1:STARTING

Re: PPP LCP configuration issue

2010-04-01 Thread Marcel Holtmann
Hi Kristen, so I added some debug code to actually print the options during the configuration stage. And something seems to be wrong here. lcp: pppcp_open_event: current state 0:INITIAL lcp: pppcp_up_event: current state 1:STARTING lcp: pppcp_initialize_restart_count: current state

Re: [PATCH] ppp: fix missing breaks in switchs

2010-04-02 Thread Marcel Holtmann
Hi Kristen, --- gatchat/ppp_cp.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) patch has been applied. Thanks. Regards Marcel ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono

Re: PPP LCP configuration issue

2010-04-02 Thread Marcel Holtmann
Hi Kristen, so I added some debug code to actually print the options during the configuration stage. And something seems to be wrong here. lcp: pppcp_open_event: current state 0:INITIAL lcp: pppcp_up_event: current state 1:STARTING lcp: pppcp_initialize_restart_count: current state

Re: [PATCH] Add support for Option iCON 451

2010-04-14 Thread Marcel Holtmann
Hi Daniel, * Daniel Wagner daniel.wag...@bmw-carit.de [2010-04-14 07:45:11 +0200]: Signed-off-by: Daniel Wagner daniel.wag...@bmw-carit.de We do not use the signed-off line in oFono. Ah, sorry about that . Didn't know that. Do you want me to resend the patch without signoff? I

Re: [PATCH] Fix Let data device be optional for mbm driver

2010-04-16 Thread Marcel Holtmann
Hi Zhenhua, Dell 5530 modem has no data device port. So data device should be optional in mbm drvier. can you please include the content of /proc/bus/usb/devices for this device and the sysfs descriptions for each TTY port. Regards Marcel ___

Re: [PATCH 1/3] hdlc: allow for scanning and escaping

2010-04-17 Thread Marcel Holtmann
Hi Kristen, PPP needs to inspect the packet protocol to see if a character should be escaped. Additionally, it needs to be able to compare against recv and xmit accm. can we just set the ACCM values instead of having an extra function call. I think that calling an extra function for every

  1   2   3   4   5   6   7   8   9   10   >