Re: [PATCH 2/5] stk: Support send ss response
Hi, On 18 October 2010 10:04, Gu, Yang yang...@intel.com wrote: I couldn't understand this comment well. Additional information is a part of result dataobj, so it's already included. Is there something I should handle further? It seems correct to me, the result dataobj is added just before the switch(). Best regards ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 2/5] stk: Support send ss response
Hi Andrew/Yang, On 10/18/2010 12:30 PM, andrzej zaborowski wrote: Hi, On 18 October 2010 10:04, Gu, Yang yang...@intel.com wrote: I couldn't understand this comment well. Additional information is a part of result dataobj, so it's already included. Is there something I should handle further? It seems correct to me, the result dataobj is added just before the switch(). Yes you guys are right, for some reason I thought additional info was a separate object. Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
Re: [PATCH 2/5] stk: Support send ss response
Hi Yang, On 09/21/2010 05:21 AM, Yang Gu wrote: --- src/stkutil.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/stkutil.c b/src/stkutil.c index cdd6b4e..d35094b 100644 --- a/src/stkutil.c +++ b/src/stkutil.c @@ -5449,6 +5449,8 @@ const unsigned char *stk_pdu_from_response(const struct stk_response *response, response-select_item.item_id, NULL); break; + case STK_COMMAND_TYPE_SEND_SS: + break; This seems wrong, isn't the additional information field mandatory? Regards, -Denis ___ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
