Re: [Ohrrpgce] I only just registered that Ralph is teeemcee.

2018-04-07 Thread Ralph Versteegen
:) I think it's because I have such a short nick that I'm one of the only OHR devs not referred to by first name. But who are *you*? Do you use a different name on SS/CP/IRC/Discord? On 8 April 2018 at 08:02, towerofnix wrote: > I've been following the subversion mailing

Re: [Ohrrpgce] SVN: james/10329 Mention built-in mouse support in whatsnew.txt

2018-04-07 Thread James Paige
Thanks, yes, I think I am done with the outside battle stuff. I hope to have time to do the battle mouse support next week. Thanks for letting me know you have your battle stuff merged. (Yay slices!) On Saturday, April 7, 2018, Ralph Versteegen wrote: > > > On 7 April 2018

[Ohrrpgce] I only just registered that Ralph is teeemcee.

2018-04-07 Thread towerofnix
I've been following the subversion mailing list for several months and only realized this now! I somehow thought there were three people working on OHRRPGCE - TMC, James, and Ralph - and that TMC just never sent emails (besides the subversion commit auto-emails). How silly of me! Anywho, the

Re: [Ohrrpgce] SVN: james/10329 Mention built-in mouse support in whatsnew.txt

2018-04-07 Thread Ralph Versteegen
On 7 April 2018 at 10:14, wrote: > james > 2018-04-06 15:14:00 -0700 (Fri, 06 Apr 2018) > 46 > Mention built-in mouse support in whatsnew.txt > --- > U wip/whatsnew.txt > OK, so now you've finished everything outside of battles? (Excluding an onscreen keyboard

[Ohrrpgce] SVN: teeemcee/10339 Convert BattleSprites to slices

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:57:38 -0700 (Fri, 06 Apr 2018) 598 Convert BattleSprites to slices Position, size, and frame members of a BattleSprite are now all properties which get/set attributes of its slices. Added Ctrl-F4 debug key to view/edit the slice tree. (Instant-run moved to Ctrl-F5) The

[Ohrrpgce] SVN: teeemcee/10342 Document Force Victory, Force Battle Exit, Never Trigger Elemental Count

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:58:05 -0700 (Fri, 06 Apr 2018) 128 Document Force Victory, Force Battle Exit, Never Trigger Elemental Counterattacks, and fix and improve non-elemental attack docs --- U wip/ohrhelp/attack_bitsets.txt U wip/ohrhelp/attack_element_bitsets.txt U

[Ohrrpgce] SVN: teeemcee/10343 Battle code cleanup: use bool for some members of TargettingState and At

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:58:12 -0700 (Fri, 06 Apr 2018) 81 Battle code cleanup: use bool for some members of TargettingState and AttackState --- U wip/battle_udts.bi U wip/bmod.rbas U wip/bmodsubs.bas ___ Ohrrpgce mailing list

[Ohrrpgce] SVN: teeemcee/10336 More battle code cleanup (mostly adding comments)

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:57:09 -0700 (Fri, 06 Apr 2018) 49 More battle code cleanup (mostly adding comments) --- U wip/allmodex.bas U wip/bmod.rbas ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org

[Ohrrpgce] SVN: teeemcee/10340 Add BattleSprite.deathtime(), .appeartime() to calc default death/appear

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:57:48 -0700 (Fri, 06 Apr 2018) 204 Add BattleSprite.deathtime(), .appeartime() to calc default death/appeartime dynamically instead of in loadfoe/changefoe This breaks an annoying dependency on the slice needing to be loaded for .w and .h --- U wip/battle_udts.bi U

[Ohrrpgce] SVN: teeemcee/10341 More simple battle code cleanup (mostly integer -> bool)

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:57:56 -0700 (Fri, 06 Apr 2018) 56 More simple battle code cleanup (mostly integer -> bool) --- U wip/bmod.rbas U wip/bmodsubs.bas U wip/bmodsubs.bi ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org

[Ohrrpgce] SVN: teeemcee/10338 Cleaning up enemy death rewards. Split out RewardsState.add_item and ene

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:57:28 -0700 (Fri, 06 Apr 2018) 163 Cleaning up enemy death rewards. Split out RewardsState.add_item and enemy_death_rewards Also fixed a crash (OOB array read) if more than 16 item types were found --- U wip/battle_udts.bi U wip/bmod.rbas

[Ohrrpgce] SVN: teeemcee/10337 Some cleanup of enemy death code

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:57:17 -0700 (Fri, 06 Apr 2018) 214 Some cleanup of enemy death code Split out enemy_death_sfx I added a couple checks to skip empty hero slots which have no effect on behaviour, such as not doing death processing for nonexistent heroes every tick. --- U wip/bmod.bi U

[Ohrrpgce] SVN: teeemcee/10335 Cleanup: BattleSprite.vis and tmask() are now bools

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:57:01 -0700 (Fri, 06 Apr 2018) 51 Cleanup: BattleSprite.vis and tmask() are now bools --- U wip/battle_udts.bi U wip/bmod.rbas U wip/bmodsubs.bas ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org

[Ohrrpgce] SVN: teeemcee/10333 Battle code cleanup: make more use of WITH and DIM BYREF

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:56:47 -0700 (Fri, 06 Apr 2018) 56 Battle code cleanup: make more use of WITH and DIM BYREF --- U wip/bmod.rbas U wip/bmodsubs.bas ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org

[Ohrrpgce] SVN: teeemcee/10334 Simplify loadfoe: I couldn't any reason for a separate "IF vis THEN" blo

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:56:53 -0700 (Fri, 06 Apr 2018) 306 Simplify loadfoe: I couldn't any reason for a separate "IF vis THEN" block It should be impossible for loadfoe to be called on a slot that is empty but has .vis = 1 set, so the extra IF was spurious Split up setup_non_volatile_enemy_state

[Ohrrpgce] SVN: teeemcee/10331 Add RealignSlice, CenterSlice convenience subs

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:56:29 -0700 (Fri, 06 Apr 2018) 46 Add RealignSlice, CenterSlice convenience subs --- U wip/slices.bas U wip/slices.bi ___ Ohrrpgce mailing list ohrrpgce@lists.motherhamster.org

[Ohrrpgce] SVN: teeemcee/10332 Add write_checkpoint calls from battle system, when attacking or player

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:56:39 -0700 (Fri, 06 Apr 2018) 231 Add write_checkpoint calls from battle system, when attacking or player confirms target The placement of these anim_checkpoint calls is totally unimportant and done without thought. I expect they will be removed or moved in future --- U

[Ohrrpgce] SVN: teeemcee/10330 Some remaining places where the SpriteType enum was not used

2018-04-07 Thread subversion
teeemcee 2018-04-06 23:56:21 -0700 (Fri, 06 Apr 2018) 60 Some remaining places where the SpriteType enum was not used --- U wip/attackedit.bas U wip/customsubs.rbas U wip/game.bas U wip/thingbrowser.bas U wip/thingbrowser.bi U wip/walkabouts.bas