Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

2014-01-27 Thread Saheb Preet Singh
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Jan. 27, 2014, 8:21 a.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

2014-01-27 Thread Saheb Preet Singh
On Jan. 24, 2014, 7:24 p.m., Albert Astals Cid wrote: I don't think there's any problem with resizing, i'd say it's only your math that is wrong int xOffset = pageViewSize.width() - pageSize.width(); int yOffset = pageViewSize.height() - pageSize.height(); resize( width()

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

2014-01-27 Thread Saheb Preet Singh
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/ --- (Updated Jan. 27, 2014, 8:24 a.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

2014-01-27 Thread Saheb Preet Singh
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/ --- (Updated Jan. 27, 2014, 9:41 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

2014-01-27 Thread Saheb Preet Singh
On Jan. 26, 2014, 4:42 p.m., Albert Astals Cid wrote: part.cpp, line 829 https://git.reviewboard.kde.org/r/115072/diff/2/?file=234778#file234778line829 What's this for? sorry i didn't noticed that - Saheb --- This is an

[Okular-devel] [okular] [Bug 330431] rus lang

2014-01-27 Thread BuxarNET
https://bugs.kde.org/show_bug.cgi?id=330431 --- Comment #4 from BuxarNET buxar...@gmail.com --- Created attachment 84857 -- https://bugs.kde.org/attachment.cgi?id=84857action=edit document I attach the document -- You are receiving this mail because: You are the assignee for the bug.

[Okular-devel] [okular] [Bug 330431] rus lang

2014-01-27 Thread BuxarNET
https://bugs.kde.org/show_bug.cgi?id=330431 --- Comment #3 from BuxarNET buxar...@gmail.com --- thanks, yes okular -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org

[Okular-devel] [okular] [Bug 330381] create/allow keyboard shortcut to close opened note (or last opened not or all open notes)

2014-01-27 Thread JTPrince
https://bugs.kde.org/show_bug.cgi?id=330381 JTPrince jtpri...@gmail.com changed: What|Removed |Added Status|NEEDSINFO |RESOLVED

[Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/ --- Review request for Okular. Bugs: 219121

[Okular-devel] [okular] [Bug 219121] if holding mouse mid button, perform scroll instead zoom

2014-01-27 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=219121 --- Comment #10 from Yichao Zhou broken.z...@gmail.com --- https://git.reviewboard.kde.org/r/115335/ -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list

[Okular-devel] [okular] [Bug 330431] rus lang

2014-01-27 Thread BuxarNET
https://bugs.kde.org/show_bug.cgi?id=330431 --- Comment #6 from BuxarNET buxar...@gmail.com --- yes, the problem is the same as in the ticker 283477 and 263042 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel

[Okular-devel] [okular] [Bug 283477] Missing language specific characters when filling in forms

2014-01-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=283477 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||buxar...@gmail.com ---

[Okular-devel] [okular] [Bug 330431] rus lang

2014-01-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=330431 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|NEEDSINFO |RESOLVED

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/#review48417 --- * In scroll mode, now okular can load new page correctly

Re: [Okular-devel] Review Request 115072: Implemented a play pause button in presentation mode of okular

2014-01-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115072/#review48419 --- ui/presentationwidget.cpp

Re: [Okular-devel] Review Request 115283: implemented a feature in okular to resize window to current page size.

2014-01-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115283/#review48420 --- part.cpp

[Okular-devel] [okular] [Bug 330431] rus lang

2014-01-27 Thread BuxarNET
https://bugs.kde.org/show_bug.cgi?id=330431 --- Comment #8 from BuxarNET buxar...@gmail.com --- since 2011 and the issue is not solved. :( -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list

[Okular-devel] [okular] [Bug 330431] rus lang

2014-01-27 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=330431 --- Comment #9 from Albert Astals Cid aa...@kde.org --- Sad indeed, the number of bugs and features people ask for is immense and we are just a couple of volunteers so we can't do everything. Of course you can always learn to code and fix it yourself or

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-27 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110914/#review48432 --- Can you confirm that diff --git a/part.rc b/part.rc index

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 2112 https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line2112 What's the change in this block? Yichao Zhou wrote: The indentation of that line is not correct. It just lets me

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: * In scroll mode, now okular can load new page correctly What does this mean? It means that the orignal patch in Bugs 219121 will not load new page due to the guard code in PageView::slotRequestVisiblePixmaps(). - Yichao

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: ui/pageview.h, line 221 https://git.reviewboard.kde.org/r/115335/diff/1/?file=240732#file240732line221 missing r in Scoll OK. But slotAutoScoll() is also missing a r. I have fixed that also. On Jan. 27, 2014, 9:42 p.m.,

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
On Jan. 27, 2014, 9:42 p.m., Albert Astals Cid wrote: ui/pageview.cpp, line 4485 https://git.reviewboard.kde.org/r/115335/diff/1/?file=240733#file240733line4485 Can you explain why the need for a timer? This is because, in scroll mode, user just moves their mouse a little bit and

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/ --- (Updated Jan. 28, 2014, 3:49 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 110914: Tabbed interface

2014-01-27 Thread Jonathan Doman
On Jan. 28, 2014, 12:01 a.m., Albert Astals Cid wrote: Can you confirm that diff --git a/part.rc b/part.rc index 6b1f44e..0b9cee5 100644 --- a/part.rc +++ b/part.rc @@ -84,7 +84,7 @@ Action name=show_leftpanel group=show_merge/ Action name=show_bottombar

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/ --- (Updated Jan. 28, 2014, 5:31 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/ --- (Updated Jan. 28, 2014, 5:44 a.m.) Review request for Okular. Changes

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/ --- (Updated Jan. 28, 2014, 5:55 a.m.) Review request for Okular. Changes

[Okular-devel] [okular] [Bug 119252] please add smooth scrolling

2014-01-27 Thread Yichao Zhou
https://bugs.kde.org/show_bug.cgi?id=119252 Yichao Zhou broken.z...@gmail.com changed: What|Removed |Added CC||broken.z...@gmail.com ---

Re: [Okular-devel] Review Request 115335: Add an option to use the middle click to scroll the screen

2014-01-27 Thread Yichao Zhou
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115335/ --- (Updated Jan. 28, 2014, 7:02 a.m.) Review request for Okular. Changes