Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-13 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/ --- (Updated Aug. 13, 2015, 7 a.m.) Review request for Okular, Albert Astals

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-13 Thread Tobias Koenig
On Aug. 12, 2015, 8:35 p.m., Albert Astals Cid wrote: generators/poppler/generator_pdf.cpp, line 221 https://git.reviewboard.kde.org/r/124612/diff/2/?file=393334#file393334line221 Dependeing on what we do on poppler-qt and poppler core on null configurations (create a default one

Re: [Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

2015-08-13 Thread Tobias Koenig
On Aug. 12, 2015, 9:43 p.m., Albert Astals Cid wrote: ui/data/drawingtools.xml, line 11 https://git.reviewboard.kde.org/r/124687/diff/3/?file=393675#file393675line11 How do we translate this? Honestly, I have no idea :( Do you have a suggestion? - Tobias

Re: [Okular-devel] Review Request 124651: Implement reading mode functionality.

2015-08-13 Thread Anton Ermolenko
On Авг. 11, 2015, 1:52 д.п., Albert Astals Cid wrote: Please update documentation. I haven't tried it, does it remember the state between restarts? Should it? I don't know. Currently, I didn't implement the remembering of the state of reading mode. If you think it should remember the

Re: [Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

2015-08-13 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124687/ --- (Updated Aug. 13, 2015, 7:18 a.m.) Review request for Okular, Albert

[Okular-devel] [okular] [Bug 351053] Okular Memory leak

2015-08-13 Thread Peter Tselios
https://bugs.kde.org/show_bug.cgi?id=351053 --- Comment #4 from Peter Tselios s91...@yahoo.gr --- (In reply to Peter Tselios from comment #3) Only on file open. Due to my job, I need to keep Okular for a lot of time, some times days. The settings are the defaults. Also, it's indepedent from

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-13 Thread Tobias Koenig
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/ --- (Updated Aug. 13, 2015, 2:18 p.m.) Review request for Okular, Albert

Re: [Okular-devel] Review Request 124612: WIP: Add basic support for RichMedia annotations in PDF files

2015-08-13 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124612/#review83790 --- Why marked as WIP? What are you planning to improve? -

Re: [Okular-devel] Review Request 124687: Implement drawing quick selection tool for presentation mode

2015-08-13 Thread Albert Astals Cid
On ago. 12, 2015, 9:43 p.m., Albert Astals Cid wrote: ui/data/drawingtools.xml, line 11 https://git.reviewboard.kde.org/r/124687/diff/3/?file=393675#file393675line11 How do we translate this? Tobias Koenig wrote: Honestly, I have no idea :( Do you have a suggestion? Add a

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-13 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 13, 2015, 11:36 p.m.) Review request for Okular and Albert

Re: [Okular-devel] Review Request 124723: Interact with hyperlinks in TextSelect mode

2015-08-13 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124723/ --- (Updated Aug. 13, 2015, 11:08 p.m.) Review request for Okular and Albert

[Okular-devel] Review Request 124731: fix kimageio generator with Qt 5.4.0 and 5.4.1

2015-08-13 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124731/ --- Review request for Okular. Repository: okular Description --- Two

Re: [Okular-devel] Review Request 124716: Create View/Trim View submenu to hold Trim Margins and add Trim To Selection

2015-08-13 Thread Jake Linder
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124716/ --- (Updated Aug. 13, 2015, 3:58 p.m.) Review request for Okular and Albert