> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote: > > Is this something that one would expect to set manually? Shouldn't it be > > detected from the file contents? Or that's just too hard/not optimal?
Sorry for late reply. I didn't get notified when you wrote your comment. It is weired from reviewboard. However, setting this option manually is better because most of times you want to read pdfs in RTL & LTR lanagues so you don't want to be forced in RTL mode when you read LTR pdf. - Fahad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125397/#review92546 ----------------------------------------------------------- On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125397/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 4:05 p.m.) > > > Review request for Okular. > > > Bugs: 325650 > http://bugs.kde.org/show_bug.cgi?id=325650 > > > Repository: okular > > > Description > ------- > > This is my first patch to okular, so I am newbie here. This patch adds RTL > reading mode to okular in following view modes: > - facing pages. > - facing ( center first page). > - Overview. > > As well as adds “Right to left reading direction “ option to okular's > settings. > > > Diffs > ----- > > conf/dlggeneral.cpp ad389f3 > conf/dlggeneralbase.ui 03d5d5d > conf/okular.kcfg 76d7c37 > conf/preferencesdialog.h dcea37e > interfaces/viewerinterface.h 4f27921 > ui/pageview.cpp 6bff6ac > > Diff: https://git.reviewboard.kde.org/r/125397/diff/ > > > Testing > ------- > > I have tested in pdf & ODF files and it works fine. > > > Thanks, > > Fahad Al-Saidi > >
_______________________________________________ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel