Re: Review Request 128858: [frameworks] Hide cursor when tablet pen leaves proximity of the screen

2016-10-06 Thread Albert Astals Cid
> On Oct. 4, 2016, 9:21 p.m., Albert Astals Cid wrote: > > > I had to add code to the mouseMoveEvent class, to make the arrow cursor > > > appear when the mouse is moved. > > > Otherwise, after a TabletLeaveProximity event causes the cursor to > > > disappear, moving the mouse will > > > ot

Re: Review Request 129099: Make m_drawingEngine a std::unique_ptr

2016-10-06 Thread Albert Astals Cid
> On Oct. 4, 2016, 9 p.m., Albert Astals Cid wrote: > > I honestly don't see the benefit > > > > You changed a delete by a reset, is there any benefit at all other than > > making the code harder to read? > > Oliver Sander wrote: > I see three benefits: > a) I can see by looking at

[okular] [Bug 370217] New: [frameworks] Line width of freehand annotation is resolution dependent

2016-10-06 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370217 Bug ID: 370217 Summary: [frameworks] Line width of freehand annotation is resolution dependent Product: okular Version: unspecified Platform: Compiled Sources OS:

[okular] [Bug 363768] Font size is changed when form value is modified

2016-10-06 Thread Carl-Daniel Hailfinger via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363768 Carl-Daniel Hailfinger changed: What|Removed |Added CC|