D8051: Enable custom background color to be enabled and changed from settings

albertfreeman edited the summary of this revision. albertfreeman edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular Cc: ngraham, aacid

D8051: Enable custom background color to be enabled and changed from settings

ngraham added a comment. Nice! Can you add some details of your testing to the Test Plan section? A screenshot of the new functionality is always very much appreciated. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular Cc: ngraham,

D8051: Enable custom background color to be enabled and changed from settings

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular Cc: aacid

[okular] [Bug 182994] Allow user to change background colour

https://bugs.kde.org/show_bug.cgi?id=182994 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever

[okular] [Bug 369627] [Frameworks] unexpected background color

https://bugs.kde.org/show_bug.cgi?id=369627 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com ---

[okular] [Bug 182994] Allow user to change background colour

https://bugs.kde.org/show_bug.cgi?id=182994 Nate Graham changed: What|Removed |Added CC||f.glo...@ymail.com ---

[okular] [Bug 182994] Allow user to change background colour

https://bugs.kde.org/show_bug.cgi?id=182994 Nate Graham changed: What|Removed |Added CC||lucienl...@yahoo.fr ---

[okular] [Bug 307116] Background color change

https://bugs.kde.org/show_bug.cgi?id=307116 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE

[okular] [Bug 319736] Feature request : Provide the ability to customize the APPLICATION (not the document) background color on fullscreen/normal mode.

https://bugs.kde.org/show_bug.cgi?id=319736 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE

[okular] [Bug 182994] Allow user to change background colour

https://bugs.kde.org/show_bug.cgi?id=182994 Nate Graham changed: What|Removed |Added CC||ras...@gmail.com ---

[okular] [Bug 372055] Add option to change the background color

https://bugs.kde.org/show_bug.cgi?id=372055 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[okular] [Bug 335033] [Forms][Checkbox] Printing shows a 4 instead of a checkmark

https://bugs.kde.org/show_bug.cgi?id=335033 Nate Graham changed: What|Removed |Added CC||jimmy...@gmail.com ---

[okular] [Bug 376300] okular doesn't print the form characters correctly

https://bugs.kde.org/show_bug.cgi?id=376300 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE

[okular] [Bug 335033] [Forms][Checkbox] Printing shows a 4 instead of a checkmark

https://bugs.kde.org/show_bug.cgi?id=335033 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com --

[okular] [Bug 263631] European Union e-Forms don't work

https://bugs.kde.org/show_bug.cgi?id=263631 Nate Graham changed: What|Removed |Added Resolution|--- |UPSTREAM

[okular] [Bug 263042] XFA Forms are not supported

https://bugs.kde.org/show_bug.cgi?id=263042 Nate Graham changed: What|Removed |Added Status|CONFIRMED |RESOLVED

D8051: Enable custom background color to be enabled and changed from settings

albertfreeman edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 To: albertfreeman, #okular Cc: aacid

[okular] [Bug 370381] Custom stamp has default square dimensions regardless of original graphic

https://bugs.kde.org/show_bug.cgi?id=370381 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[okular] [Bug 367671] "Open in File Manager" in Open Dialog doesn't work

https://bugs.kde.org/show_bug.cgi?id=367671 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

D8051: Enable custom background color to be enabled and changed from settings

albertfreeman created this revision. albertfreeman added a reviewer: Okular. Restricted Application added a project: Okular. REVISION SUMMARY https://git.reviewboard.kde.org/r/130219/ REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D8051 AFFECTED FILES CMakeLists.txt

[okular] [Bug 383589] Annotation toolbar icons are blurry on a Hidpi screen

https://bugs.kde.org/show_bug.cgi?id=383589 --- Comment #3 from Nate Graham --- Does this patch improve things? https://phabricator.kde.org/D6268 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 380330] Bookmarks disconnected after path change

https://bugs.kde.org/show_bug.cgi?id=380330 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com --

[okular] [Bug 370967] Highlight and Underline do not work

https://bugs.kde.org/show_bug.cgi?id=370967 Nate Graham changed: What|Removed |Added Resolution|--- |WAITINGFORINFO

[okular] [Bug 370726] Text selection tool highlight unintelligible

https://bugs.kde.org/show_bug.cgi?id=370726 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[okular] [Bug 385152] Text is not highlighted when searching AND custom colors are set for screen output

https://bugs.kde.org/show_bug.cgi?id=385152 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[okular] [Bug 385015] Okular does not show XMP metadata for PDFs

https://bugs.kde.org/show_bug.cgi?id=385015 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com --

D7874: Show tooltip for annotations without handle too

ngraham edited the summary of this revision. REPOSITORY R223 Okular BRANCH Applications/17.08 REVISION DETAIL https://phabricator.kde.org/D7874 To: aacid, rkflx Cc: rkflx, tobiasdeiminger, #okular, aacid

[okular] [Bug 368758] Printing with grayscale option do not work

https://bugs.kde.org/show_bug.cgi?id=368758 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com --

[okular] [Bug 348172] Scaling options missing in print dialog

https://bugs.kde.org/show_bug.cgi?id=348172 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com --

D7949: Allow to print pdf doc directly into a QPrinter

ngraham added a comment. Yes, your work here is much appreciated. Since this fixes grayscale printing, can you mark it with "BUG: 368758"? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7949 To: sander, #okular Cc: rkflx, michaelweghorn, ngraham, aacid

[okular] [Bug 369115] Printing pages from pdfs sometimes gives low res results (and greyscale printing option ignored)

https://bugs.kde.org/show_bug.cgi?id=369115 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[okular] [Bug 368758] Printing with grayscale option do not work

https://bugs.kde.org/show_bug.cgi?id=368758 Nate Graham changed: What|Removed |Added CC||dav1dblunk...@hotmail.com

[okular] [Bug 330820] Scaling to fit print margins incorrectly scales cropped page

https://bugs.kde.org/show_bug.cgi?id=330820 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[okular] [Bug 348172] Scaling options missing in print dialog

https://bugs.kde.org/show_bug.cgi?id=348172 Nate Graham changed: What|Removed |Added CC||molle...@yahoo.com ---

D7962: Implement several new print scaling options

ngraham added a comment. Does this resolve https://bugs.kde.org/show_bug.cgi?id=348172, or does it only implement preliminary support for these new options? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7962 To: sander, #okular Cc: rkflx, michaelweghorn, ngraham,

[okular] [Bug 375566] Okular scale document when printing

https://bugs.kde.org/show_bug.cgi?id=375566 Nate Graham changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[okular] [Bug 348172] Scaling options missing in print dialog

https://bugs.kde.org/show_bug.cgi?id=348172 Nate Graham changed: What|Removed |Added CC||fabrice.salva...@orange.fr

D7962: Implement several new print scaling options

rkflx added a comment. > Summary I'm not able to test real printing at the moment. Could you add a "Test Plan" to show what simulated/real testing you did on your side, at least? > Scale mode: fit-to-page vs. shrink-to-page vs. none > Scale to: printable area vs. full page

D7949: Allow to print pdf doc directly into a QPrinter

rkflx added a comment. Great work, Oliver. If you want to spend your time on Arthur and make users happy that way, I'm all for it. Idea: Add a task (or multiple tasks) to the Okular workboard to track all printing and/or Arthur related work (otherwise it's difficult for reviewers to

Re: Review Request 130235: Allow to select Splash or Arthur render backends

> On Aug. 31, 2017, 9:07 p.m., Albert Astals Cid wrote: > > > How do I make it go into effect when 'Ok' is clicked? I suppose there's > > > some signal that gets emitted, but what's its name? > > > > Yeah, that's not happening, also needed for > > https://bugs.kde.org/show_bug.cgi?id=384070

Re: Review Request 130219: Enable background color to be changed from settings

Hi all, (Sorry for the noise, seems like Reviewboard does not let me comment anymore?) > https://git.reviewboard.kde.org/r/130219/ @albertfreeman: Thanks for providing a patch instead of just complaining on Bugzilla. As Reviewboard will become readonly in the near future, I would encourage

Re: Review Request 130219: Enable background color to be changed from settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/#review103747 --- - Henrik Fehlauer On Sept. 17, 2017, 1:05 p.m., Albert

Re: Review Request 130219: Enable background color to be changed from settings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130219/#review103745 --- - Henrik Fehlauer On Sept. 17, 2017, 1:05 p.m., Albert

D6268: HiDPI Support for Okular

davidedmundson accepted this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D6268 To: hetzenecker, davidedmundson, aacid Cc: gladhorn, ngraham, rkflx, sander, anthonyfieroni, #okular, aacid

[okular] [Bug 384381] Cursor over X to close note should be an arrow

https://bugs.kde.org/show_bug.cgi?id=384381 Christoph Feck changed: What|Removed |Added Keywords||junior-jobs --- Comment #3

D8007: popplerextractor: don't try to guess the title if there isn't one.

ngraham added reviewers: Frameworks, Okular. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007 To: flameeyes, #frameworks, #okular Cc: #frameworks