D12672: Use a target in FindDiscount (modern cmake) rather than variables

2018-05-07 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. It's actually fixing the build when discount is in its own prefix. Also I agree that it's better using targets. REPOSITORY R223 Okular BRANCH Applications/18.04 REVISION DETAIL

D12672: Use a target in FindDiscount (modern cmake) rather than variables

2018-05-07 Thread Albert Astals Cid
aacid added a comment. If noone disagrees i guess you can commit this in one week or so, i don't really have enough knowledge to discuss if this is better or worse. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12672 To: svuorela, kde-buildsystem Cc: aacid,

[okular] [Bug 393972] New: Okular Does not print PDF 1:1 scale

2018-05-07 Thread Ted Becker
https://bugs.kde.org/show_bug.cgi?id=393972 Bug ID: 393972 Summary: Okular Does not print PDF 1:1 scale Product: okular Version: 1.3.3 Platform: Kubuntu Packages OS: Linux Status: UNCONFIRMED Severity:

Re: Queries regarding terminologies used in Okular PDF annotation rendering

2018-05-07 Thread Tobias Deiminger
Hi Dileep, Am 07.05.2018 13:30 schrieb Dileep Sankhla: Hi there, Please try to answer my following queries: 1. What is "viewport"? the viewport is a child widget of the PageView widget and contains the visible part of the content area. Look at okular_ui_areas.png [0] which should make it

Queries regarding terminologies used in Okular PDF annotation rendering

2018-05-07 Thread Dileep Sankhla
Hi there, Please try to answer my following queries: 1. What is "viewport"? 2. What is "pageview"? 3. How does PDF save an annotation in the document? 4. What is "generator" and how does generator render the annotation in PDF page? What is the meaning of "rendering" here? 5. Now how does