[okular] [Bug 398606] Okular 'Help > What's this' doesn't work on toolbar items

2018-10-08 Thread Kishore Gopalakrishnan
https://bugs.kde.org/show_bug.cgi?id=398606 --- Comment #3 from Kishore Gopalakrishnan --- Oh. I didn't realise it was intentional. Perhaps the 'what's this' menu item should be removed, then, if the application has no help text for any of the buttons? -- You are receiving this mail because:

[okular] [Bug 399488] Move page bar to main toolbar by default

2018-10-08 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=399488 --- Comment #6 from Oliver Sander --- I know, that's why I never filed this myself. -- You are receiving this mail because: You are the assignee for the bug.

D7962: Implement several new print scaling options

2018-10-08 Thread Oliver Sander
sander added a comment. ScaleMode: - None: Do not apply scaling at all - FitToPage: Scale the page to be printed such that it fits the target area as good as possible, without changing the aspect ratio - ShrinkToPage: Like FitToPage, but only scale down. ScaleTo: What is the

[okular] [Bug 398334] Okular crashes while un/re highlighting PDF file

2018-10-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=398334 Albert Astals Cid changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|---

[okular] [Bug 398606] Okular 'Help > What's this' doesn't work on toolbar items

2018-10-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=398606 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org Severity|normal

D15691: Add unarchiver support for cbr files

2018-10-08 Thread Albert Astals Cid
aacid added a comment. I'm not thrilled about all these dynamic_cast< UnarFlavour * > in the ifs. Do you think you could fine a way to extend UnrarFlavour with a few virtuals so instead of ifs you would call functions in the helper that would do the work? i.e. something like

D7962: Implement several new print scaling options

2018-10-08 Thread Nathaniel Graham
ngraham added a comment. I'm afraid I cannot agree that this should be fixed with documentation. Users don't read documentation. And they shouldn't have to read documentation to access basic features like print output scaling. The interface needs to hide unnecessary implementation details

D14820: Select current format on the configure backend dialog

2018-10-08 Thread Albert Astals Cid
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:a482c56ba240: Select current format on the configure backend dialog (authored by aacid). CHANGED PRIOR TO COMMIT

[okular] [Bug 399488] Move page bar to main toolbar by default

2018-10-08 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=399488 --- Comment #5 from Christoph Feck --- You can only add menu items to the menu bar, no widgets. It's a Qt limitation. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 399488] Move page bar to main toolbar by default

2018-10-08 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=399488 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #4

D15580: New annotation toolbar

2018-10-08 Thread Nathaniel Graham
ngraham added a comment. > **To test this revision** > Temporary move the file .config/okularpartrc or the annotation tools may not match the ones in the buttons. This won't be a necessity for the final version, right? We wouldn't want users to have to do this. REPOSITORY R223

[okular] [Bug 399488] Move page bar to main toolbar by default

2018-10-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399488 --- Comment #3 from Nate Graham --- I think the argument for saving vertical space makes sense, and from a design standpoint, it does feel a bit odd and wasteful to have a status bar on the bottom of the content area that's 75+% empty. -- You are

[okular] [Bug 399488] Move page bar to main toolbar by default

2018-10-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=399488 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org --- Comment #2 from Albert

D7962: Implement several new print scaling options

2018-10-08 Thread Oliver Sander
sander added a comment. > Is there a good UI reason to force users to manually click "force rasterization", or is it just technical difficulty? My current approach is the most simple one; I am not a fan of buttons etc that change their value depending on other buttons (other than

[okular] [Bug 399488] Move page bar to main toolbar by default

2018-10-08 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=399488 Nate Graham changed: What|Removed |Added Keywords||usability CC|

D16048: Resize the preferences dialogue to avoid horizontal scrolling

2018-10-08 Thread Nathaniel Graham
ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16048 To: kadabash, aacid, #okular Cc: ngraham, okular-devel, aacid

D16048: Resize the preferences dialogue to avoid horizontal scrolling

2018-10-08 Thread Nathaniel Graham
ngraham added a reviewer: Okular. ngraham added a comment. @aacid is correct. If the size is not being set correctly, we should look at the dialog's sizeHint rather than overriding it entirely. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16048 To: kadabash,

D16048: Resize the preferences dialogue to avoid horizontal scrolling

2018-10-08 Thread Albert Astals Cid
aacid added a comment. 629 is a random number, random numbers are bad. What about people using other styles? other fonts? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16048 To: kadabash, aacid Cc: okular-devel, ngraham, aacid

D16048: Resize the preferences dialogue to avoid horizontal scrolling

2018-10-08 Thread Nicolas Fella
nicolasfella added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D16048 To: kadabash, aacid Cc: okular-devel, ngraham, aacid

D16048: Resize the preferences dialogue to avoid horizontal scrolling

2018-10-08 Thread Tim __
kadabash added a comment. Screenshot before change: F6312493: okular_configure_pre_patch.png Screenshot after change F6312494: okular_configure_post_patch.png REPOSITORY R223 Okular REVISION DETAIL

D16048: Resize the preferences dialogue to avoid horizontal scrolling

2018-10-08 Thread Tim __
kadabash created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. kadabash requested review of this revision. REVISION SUMMARY Scrolling horizontally for a small bit of the page feels awkward. BUG: 373957 REPOSITORY R223 Okular BRANCH

[okular] [Bug 399360] Okular CHM cannot open any chm file and input chinese

2018-10-08 Thread Yuri Chornoivan
https://bugs.kde.org/show_bug.cgi?id=399360 --- Comment #7 from Yuri Chornoivan --- (In reply to Evel from comment #6) > My QT seems too new, it require now newer than QT5.6 but I upgrade to newest > QT5.11 so I even cannot build from source code on the kchmviewer. Just tested on the newest Qt

D15580: New annotation toolbar

2018-10-08 Thread Simone Gaiarin
simgunz edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular Cc: ngraham, tobiasdeiminger, okular-devel, aacid