D18399: Fix launching Okular by opening a document from the file browser

vkrause created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. vkrause requested review of this revision. REVISION SUMMARY There's two issues here: - Activity::onCreate triggered before the C++ side was loaded, so the call to C++ failed (causing a

D18398: Fix a few more QML runtime errors/warnings

vkrause created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. vkrause requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18398 AFFECTED FILES

D18397: Fix crash on canceling the file open dialog

nicolasfella added a comment. I think the "proper" thing to do would be to check whether the resultCode is Activity.RESULT_OK or Activity.RESULT_CANCELED REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18397 To: vkrause Cc: nicolasfella, okular-devel, tfella,

D18397: Fix crash on canceling the file open dialog

vkrause created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. vkrause requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18397 AFFECTED FILES

D18396: Fix ToC icon, and remove unnecessary dependency on KDeclarative

aacid added a subscriber: mart. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18396 To: vkrause Cc: mart, okular-devel, tfella, ngraham, darcyshen, aacid

D18396: Fix ToC icon, and remove unnecessary dependency on KDeclarative

vkrause created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. vkrause requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18396 AFFECTED FILES

D18238: Implements a new button on findbar that allows users to choose the color that highlights the text

davidhurka added a comment. In D18238#394075 , @ngraham wrote: > I'm not really sold either. No other app has this setting. It seems like one of the major reasons why we have a color scheme and color chooser system is precisely so individual

D13114: Add DocumentRevision to Okular

chinmoyr abandoned this revision. chinmoyr added a comment. @aacid Sorry for late reply. This got lost in my inbox. This diff is not required. The relevant code for generating revision is already in poppler_generator. REPOSITORY R223 Okular REVISION DETAIL