[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

2019-02-02 Thread happy
https://bugs.kde.org/show_bug.cgi?id=403848 --- Comment #4 from happy --- > This is what I would have expected and what I'd consider to be the "correct" > behaviour. Can you describe what should be different in your eyes? Thank you for trying that, I didn't try markup. See my reply to Yuri

[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

2019-02-02 Thread happy
https://bugs.kde.org/show_bug.cgi?id=403848 --- Comment #3 from happy --- (In reply to Yuri Chornoivan from comment #1) > This warning can be useful because sometimes you can unintentionally close > the window trying to close the current document only. Yes, I totally agree, I do that all the

D18399: Fix launching Okular by opening a document from the file browser

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18399 To: vkrause, aacid Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision. REPOSITORY R223 Okular BRANCH arcpatch-D18397 REVISION DETAIL https://phabricator.kde.org/D18397 To: vkrause, apol, nicolasfella, aacid Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18398: Fix a few more QML runtime errors/warnings

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18398 To: vkrause, aacid Cc: okular-devel, tfella, ngraham, darcyshen, aacid

D18396: Fix ToC icon, and remove unnecessary dependency on KDeclarative

2019-02-02 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D18396 To: vkrause, aacid Cc: mart, okular-devel, tfella, ngraham, darcyshen, aacid

[okular] [Bug 403848] Redundant warning on close for unmodified documents in multiple tabs view

2019-02-02 Thread Michael Weghorn
https://bugs.kde.org/show_bug.cgi?id=403848 Michael Weghorn changed: What|Removed |Added CC||m.wegh...@posteo.de --- Comment #2 from