D11250: Expose presentation via MPRIS to rich remote controllers

2019-02-21 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Herald added a subscriber: okular-devel. No personal need anymore, and seemingly no-one else interested, thus discarding. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11250 To: kossebau, #okular Cc: okula

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. All right, let's do this. In final testing, I just found some blockers: - If the current mouseMode is not `TextSelect`, then the menu item is enabled but does nothing. It sh

[okular] [Bug 404526] Okular fails with Bogus memory allocation size

2019-02-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404526 --- Comment #11 from kwanza.p...@virginmedia.com --- OK thanks. Setting the environments variables does not sort things. In fact, most of them were already set correctly. This leaves me even more convinced that it is an issue of the interaction of okula

D19183: Use logically correct icon for direction arrows

2019-02-21 Thread Albert Astals Cid
aacid added a comment. In D19183#416866 , @ngraham wrote: > In D19183#416862 , @aacid wrote: > > > Personally i don't like it given than it is a very horizontal layout. > > > > To me, the mental i

D19183: Use logically correct icon for direction arrows

2019-02-21 Thread Nathaniel Graham
ngraham added a comment. In D19183#416862 , @aacid wrote: > Personally i don't like it given than it is a very horizontal layout. > > To me, the mental image here is page turning. If the document view on the screen were also doing page

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Albert Astals Cid
aacid added a comment. In D18744#416853 , @shubham wrote: > @aacid ping? Personally i'm happy with a menu option, "no one" will see it, but that's the point, it's an option that "no one" needs. And for the people that need it, they'l

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Albert Astals Cid
aacid added a comment. In D18744#413870 , @ngraham wrote: > Double-click in the margins can't be used for this since there would be too many accidental activations. > > Here's my proposal > > - Double-click in the margins: select whole li

D19183: Use logically correct icon for direction arrows

2019-02-21 Thread Albert Astals Cid
aacid added a comment. Personally i don't like it given than it is a very horizontal layout. To mhe mental image here is page turning. But Adobe reader has ↑↓ buttons, so what do i know REPOSITORY R223 Okular BRANCH icon REVISION DETAIL https://phabricator.kde.org/D19183 To:

D18744: Add action in Edit menu to select the text on current page

2019-02-21 Thread Shubham
shubham added a comment. @aacid ping? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D18744 To: shubham, aacid, #vdg Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid

[okular] [Bug 404526] Okular fails with Bogus memory allocation size

2019-02-21 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=404526 --- Comment #10 from Christoph Feck --- Regarding environment variables, please see https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source#Set_up_the_runtime_environment Okular works with poppler 0.72 on my system (openSUSE Krypton). -- Yo

[okular] [Bug 404526] Okular fails with Bogus memory allocation size

2019-02-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404526 --- Comment #9 from kwanza.p...@virginmedia.com --- Looking back at a similar bug 10 years ago, I am tempted to suggest that the problem is due to the incomparability of this version of okular with the newer versions of poppler. I suspect the problems be

[okular] [Bug 404526] Okular fails with Bogus memory allocation size

2019-02-21 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=404526 --- Comment #8 from kwanza.p...@virginmedia.com --- As I mentioned previously, I compile the packages because I install them in a available (non-standard) partition. What environment variable does okular need, please? or could someone point me to the par

D19183: Use logically correct icon for direction arrows

2019-02-21 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R223 Okular BRANCH icon REVISION DETAIL https://phabricator.kde.org/D19183 To: shubham, #vdg, ngraham, #okular Cc: abetts, davidhurka, ngraham, okular-devel, tfella, darcyshen, aacid

D19183: Use logically correct icon for direction arrows

2019-02-21 Thread David Hurka
davidhurka added a comment. Up and down arrows are equivalent to arrow key behavior, both in the view area and the PageNumberEdit. It also fits better to documents with RTL page layout (mangas) (if there are such documents). It’s just irritating next to the PageNumberEdit, where “Up” doe