D19717: Search function fails to find phrases split over two lines

joaonetto updated this revision to Diff 54906. joaonetto added a comment. Doesn't find anything no matter what direction. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19717?vs=54905=54906 BRANCH arcpatch-D19717 REVISION DETAIL

D19717: Search function fails to find phrases split over two lines

joaonetto updated this revision to Diff 54905. joaonetto marked 2 inline comments as done. joaonetto added a comment. - Well, now it proves it doesn't find anything, is this sufficient? REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19717?vs=53766=54905

D19717: Search function fails to find phrases split over two lines

aacid added a comment. In D19717#439091 , @joaonetto wrote: > Are you okay with the method? I don't know much about the searching code, that's why i want nice tests that prove the new code works :) REPOSITORY R223 Okular REVISION

D18658: Modify search bar in the contextDrawer

aacid resigned from this revision. aacid added a comment. I haven't tried this, but if Nathan has, i guess that's good enough. the sick brain inside me says that placeholderText: documentItem && documentItem.supportsSearching ? could be shortened to placeholderText:

D19717: Search function fails to find phrases split over two lines

joaonetto added a comment. Are you okay with the method? I'll take a deeper look at the tests ASAP. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19717 To: joaonetto, #okular Cc: aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D19717: Search function fails to find phrases split over two lines

aacid added a comment. I'm not very convinced with the tests. You have \n but the rects are all one after the other, so the algorithm that does the line partition doesn't really see a line there, you should have them in different row rects so that they are actually different physical

D19539: Replace some iterator loops by range-based for

This revision was automatically updated to reflect the committed changes. Closed by commit R223:f34ebf659f6c: Replace some iterator loops by range-based for (authored by sander, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19539?vs=53942=54900#toc REPOSITORY

D19539: Replace some iterator loops by range-based for

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19539 To: sander, #okular, aacid Cc: aacid, davidhurka, okular-devel, joaonetto, tfella, ngraham, darcyshen

D19539: Replace some iterator loops by range-based for

aacid added a comment. In D19539#431446 , @sander wrote: > Removed those four `aAsConst` again. > > I have been shying away from `arc` because I didn't want to learn yet another tool just for those few Okular patches that I submit. But if

[okular] [Bug 405709] [Feature request] Printing to PDF - remember last used location

https://bugs.kde.org/show_bug.cgi?id=405709 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail

D19702: Page changes triggered by mouse clicks should all happen on button release

This revision was automatically updated to reflect the committed changes. Closed by commit R223:4094745e7ea6: Page changes triggered by mouse clicks should all happen on button release (authored by sander, committed by aacid). CHANGED PRIOR TO COMMIT

Re: Okular on Windows again?

El dilluns, 25 de març de 2019, a les 11:27:24 CET, Oliver Sander va escriure: > >> a) Place a link on the Okular download page to those nightly builds, > >> marking it clearly as "Experimental, may eat your $whatever". > >> > >> b) Do actual windows releases as described under > >> > >>

Re: Editing features

El dimarts, 26 de març de 2019, a les 10:17:48 CET, Oliver Sander va escriure: > Dear Okular developers, > > at my day job I get asked about certain (pdf) editing features in Okular. > Specifically, people would like to be able to delete and reorder pages, > merge two documents, etc. > > In the

D19702: Page changes triggered by mouse clicks should all happen on button release

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. The comment still neds updating, but i'll fix it myself when i land it REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D19702 To: sander, #okular, ngraham, aacid Cc:

[okular] [Bug 368598] Zoom Out does not work when zoom is set to Fit Page or Fit Width and "Trim margins" is enabled

https://bugs.kde.org/show_bug.cgi?id=368598 --- Comment #11 from Patrick Silva --- duplicate of bug 342003 ? -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 405396] I'm unable to see the page number coulmn in okular

https://bugs.kde.org/show_bug.cgi?id=405396 Patrick Silva changed: What|Removed |Added CC||bugsefor...@gmx.com

[okular] [Bug 405398] I'm unable to view the page number option

https://bugs.kde.org/show_bug.cgi?id=405398 --- Comment #2 from Patrick Silva --- *** Bug 405396 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 261538] KXMLGUIClient memory corruption warning

https://bugs.kde.org/show_bug.cgi?id=261538 Mara Raram changed: What|Removed |Added CC|marara...@gmx.net | -- You are receiving this mail because: You are

D18744: Add action in Edit menu to select the text on current page

shubham updated this revision to Diff 54854. shubham added a comment. Do not delete area REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18744?vs=54700=54854 BRANCH arcpatch-D18744 REVISION DETAIL https://phabricator.kde.org/D18744 AFFECTED FILES

Re: Editing features

26 березня 2019, 11:18:01, від "Oliver Sander" : > Dear Okular developers, > > at my day job I get asked about certain (pdf) editing features in Okular. > Specifically, people would like to be able to delete and reorder pages, > merge two documents, etc. > > In the past, such editing features

[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)

https://bugs.kde.org/show_bug.cgi?id=367959 --- Comment #10 from Sergio --- Firefox integrated PDF viewer based on pdf.js is also fine. -- You are receiving this mail because: You are the assignee for the bug.