D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka added a comment. So I will keep it this way. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21195 To: davidhurka, #okular, #vdg Cc: GB_2, davidre, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21195 To: davidhurka, #okular, #vdg Cc: GB_2, davidre, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D21195: [RFC] Create a Change Colors menu (with toolbar button)

ngraham added a comment. Their user interfaces are different; the selection button offers three different types of selections, but allows a click-and-don't-hold to activate the last one. I'm not the hugest fan of this UI; I would prefer three different buttons or a dropdown menu that opens o

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka added a comment. In D21195#468008 , @ngraham wrote: > +1 for this. I think it makes sense. Trying it out, I like it a lot. Sure? This isn’t even consistent with the Selection Tools button. They use an Okular::ToolButton, w

D21202: Added basic JavaScript functions to support animated PDF

aacid added a comment. In D21202#466067 , @joaonetto wrote: > In D21202#466066 , @aacid wrote: > > > Do you have some files that exercise this? > > > > Who would we autotest this? > > > I

D20437: Make selection scrolling go at 60 fps

This revision was automatically updated to reflect the committed changes. Closed by commit R223:e971c67ce10d: Make selection scrolling go at 60 fps (authored by Kezi Olio , committed by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.

D21238: Okular Annotation: add support for line start style for Straight Line tool

tobiasdeiminger added a comment. @knambiar The config dialog for polygon annotations has seemingly regressed with recent changes: F6841550: polygon regression.png Inner color overlaps with Line Start. Would you still be around for a fix? REPOSITOR

D20437: Make selection scrolling go at 60 fps

ngraham added a comment. Thanks @aacid. I've tested this and verified that it works. The code changes are a little bit over my head but @sander has reviewed them. I think it makes sense to land this. Thanks for your patience, @kezik! Please feel free to continue submitting patches. REP

[okular] [Bug 343834] Okular doesn't print some form fields

https://bugs.kde.org/show_bug.cgi?id=343834 --- Comment #3 from Yuri --- Is there any way to let developers know of this important outstanding issue? -- You are receiving this mail because: You are the assignee for the bug.

D21248: Add line annotation ending arrows for non PDF documents

tobiasdeiminger marked 3 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21248 To: tobiasdeiminger, #okular, aacid Cc: ngraham, sander, knambiar, okular-devel, joaonetto, tfella, darcyshen, aacid

D21248: Add line annotation ending arrows for non PDF documents

tobiasdeiminger updated this revision to Diff 58438. tobiasdeiminger added a comment. Fix review comments. Minor cleanups. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21248?vs=58323&id=58438 BRANCH feature/drawlineendings REVISION DETAIL https://pha

[okular] [Bug 397463] okular session management

https://bugs.kde.org/show_bug.cgi?id=397463 Gabriel changed: What|Removed |Added CC||gabrielper...@gmail.com --- Comment #12 from Gabriel

D20832: Fix some clazy warning

nicolasfella added inline comments. INLINE COMMENTS > aacid wrote in parttest.cpp:258 > QStringliteral is broken on windows with non ascii chars, please turn this > back to QString::fromUtf8 so tests don't start failing. Might be worth a comment so the next person knows? REPOSITORY R223 Okul

D20832: Fix some clazy warning

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Please revert the QStringLiteral with utf8 inside, after that you can commit if you're convince there will be no regressions :) INLINE COMMENTS > parttest.cpp:258 > +QTest::newRow("non-u

D20437: Make selection scrolling go at 60 fps

aacid added a comment. I have not reviewed this, i am not thrilled about the licensing situation, but at least relicensing wouldn't be harder than for other people so if other people have reviewed this and made sure it breaks nothing and is a good improvement i won't get mad if this lands.

[okular] [Bug 343834] Okular doesn't print some form fields

https://bugs.kde.org/show_bug.cgi?id=343834 --- Comment #2 from Nate Graham --- Still valid with the latest Okular and Poppler. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 397463] okular session management

https://bugs.kde.org/show_bug.cgi?id=397463 Nate Graham changed: What|Removed |Added Ever confirmed|0 |1 Status|REPORTED

[okular] [Bug 341734] request for: save multi-tab session as named session, select session from menu in new instance

https://bugs.kde.org/show_bug.cgi?id=341734 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE CC|

[okular] [Bug 364680] feature request: restore previous session

https://bugs.kde.org/show_bug.cgi?id=364680 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REPORTED

[okular] [Bug 397463] okular session management

https://bugs.kde.org/show_bug.cgi?id=397463 Nate Graham changed: What|Removed |Added CC||pmli...@free.fr --- Comment #11 from Nate Graham

[okular] [Bug 407548] [Wish] Support save/restore session

https://bugs.kde.org/show_bug.cgi?id=407548 Nate Graham changed: What|Removed |Added Resolution|--- |DUPLICATE CC|

[okular] [Bug 397463] okular session management

https://bugs.kde.org/show_bug.cgi?id=397463 Nate Graham changed: What|Removed |Added CC||ric.richte...@gmail.com --- Comment #10 from Nate

[okular] [Bug 397463] okular session management

https://bugs.kde.org/show_bug.cgi?id=397463 Nate Graham changed: What|Removed |Added CC||ho...@spliced.me.uk --- Comment #9 from Nate Grah

D21196: [RFC] Move Continuous option to View Mode submenu

ngraham added a comment. Moving Continuous into the sub-menu amounts to a regression for menubar users since it becomes less noticeable in there. However I think there's an obvious solution: add the View Mode action to the default toobar, next to the Zoom combobox. Then all of this functiona

D21195: [RFC] Create a Change Colors menu (with toolbar button)

ngraham added a comment. +1 for this. I think it makes sense. Trying it out, I like it a lot. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21195 To: davidhurka, #okular, #vdg Cc: GB_2, davidre, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen

D21320: Fix build with poppler < 0.51

volkov added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21320 To: volkov, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21320: Fix build with poppler < 0.51

volkov created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. volkov requested review of this revision. REPOSITORY R223 Okular BRANCH Applications/19.04 REVISION DETAIL https://phabricator.kde.org/D21320 AFFECTED FILES generators/poppler/formfiel

D14655: Reimplement signature form field and related utility classes in poppler generator

volkov added inline comments. INLINE COMMENTS > formfields.h:134 > +private: > +Poppler::FormFieldSignature * m_field; > +mutable PopplerSignatureInfo *m_info; It's available since poppler 0.51, so this change broke build with older versions. REPOSITORY R223 Okular REVIS

D21248: Add line annotation ending arrows for non PDF documents

ngraham added reviewers: Okular, aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21248 To: tobiasdeiminger, #okular, aacid Cc: ngraham, sander, knambiar, okular-devel, joaonetto, tfella, darcyshen, aacid

D21195: [RFC] Create a Change Colors menu (with toolbar button)

davidhurka added inline comments. INLINE COMMENTS > pageview.cpp:5705 > > +void PageView::slotSetChangeColorsMode( QAction * action ) > +{ Just discovered that the existing slots (slotToggleChangeColors(), slotSetChangeColors(bool)) are exposed to D-Bus through Okular::Part. Probably, there

D21248: Add line annotation ending arrows for non PDF documents

tobiasdeiminger added inline comments. INLINE COMMENTS > sander wrote in pagepainter.cpp:450 > Is that `MISSING` comment still relevant? What exactly does it mean anyway? The comment below for `HighlightAnnotation` says `MISSING: under/strike width, feather, capping`, so it seems the comments

D21248: Add line annotation ending arrows for non PDF documents

sander added inline comments. INLINE COMMENTS > pagepainter.cpp:450 > // draw LineAnnotation MISSING: all > if ( type == Okular::Annotation::ALine ) > { Is that `MISSING` comment still relevant? What exactly does it mean anyway? > pagepainter