D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham added a comment. In D21635#475539 , @aacid wrote: > But we're setting the menu here no? > > ac->setDefaultShortcut(d->aMouseTextSelect, Qt::CTRL + Qt::Key_3); > > > Can it just be still be a 4? The current keyboard s

D21622: Use a more conventional dropdown menu style instead of press-and-hold

aacid added a comment. A, yes, the everyone does it wrong except me reasoning. Ok. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21622 To: ngraham, #okular, #vdg, ndavis Cc: aacid, ndavis, abetts, filipf, okular-devel, joaonetto, tfella, ngraham, darcyshen

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

aacid added a comment. But we're setting the menu here no? ac->setDefaultShortcut(d->aMouseTextSelect, Qt::CTRL + Qt::Key_3); Can it just be still be a 4? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis, aacid Cc: aac

D21622: Use a more conventional dropdown menu style instead of press-and-hold

ngraham added a comment. In D21622#475508 , @aacid wrote: > I don't know why you say "it's a more common way", kmail does exactly what okular did, thus, being consistent. ...Consistently bad! :) KMail is wrong too, because press-and-hold

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham added a comment. In D21635#475496 , @aacid wrote: > *Do not change the shortcuts* In that case perhaps we should revert D21624 and then find another way to make the toolbar selection menu butt

D21630: Change Browse icon back to the hand shape

aacid added a comment. In D21630#475517 , @ndavis wrote: > In D21630#475501 , @aacid wrote: > > > **wow** Not even one minute to review things > > > > I don't particularly like this, input-mouse i

D21630: Change Browse icon back to the hand shape

ndavis added a comment. @aacid `transform-move` is less correct, but it's in Oxygen and Papirus (not Adwaita). Would you prefer if that icon was used? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21630 To: ndavis, #okular, #vdg, ngraham Cc: aacid, ngraham, okular-

D21630: Change Browse icon back to the hand shape

ndavis added a comment. In D21630#475501 , @aacid wrote: > **wow** Not even one minute to review things > > I don't particularly like this, input-mouse is an icon that exists in most icon themes > extra/adwaita-icon-theme > extra/breeze

D21622: Use a more conventional dropdown menu style instead of press-and-hold

aacid added a comment. I don't know why you say "it's a more common way", kmail does exactly what okular did, thus, being consistent. Now try using this with a touch screen, how do you click on the 2x2 pixels that represent the arrow? But hey, don't give me enough time to give feedb

D21630: Change Browse icon back to the hand shape

aacid added a comment. **wow** Not even one minute to review things I don't particularly like this, input-mouse is an icon that exists in most icon themes extra/adwaita-icon-theme extra/breeze-icons extra/efl extra/gnome-icon-theme extra/gnome-icon-theme-symbolic extra/gnome-t

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. *Do not change the shortcuts* REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis, aacid Cc: aacid, okular-devel, joaon

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham added a comment. I am a little hesitant to do this since changing shortcuts is always a bit controversial and we'd be resetting people's muscle memory for these tools. :/ But I don't see any way around it unless we revert D21624 and find a dif

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH re-arrange-shortcuts-and-menu-items-accordingly (branched from master) REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis Cc: okular-devel, joao

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham created this revision. ngraham added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. ngraham requested review of this revision. REVISION SUMMARY D21624 re-arranged the ordering of the selection tools i

D21633: Change Text Selection icon to edit-select-text

This revision was automatically updated to reflect the committed changes. Closed by commit R223:2c39981b21d9: Change Text Selection icon to edit-select-text (authored by ndavis). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21633?vs=59284&id=59288 REVISION D

D21633: Change Text Selection icon to edit-select-text

ndavis edited the test plan for this revision. REPOSITORY R223 Okular BRANCH edit-select-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH edit-select-text (branched from master) REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcys

D21633: Change Text Selection icon to edit-select-text

ndavis edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

ndavis added a dependency: D21632: Add edit-select-text, make 16px draw-text like 22px. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

ndavis edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21633 To: ndavis, #vdg, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21633: Change Text Selection icon to edit-select-text

ndavis created this revision. ndavis added reviewers: VDG, Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. ndavis requested review of this revision. REVISION SUMMARY The current icon (draw-text) is semantically incorrect. This patch makes the Text Selection tool

D21630: Change Browse icon back to the hand shape

This revision was automatically updated to reflect the committed changes. Closed by commit R223:9310bed61621: Change Browse icon back to the hand shape (authored by ndavis). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21630?vs=59275&id=59278 REVISION DETAIL

D21630: Change Browse icon back to the hand shape

ndavis edited the test plan for this revision. REPOSITORY R223 Okular BRANCH fix-browse-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D21630 To: ndavis, #okular, #vdg, ngraham Cc: ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid

D21630: Change Browse icon back to the hand shape

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, `transform-browse` is a more semantically correct icon anyway. REPOSITORY R223 Okular BRANCH fix-browse-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/

D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default

This revision was automatically updated to reflect the committed changes. Closed by commit R223:e84733549d11: In Toolbar's selection mode menu, show "Text Selection" tool by default (authored by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21624?vs=

D21630: Change Browse icon back to the hand shape

ndavis created this revision. ndavis added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. ndavis requested review of this revision. REVISION SUMMARY I changed the `input-mouse` icon so that it would look more like a real mouse. In order to keep

D21622: Use a more conventional dropdown menu style instead of press-and-hold

This revision was automatically updated to reflect the committed changes. Closed by commit R223:c79244455050: Use a more conventional dropdown menu style instead of press-and-hold (authored by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21622?vs=59

[okular] [Bug 407869] Okular KParts plugin steals space key events from shell

https://bugs.kde.org/show_bug.cgi?id=407869 Alexander Potashev changed: What|Removed |Added CC||aspotas...@gmail.com -- You are receiving

D21622: Use a more conventional dropdown menu style instead of press-and-hold

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH use-more-conventional-dropdown-menu-style (branched from master) REVISION DETAIL https://phabricator.kde.org/D21622 To: ngraham, #okular, #vdg, ndavis Cc: ndavis, abetts, filipf,

D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH show-text-selection-in-toolbar-menu-by-default (branched from master) REVISION DETAIL https://phabricator.kde.org/D21624 To: ngraham, #okular, #vdg, ndavis Cc: ndavis, okular-deve

D21622: Use a more conventional dropdown menu style instead of press-and-hold

ndavis added a comment. +1, pressing and holding feels unnecessarily slow. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21622 To: ngraham, #okular, #vdg Cc: ndavis, abetts, filipf, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default

ndavis added a comment. +1. Text selection is what I want most of the time and having to switch back to it whenever I'm done with the annotation tools is annoying. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21624 To: ngraham, #okular, #vdg Cc: ndavis, okular-dev

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 --- Comment #9 from Nate Graham --- (In reply to David Hurka from comment #8) > Additionally to that, could there be a graphic next to the combobox to > explain the effect? I find “Fit to Printable Area” and “Fit to Full Page” > ambiguous enough to do s

D21622: Use a more conventional dropdown menu style instead of press-and-hold

abetts added a comment. In D21622#475230 , @ngraham wrote: > +1 to what? The patch's current change, or what we're still discussing? :) On visuals. I hadn't seen this patch until now. :) REPOSITORY R223 Okular REVISION DETAIL https:/

D21622: Use a more conventional dropdown menu style instead of press-and-hold

ngraham added a comment. +1 to what? The patch's current change, or what we're still discussing? :) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21622 To: ngraham, #okular, #vdg Cc: abetts, filipf, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21621: Regularize tool names

abetts added a comment. +1 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21621 To: ngraham, #okular, #vdg, filipf Cc: abetts, filipf, okular-devel, kde-doc-english, gennad, joaonetto, tfella, ngraham, skadinna, darcyshen, aacid

D21622: Use a more conventional dropdown menu style instead of press-and-hold

abetts added a comment. +1 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21622 To: ngraham, #okular, #vdg Cc: abetts, filipf, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid

D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default

ngraham created this revision. ngraham added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, the Toolbar's selection mode menu shows the rectangular selection mode by defaul

D21621: Regularize tool names

This revision was automatically updated to reflect the committed changes. Closed by commit R223:c325cb416113: Regularize tool names (authored by ngraham). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21621?vs=59261&id=59263 REVISION DETAIL https://phabricat

D21622: Use a more conventional dropdown menu style instead of press-and-hold

ngraham added a comment. It is, yes. If we don't like that but want to keep this dropdown menu button, the only alternative is to do `button->setDelayed(false)` which will make the whole button show the dropdown on click, but this will remove the ability to quickly enable the current tool an

D21622: Use a more conventional dropdown menu style instead of press-and-hold

filipf added a comment. I was just having issues with this when I was looking at D21621 . I had completely forgotten that click and hold is how you change it. As for this solution, I haven't tested it but the hit area is quite small isn't it? REPOSIT

D21622: Use a more conventional dropdown menu style instead of press-and-hold

ngraham created this revision. ngraham added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, `ToolAction` menus (of which there is only one, the selection tool menu) activat

D21621: Regularize tool names

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Makes sense to me. REPOSITORY R223 Okular BRANCH adjust-selection-tool-names (branched from master) REVISION DETAIL https://phabricator.kde.org/D21621 To: ngraham, #okular, #vdg, fi

D21621: Regularize tool names

ngraham edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21621 To: ngraham, #okular, #vdg Cc: okular-devel, kde-doc-english, gennad, joaonetto, tfella, ngraham, skadinna, darcyshen, aacid

D21621: Regularize tool names

ngraham created this revision. ngraham added reviewers: Okular, VDG. Herald added projects: Okular, Documentation. Herald added subscribers: kde-doc-english, okular-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, some of the items in the Tools menu have "tool" in th

D21202: [WIP] Support animated PDF

joaonetto updated this revision to Diff 59257. joaonetto added a comment. Implemented buttonGetIcon and buttonSetIcon REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21202?vs=59102&id=59257 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2120

[okular] [Bug 408272] The default scaling method should be "Fit to Full Page"

https://bugs.kde.org/show_bug.cgi?id=408272 --- Comment #8 from David Hurka --- (In reply to Nate Graham from comment #4) > - Make the scaling combobox more visible and prominent so it's easier to > notice and change Additionally to that, could there be a graphic next to the combobox to explain

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 Michael Weghorn changed: What|Removed |Added Status|REPORTED|NEEDSINFO Resolution|---

[okular] [Bug 408270] Okular always prints in A4 on physical printers, even when Letter is the default

https://bugs.kde.org/show_bug.cgi?id=408270 --- Comment #8 from Michael Weghorn --- Created attachment 120617 --> https://bugs.kde.org/attachment.cgi?id=120617&action=edit file in /var/spool/cups/ generated by Okular with dummy printer using same PPD I cannot reproduce on Debian testing (okula