D22064: General improvements to stamp annotation

ngraham edited the summary of this revision. REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshe

D22064: General improvements to stamp annotation

ngraham accepted this revision. ngraham added a comment. +1, I say shipit! REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, fbampaloukas,

D22064: General improvements to stamp annotation

simgunz added a comment. Final version of the new UI components: F7092260: Screenshot_20190724_215313.png F7092263: Screenshot_20190724_215331.png If there are not further comments, I am going to land

D22064: General improvements to stamp annotation

simgunz updated this revision to Diff 62500. simgunz added a comment. - Fix messages and i18nc REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22064?vs=62454&id=62500 BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 AF

D22064: General improvements to stamp annotation

ngraham added a comment. In D22064#501601 , @simgunz wrote: > In D22064#501557 , @ngraham wrote: > > > Exactly what I was imagining!I might also add at the beginning something like: "Warning: featu

[okular] [Bug 408683] blank page until I scroll

https://bugs.kde.org/show_bug.cgi?id=408683 Albert Astals Cid changed: What|Removed |Added Status|NEEDSINFO |RESOLVED Resolution|WAITINGFORINFO

D22713: Use KRun::runApplication instead of KRun::runService

aacid added a comment. In which KF5 version has runApplication been introduced? Can you please use invent.k.o in the future? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22713 To: nicolasfella, #okular Cc: aacid, okular-devel, maguirre, fbampaloukas, joaonetto

D22064: General improvements to stamp annotation

simgunz added a comment. In D22064#501557 , @ngraham wrote: > Exactly what I was imagining!I might also add at the beginning something like: "Warning: feature is considered experimental." Is it ok like this? F7091319: Screenshot_201907

D15580: [WIP] New annotation toolbar

simgunz updated this revision to Diff 62478. simgunz added a comment. - Add geometrical annotations to action collection - Move arrow before straight line - Allow setting action text - Set default shortcuts - Set favorite tools default shortcuts - Fix i18n argument - Auto-update con

D22064: General improvements to stamp annotation

ngraham accepted this revision. ngraham added a comment. Looks good to go from my perspective. My vote goes to shipping it after you tweak the string in the way I suggested. Nice work! 👍 REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org

D22064: General improvements to stamp annotation

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: pino, aacid, yurchor, ngraham, okular-devel, maguirre, f

D22064: General improvements to stamp annotation

ngraham added a comment. Exactly what I was imagining!I might also add at the beginning something like: "Warning: this feature is considered experimental." REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular,

[okular] [Bug 409938] No option to change default print dialog settings

https://bugs.kde.org/show_bug.cgi?id=409938 Nate Graham changed: What|Removed |Added CC||n...@kde.org -- You are receiving this mail beca

[okular] [Bug 408683] blank page until I scroll

https://bugs.kde.org/show_bug.cgi?id=408683 --- Comment #10 from Con Hennessy --- I just tested this problem with the file mentioned above, it looks like the problem is resolved. I did not do anything explicitly so I assume that there was changes in the underlying application or libraries betwe

[okular] [Bug 409938] No option to change default print dialog settings

https://bugs.kde.org/show_bug.cgi?id=409938 kvztechnik changed: What|Removed |Added CC||tech...@kv-zinnowitz.de -- You are receiving this

D22713: Use KRun::runApplication instead of KRun::runService

nicolasfella created this revision. nicolasfella added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. nicolasfella requested review of this revision. REVISION SUMMARY KRun::runService is about to be deprecated. The difference is that runService wait

D22713: Use KRun::runApplication instead of KRun::runService

nicolasfella edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D22713 To: nicolasfella, #okular Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D22064: General improvements to stamp annotation

simgunz added a comment. F7089222: Screenshot_20190724_085941.png REPOSITORY R223 Okular BRANCH improve-stamp-annotation REVISION DETAIL https://phabricator.kde.org/D22064 To: simgunz, #okular, ngraham Cc: pino, aacid, yurchor, ngraham, okular-d