[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Oliver Sander
https://bugs.kde.org/show_bug.cgi?id=263042 Oliver Sander changed: What|Removed |Added CC||oliver.san...@tu-dresden.de --- Comment #17 fro

D21971: Replace ToolAction by ToggleActionMenu

2019-11-06 Thread David Hurka
davidhurka updated this revision to Diff 69368. davidhurka edited the summary of this revision. davidhurka edited the test plan for this revision. davidhurka added a comment. - Try to improve documentation, exspecially how to set the default action REPOSITORY R223 Okular CHANGES SINCE LAST

D21971: Replace ToolAction by ToggleActionMenu

2019-11-06 Thread David Hurka
davidhurka added a comment. To answer your second comment first, and to be sure you understand everything how I understand you understand it... In D21971#559081 , @simgunz wrote: > I also would like to get rid of `DefaultLogic` and just use

[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Luigi Toscano
https://bugs.kde.org/show_bug.cgi?id=263042 Luigi Toscano changed: What|Removed |Added CC||luigi.tosc...@tiscali.it --- Comment #16 from L

[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=263042 Nate Graham changed: What|Removed |Added Resolution|--- |UPSTREAM Status|CONFIRMED

[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Munzir Taha
https://bugs.kde.org/show_bug.cgi?id=263042 Munzir Taha changed: What|Removed |Added CC||munzirt...@gmail.com --- Comment #14 from Munzir

[okular] [Bug 413695] bug in review bar, custom tool, text comment color gets reverted

2019-11-06 Thread Simone Gaiarin
https://bugs.kde.org/show_bug.cgi?id=413695 --- Comment #6 from Simone Gaiarin --- The settings look correct. The fact that when the annotation is moved the color is set to the correct one suggests that it is something related to how the annotation is rendered. The new annotation toolbar is not

[okular] [Bug 413819] highlight annotation not carried over to pdfjs

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413819 --- Comment #8 from ghavami...@hotmail.com --- pls ignore 1st picture, (it's same as 4, I don't know how to remove it) so i took exactly the same steps as before... and got a completely different this, I couldn't reproduce the same error, but got an even

[okular] [Bug 413819] highlight annotation not carried over to pdfjs

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413819 --- Comment #7 from ghavami...@hotmail.com --- Created attachment 123763 --> https://bugs.kde.org/attachment.cgi?id=123763&action=edit pdf -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 413819] highlight annotation not carried over to pdfjs

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413819 --- Comment #6 from ghavami...@hotmail.com --- Created attachment 123762 --> https://bugs.kde.org/attachment.cgi?id=123762&action=edit 4 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 413819] highlight annotation not carried over to pdfjs

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413819 --- Comment #5 from ghavami...@hotmail.com --- Created attachment 123761 --> https://bugs.kde.org/attachment.cgi?id=123761&action=edit 3 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 413819] highlight annotation not carried over to pdfjs

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413819 --- Comment #4 from ghavami...@hotmail.com --- Created attachment 123760 --> https://bugs.kde.org/attachment.cgi?id=123760&action=edit 2 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 413819] highlight annotation not carried over to pdfjs

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413819 --- Comment #2 from ghavami...@hotmail.com --- Created attachment 123758 --> https://bugs.kde.org/attachment.cgi?id=123758&action=edit 1 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 413819] highlight annotation not carried over to pdfjs

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413819 --- Comment #3 from ghavami...@hotmail.com --- Created attachment 123759 --> https://bugs.kde.org/attachment.cgi?id=123759&action=edit 1 -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Andrew DeMarsh
https://bugs.kde.org/show_bug.cgi?id=263042 --- Comment #13 from Andrew DeMarsh --- Created attachment 123750 --> https://bugs.kde.org/attachment.cgi?id=123750&action=edit attachment-32018-0.html -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Andrew DeMarsh
https://bugs.kde.org/show_bug.cgi?id=263042 --- Comment #12 from Andrew DeMarsh --- Thank you Albert that clarifies things for me and most likely others that look back on this. On Wed, Nov 6, 2019 at 7:10 AM Albert Astals Cid wrote: > *Comment # 11

[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=263042 --- Comment #11 from Albert Astals Cid --- The pdf spec is 1000 pages, the XFA spec is 1600 pages. -- You are receiving this mail because: You are the assignee for the bug.

[okular] [Bug 263042] XFA Forms are not supported

2019-11-06 Thread Andrew DeMarsh
https://bugs.kde.org/show_bug.cgi?id=263042 --- Comment #10 from Andrew DeMarsh --- Regarding your "reality check" does the support depend on this money due to some technical resource cost or for you to consider supporting it. Telling government agencies to regenerate millions of forms in a new f

[okular] [Bug 413810] QUESTION: scrollbar margin

2019-11-06 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=413810 --- Comment #4 from pierrescal...@gmail.com --- "Allow resizing maximized windows from window edges" wasn't checked. |Check the option/test scroll/uncheck the option/test scroll| still nothing, the cursor isn't on the scrollbar. -- You are receiving t

D21195: [RFC] Create a Change Colors menu (with toolbar button)

2019-11-06 Thread Simone Gaiarin
simgunz added inline comments. INLINE COMMENTS > davidhurka wrote in pageview.h:75 > In the meantime I learned more about this. > > The Color Mode menu will stay here in PageView::setupViewerActions(), because > it is needed only in viewer modes, and is page view related. > > m_embedMode is no

D21971: Replace ToolAction by ToggleActionMenu

2019-11-06 Thread Simone Gaiarin
simgunz added a comment. I also would like to get rid of `DefaultLogic` and just use `ImplicitDefaultAction`, but I am not sure if this creates problem when `ToggleActionMenu` is placed in a menu. Should it behave as a standard `KActionMenu` when in a menu? I think that when in a menu there

D21971: Replace ToolAction by ToggleActionMenu

2019-11-06 Thread Simone Gaiarin
simgunz added a comment. I have tried to analyze all the possible cases regarding `ToggleActionMenu` placed in a toolbar. From what I understand: - `DefaultLogic` means, the developer needs to manage everything manually calling/connecting `setDefaultAction`. - `ImplicitDefaultActi