D15279: Store all annotation color attributes as ARGB string

dileepsankhla added a comment. Thank you Tobias for making it landable. Please go ahead :) REPOSITORY R223 Okular BRANCH annotation_rgba REVISION DETAIL https://phabricator.kde.org/D15279 To: tobiasdeiminger, sander Cc: dileepsankhla, sander, okular-devel, ngraham, aacid

D13203: Add Typewriter annotation tool in Okular

dileepsankhla abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: sander, ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

Re: Contributing to Okular

Hi Kanchan, Welcome to the project Okular! KDE Community greets you :) 1. You should have an intermediate programming experience in C++ ranging from basic variables and iterations to class and objects. If you know about the basic constructs in C++ including functions then you can begin to

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 38049. dileepsankhla added a comment. Set flag HAVE_POPPLER_0_67 in generator/poppler REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=37378=38049 BRANCH master REVISION DETAIL

D13203: Add Typewriter annotation tool in Okular

dileepsankhla marked 7 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: sander, ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added inline comments. INLINE COMMENTS > sander wrote in annots.cpp:182 > 1.) yes > > 2. You need to write a test that sets the HAVE_POPPLER_0_67 flag. Have a look > at that CMakeLists.txt file. It contains calls to check_cxx_source_compiles. > Each call contains a small C++

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in annots.cpp:182 > Poppler::TextAnnotation::setTextFont is brand new poppler API (actually not > yet merged). We still want to support builds with older poppler versions. So > setTextFont needs to be surrounded by

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 37378. dileepsankhla added a comment. Updated generator/poppler for text color REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=37290=37378 BRANCH master REVISION DETAIL

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 37290. dileepsankhla added a comment. Added font color in Okular REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=36397=37290 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13203 AFFECTED

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 36397. dileepsankhla marked an inline comment as done. dileepsankhla added a comment. Updating tools.xml elements color attributes to incorporate #AARRGGBB color formats REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D13203: Add Typewriter annotation tool in Okular

dileepsankhla marked 4 inline comments as done. dileepsankhla added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in editannottooldialog.cpp:128 > > So if we adopt the new color format in the default tools in tools.xml, do > > we need to alter all the color entries? Or is it okay to

D13203: Add Typewriter annotation tool in Okular

dileepsankhla edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 36312. dileepsankhla added a comment. Adapt CloseDialogHelper for use with QInputDialog. Close typewriter input dialog with ok button and test for expected typewriter annotation. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D13203: Add Typewriter annotation tool in Okular

dileepsankhla marked 7 inline comments as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in parttest.cpp:1582 > The QInputDialog is pure Qt functionality, just closing it is not that > interesting in a typewriter test case. The more interesting thing is to > verify if annotation is created correctly after

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 35977. dileepsankhla added a comment. Adding tests for typewriter annotation tool REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35508=35977 BRANCH master REVISION DETAIL

Re: Need help in getting started with writing the integration test

On Sat, Jun 9, 2018 at 1:43 AM Tobias Deiminger wrote: > Am 08.06.2018 18:57 schrieb Dileep Sankhla: > > Hello Tobias, > > > > I have succeeded in getting the QInputDialog to write a new note: > > > > QMetaObject::invokeMethod(part.m_pageView, "slotT

Re: Need help in getting started with writing the integration test

ny visual of the added annotation. I want to compare different properties from Okular::Annotation::getAnnotationPropertiesDomeNode. May you help me where I'm wrong or what I'm missing? Thanks and Regards Dileep On Fri, Jun 8, 2018 at 3:20 PM Dileep Sankhla wrote: > Thank you. I have created a

Re: Need help in getting started with writing the integration test

Thank you. I have created a single test case for the typewriter toolbutton and have pushed it to the gsoc2018_typewriter branch. I have defined 3 test cases as follows: 1. Check if the toolbar buttons contain the "Typewriter" button - Done 2. Click the typewriter button, start PickPointEngine

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added inline comments. INLINE COMMENTS > tobiasdeiminger wrote in editannottooldialog.cpp:128 > So from now on ALL annotations (even ink, highlight, inline note etc) that > are created by a user-defined tool will store color as #AARRGGBB in *.okular > document archive, right?

Re: Need help in getting started with writing the integration test

m_document); pageviewannotator.setEnabled( true ); But on make, I'm getting linking error as the undefined reference to PageViewAnnotator::PageViewAnnotator(PageView*, Okular::Document*) How to resolve this and check for the typewriter tool button in the toolbar? On Wed, Jun 6, 2018 at 3:08 PM, Dileep Sank

Re: Need help in getting started with writing the integration test

keypress for showing the annotation toolbar and if yes, then how will I check for the specific tool in it? Need help. Thanks and Regards Dileep On Mon, Jun 4, 2018 at 1:19 AM, Tobias Deiminger wrote: > Am 03.06.2018 21:39 schrieb Tobias Deiminger: > >> Am 03.06.2018 08:05

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 35508. dileepsankhla added a comment. Diff changed after commiting to gsoc2018_typewriter branch. Updating it. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35507=35508 BRANCH master REVISION DETAIL

D13203: Add Typewriter annotation tool in Okular

dileepsankhla reopened this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. dileepsankhla marked an inline comment as done. Closed by commit R223:66c70934b82c: popup window background color (authored by

Need help in getting started with writing the integration test

Hello everyone, I have created a revision[0] for adding the typewriter annotation tool to Okular and now I need to write the integration test for the same. I'm not getting whether to make a new file autotests/typewriterannotationtest.cpp or to append the test in the existing

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added a reviewer: tobiasdeiminger. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla, tobiasdeiminger Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 35383. dileepsankhla added a comment. Updating annotation popup window background color REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35333=35383 BRANCH master REVISION DETAIL

D13203: Add Typewriter annotation tool in Okular

dileepsankhla reopened this revision. dileepsankhla marked an inline comment as done. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: ltoscano, ngraham, tobiasdeiminger, aacid, okular-devel

D13203: Add Typewriter annotation tool in Okular

dileepsankhla marked an inline comment as done. dileepsankhla added a comment. The revision is closed. I'm unable to update it. Maybe someone with admin privileges should reopen it? INLINE COMMENTS > tobiasdeiminger wrote in annotwindow.cpp:262 > `QColor(m_annot->style().color().name())` is

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added a comment. Hell! Sorry for this mistake again. Whenever I update the revision, I push the commit to the gsoc2018_typewriter branch too and the revision landed in need review state by that commit (both have the same hash). @ltoscano May you please reopen this revision?

D13203: Add Typewriter annotation tool in Okular

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:f0063e548b1b: Fixed initial typewriter width to 0 (authored by dileepsankhla). CHANGED PRIOR TO COMMIT

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 35332. dileepsankhla added a comment. Fixed initial typewriter border width to 0 REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35240=35332 BRANCH master REVISION DETAIL

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added a comment. > I didn't mean to change anything in Poppler. I meant it's the way it works in Poppler right now. I assume if both 'rg' operator and 'ca' entry are applied, alpha gets multiplied. Probably also depending on >blend mode. I don't know how this works exactly,

D13203: Add Typewriter annotation tool in Okular

dileepsankhla updated this revision to Diff 35240. dileepsankhla added a comment. Fixed typewriter transparency in PagePainter REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13203?vs=35136=35240 BRANCH master REVISION DETAIL

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added a comment. > How about changing ui/pagepainter.cpp L668 to > > acolor.setAlpha( a->style().opacity() * a->style().color().alpha() ); > > It gives us transparent background for new typewriter annotations. It should be backwards/forwards compatible with *.okular

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added a comment. In D13203#270552 , @tobiasdeiminger wrote: > If I use the new tool to typewrite onto a plain text file, I get opaque white background instead of transparent background. Transparency does work for PDF documents

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added a comment. > The gsoc* branches are meant to share and log small junks of GSoC progress frequently (even daily), prior to publishing a ready-to-review patch on phabricator. But there haven't been any intermediate GSoC commits during the past two weeks on

[okular] [Bug 394834] Okular not release memory (ram) taken by closed documents

https://bugs.kde.org/show_bug.cgi?id=394834 Dileep Sankhla changed: What|Removed |Added Latest Commit|https://commits.kde.org/oku |https://commits.kde.org/oku

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added a comment. @ngraham This is the part of my GSoC project: https://summerofcode.withgoogle.com/projects/#6053164340477952 I have committed the same to my separate branch: https://cgit.kde.org/okular.git/log/?h=gsoc2018_typewriter but don't know how it got landed! It

D13203: Add Typewriter annotation tool in Okular

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:c344c5e31b6a: Added Typewriter annotation tool (authored by dileepsankhla). REPOSITORY R223 Okular CHANGES SINCE

D13203: Add Typewriter annotation tool in Okular

dileepsankhla added subscribers: aacid, tobiasdeiminger. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D13203 To: dileepsankhla Cc: tobiasdeiminger, aacid, okular-devel, ngraham

D13203: Add Typewriter annotation tool in Okular

dileepsankhla created this revision. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. dileepsankhla requested review of this revision. REVISION SUMMARY This patch adds the typewriter annotation tool in Okular with a new typewriter icon

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

Hello Albert, > Are you speaking of not having that for the new tool or removing it > altogether? I'm just suggesting to not have the hover icon for the new typewriter tool. We should not remove it for the inline note. What do you finally suggest? Thanks and Regards, Dileep

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

Hello everyone, > Basically, annotation color is set as a common attribute to all annotation >> types at the end of the file and if we should bypass it with an if >> condition that will set annotation color for type "typewriter" hardcoded >> to >> QColor(255,255,255,0). >> I have tried

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

iguration). > > Am Freitag, 18. Mai 2018, 17:04:09 CEST schrieb Dileep Sankhla: > >> 4. In Okular::Annotation::Style::setColor(const QColor ), it sets >> d->m_color = color (see tree/core/annotations.cpp. Here d is just a >> pointer >> to a class Private). Does it s

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

me to join discussion and answering:) > > Am 18.05.2018 17:04 schrieb Dileep Sankhla: > >> I have few things to ask before getting it done and it would be nice >> if you can reply to any of the queries with your own suggestions. >> >> 1. In tree/ui/data/tools.xml, we have

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

Hi Albert, ‌ On Sun, May 20, 2018 at 3:02 PM, Albert Astals Cid <aa...@kde.org> wrote: > El divendres, 18 de maig de 2018, a les 17:04:09 CEST, Dileep Sankhla va > escriure: > > Hello everyone, > > > > I'm working on my GSoC project[0] with my mentor Tobias Deiming

Queries regarding adding a new 'typewriter' annotation tool to the toolbar

Hello everyone, I'm working on my GSoC project[0] with my mentor Tobias Deiminger and I need to add a new 'typewriter' tool to the annotation toolbar with a new icon and a setting dialogue to customize its font [and font color]. I have few things to ask before getting

FreeText typewriter annotation WYSIWYG implementation ideas

Hello all, I'm working with my mentor Tobias Deiminger on the GSoC project[0] regarding implementing the FreeText annotation with FreeTextTypewriter (WYSIWYG live editing) behavior. I have written a blog post[1] where I have presented three of the ideas to implement WYSIWYG

Queries regarding terminologies used in Okular PDF annotation rendering

Hi there, Please try to answer my following queries: 1. What is "viewport"? 2. What is "pageview"? 3. How does PDF save an annotation in the document? 4. What is "generator" and how does generator render the annotation in PDF page? What is the meaning of "rendering" here? 5. Now how does

[okular] [Bug 325119] Size of inline notes not adjusted to font size and does not respect drawn boundaries

https://bugs.kde.org/show_bug.cgi?id=325119 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

D11051: Remembering side navigation panel state

dileepsankhla added a comment. Currently I am working as a GSoC student and in discussion with my mentor, I have decided to pause the patch report during the GSoC period. BBL REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular, aacid Cc:

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

https://bugs.kde.org/show_bug.cgi?id=353401 --- Comment #28 from Dileep Sankhla <sankhla.dilee...@gmail.com> --- I'm working on this feature request as a GSoC 2018 student and you can find my project here: https://summerofcode.withgoogle.com/projects/#6053164340477952 and my proposal here:

D11051: Remembering side navigation panel state

dileepsankhla added a comment. The state can be saved whenever a sidebar item is clicked in Sidebar::itemClicked but again as discussed earlier, it will be asymmetrical as to save in sidebar.cpp. Should I implement a signal slot mechanism in part.cpp to achieve so or should I find another

D11051: Remembering side navigation panel state

dileepsankhla added a comment. I tried but it is still giving me the segfault. The interesting thing, in my opinion, is whenever you open Okular and close it down without changing the sidebar state, it doesn't give a segfault whereas changing the sidebar state and closing it gives the

D11051: Remembering side navigation panel state

dileepsankhla added a comment. The verbose output of valgrind is around 190,000 lines with the line numbers. Here is the output: https://dileepsankhla.com/valgrind.txt REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular, aacid Cc:

D11051: Remembering side navigation panel state

dileepsankhla added a comment. https://paste.kde.org/pepnfuzxq REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular, aacid Cc: aacid, sander, #okular, michaelweghorn, ngraham

D11051: Remembering side navigation panel state

dileepsankhla added a comment. Following is the log of running valgrind on okular: https://paste.kde.org/pmyjdscmw/ohzvag I have no luck in understanding the verbose. May you please help me by checking it out? REPOSITORY R223 Okular

D11051: Remembering side navigation panel state

dileepsankhla updated this revision to Diff 30742. dileepsankhla added a comment. Updating: Remembring side navigation panel state Changing the state to the one being discussed here in comments. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D11051: Remembering side navigation panel state

dileepsankhla added a comment. Actually I am getting the segmentation fault whenever I close Okular with a changed state of the side navigation panel and the code causing it is `Okular::Settings::setHideSideContainer( m_sidebar->isCollapsed() )` inside the Part destructor. `m_sidebar` is

Re: GSoC Proposal: Implementing the FreeText annotation (Draft)

@Tobias: Thank you so much for pointing out the minute details. I have changed the project title and the details accordingly. I am refining it more before the final submission. It is now clearer to me than before and I understood the confusing part. @Oliver: This creates a great project and

[okular] [Bug 353401] Feature requst: "typewriter" annotation tool

https://bugs.kde.org/show_bug.cgi?id=353401 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

GSoC Proposal: Implementing the FreeText annotation (Draft)

appreciated. Thanks and Regards, Dileep Sankhla ‌

[Need immediate help for GSoC project] Implementing FreeText annotation

itten when this annotation is implemented? Thanks and Regards Dileep Sankhla ‌

General doubts regarding annotations and its poppler support for GSoC project

Hello all, I am writing my proposal for the GSoC project, "Implement FreeText Annotation" and I have some doubts to clear before proceeding ahead. Kindly help me: 1. What does Okular use - the core poppler or poppler Qt5 interface library? 2. There is partial FreeText (TypeWriter) annotation

D11051: Remembering side navigation panel state

dileepsankhla marked an inline comment as done. dileepsankhla added a comment. In D11051#05 , @aacid wrote: > Also i'm not convinced it's a good idea to save the settings in sidebar.cpp but read them in part.cpp, seems a bit asymmetrical,

[okular] [Bug 344599] Thumbnails sidebar always open when okular starts

https://bugs.kde.org/show_bug.cgi?id=344599 --- Comment #11 from Dileep Sankhla <sankhla.dilee...@gmail.com> --- May someone please review my patch being sent? -- You are receiving this mail because: You are the assignee for the bug.

[GSoC] Project Requirements: Implement the FreeText annotation

the PDF format and also going through the poppler library. I would like to know if there are other requirements I need to fulfill in order to get more familiar with the project? Thanks and Regards, Dileep Sankhla ‌

[GSoC]

Hello, My name is Dileep Sankhla (IRC: robstat7) and I am eager to contribute to Okular this year in GSoC. I am well versed in C++ and have been programming in it for the past four years while using Qt for development for the past three months. In addition to it, I have been contributing

D11051: Remembering side navigation panel state

dileepsankhla updated this revision to Diff 28694. dileepsankhla added a comment. Updating: Remembering side navigation panel state Removed the extra whitespace. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11051?vs=28693=28694 BRANCH master

[okular] [Bug 344599] Thumbnails sidebar always open when okular starts

https://bugs.kde.org/show_bug.cgi?id=344599 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

D11051: Remembering side navigation panel state

dileepsankhla added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11051 To: dileepsankhla, #okular Cc: #okular, michaelweghorn, ngraham, aacid

D11051: Remembering side navigation panel state

dileepsankhla created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. dileepsankhla requested review of this revision. REVISION SUMMARY Every time Okular starts, one of the items of the side navigation panel is open. There is no

Which vim shortcuts should be currently implemented?

Hi, I'm working on the feature request[0] 342927 that demands to introduce other vim like shortcuts in okular but I think there is no any single comment from the mentor itself and there are different suggestions. Hence I want to know which keys should be implemented in the patch? I need to work

[okular] [Bug 342927] More Vim-like shortcuts

https://bugs.kde.org/show_bug.cgi?id=342927 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added Status|UNCONFIRMED |CON

[okular] [Bug 342927] More Vim-like shortcuts

https://bugs.kde.org/show_bug.cgi?id=342927 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

[okular] [Bug 350366] Tree view search bar in left side bar is not searching root items of the tree view.

https://bugs.kde.org/show_bug.cgi?id=350366 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

D10249: Option to exit after printing

dileepsankhla updated this revision to Diff 28360. dileepsankhla added a comment. Updating D10249 : Option to exit after printing Removed the autotest and just updated the `serializedOptions` parameters. REPOSITORY R223 Okular CHANGES SINCE LAST

D10249: Option to exit after printing

dileepsankhla added a comment. Oops! As I was getting errors in the autotests/mainshelltest.cpp file while `make` okular, I assumed the autotest didn't compile and build successfully. I also assumed the `make` command runs the tests too. Now running with ./autotests/mainshelltest, I got

Re: Better way to make the annotation windows scrollable with the document

Thank you so much Albert. ‌ On Tue, Feb 27, 2018 at 3:44 AM, Albert Astals Cid <aa...@kde.org> wrote: > El dilluns, 26 de febrer de 2018, a les 11:50:02 CET, Dileep Sankhla va > escriure: > > Thank you so much Oliver. Due to lack of insight about the bugs, I'm > unable &

Re: Better way to make the annotation windows scrollable with the document

today. Scrolling annotation windows could > be a nice > thing to have, but nobody seems to need them urgently. At least not me. > > So maybe you could pick an easier issue to get you started? > > Many thanks, and best regards, > Oliver > > On 25.02.2018 06:27, Dileep

Better way to make the annotation windows scrollable with the document

Hello, I'm heading into Okular feature request 388450 where the annotation windows should scroll along with the document to increase readability. I'm not getting a way to achieve so. As annotation window is a QWidget, should there be a way to stick it to the pageview or should it move up or down

[okular] [Bug 388450] Popup-note annotations don't scroll with the document

https://bugs.kde.org/show_bug.cgi?id=388450 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC|sankhla.dilee...@gmail.com | -

[okular] [Bug 388532] Clicking a popup note icon should bring the popup note to the top

https://bugs.kde.org/show_bug.cgi?id=388532 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

D10249: Option to exit after printing

dileepsankhla added a comment. No I ran the tests too and it was a success. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10249 To: dileepsankhla, aacid, #okular, ngraham Cc: ltoscano, ngraham, aacid, #okular, michaelweghorn

Re: Need help regarding heading into the Okular Feature: 388450

Thank you so much. The information made me understand okular much better and its internals too. I will try my best to form a solution and if any problem, will contact the developers here or IRC. Thank you once again. Dileep ‌ On Sat, Feb 17, 2018 at 4:13 PM, Tobias Deiminger

Need help regarding heading into the Okular Feature: 388450

Hello devs, I have spent the past three days in heading into this feature request [1] regarding scrolling the annotations along with the scrollbar and I have been finding out how to unfix the position of the annotation window that remains fixed to its position while scrolling the pageview. I'm

Re: Can I work on an issue that is the basis of a GSoC project?

Thank you so much. It really helped. ‌ On Wed, Feb 14, 2018 at 2:33 PM, Oliver Sander <oliver.san...@tu-dresden.de> wrote: > On 14.02.2018 03:22, Dileep Sankhla wrote: > > Thank you so much. Do you also mean I can send the proposal to the same > project while working on the

Re: Can I work on an issue that is the basis of a GSoC project?

Thank you so much. Do you also mean I can send the proposal to the same project while working on the same issue during this pre-application duration and may also have sent a patch for the review? ‌ On Wed, Feb 14, 2018 at 2:42 AM, Oliver Sander wrote: > Hi

Can I work on an issue that is the basis of a GSoC project?

Hello Okular Developers, I have been contributing to Okular for the last two weeks and this application product and its key interesting issues intrigue me the most. I love Okular from the very beginning of using KDE desktop on my Arch Linux and realizing the missing key features made me selecting

[okular] [Bug 387834] Okular does not display replies to "sticky notes"

https://bugs.kde.org/show_bug.cgi?id=387834 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

D10249: Option to exit after printing

dileepsankhla updated this revision to Diff 27086. dileepsankhla added a comment. Updating D10249 : Option to exit after printing Tried my best to edit the data driven tests by adding appropriate data to the table using QTest::newRow function.

D10249: Option to exit after printing

dileepsankhla marked an inline comment as done. dileepsankhla added a comment. @aacid I have talked about using std::exit instead of QCoreApplication::exit here : https://phabricator.kde.org/D10249#200260 With that, I want to add QCoreApplication::exit does nothing if the event loop is

[okular] [Bug 388450] Popup-note annotations don't scroll with the document

https://bugs.kde.org/show_bug.cgi?id=388450 --- Comment #6 from Dileep Sankhla <sankhla.dilee...@gmail.com> --- Should the annotation window allow to be dragged outside of the viewport by using the mouse left button unless it is the border of the pdf view? I have almost got the idea and

[okular] [Bug 388450] Popup-note annotations don't scroll with the document

https://bugs.kde.org/show_bug.cgi?id=388450 Dileep Sankhla <sankhla.dilee...@gmail.com> changed: What|Removed |Added CC||sankhla

D10249: Option to exit after printing

dileepsankhla updated this revision to Diff 26778. dileepsankhla added a comment. Updating https://phabricator.kde.org/D10249: Option to exit after printing renamed isError variable to success and changed the option with -print-and-exit. REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D10249: Option to exit after printing

dileepsankhla updated this revision to Diff 26608. dileepsankhla marked an inline comment as done. dileepsankhla added a comment. Updating https://phabricator.kde.org/D10249: Option to exit after printing Initialized "isError" with false at the time of declaration. REPOSITORY R223 Okular

D10249: Option to exit after printing

dileepsankhla updated this revision to Diff 26550. dileepsankhla added a comment. Updating https://phabricator.kde.org/D10249: Option to exit after printing local variable to slotPrint function REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D10249: Option to exit after printing

dileepsankhla updated this revision to Diff 26547. dileepsankhla added a comment. Updating https://phabricator.kde.org/D10249: Option to exit after printing I was trying to get rid of extern keyword while declaring "isError" inside the namespace of the header file. Hence I declared it as

  1   2   >