[okular] [Bug 439262] Inline images are not displayed

2021-06-28 Thread Friedrich W. H. Kossebau
https://bugs.kde.org/show_bug.cgi?id=439262 Friedrich W. H. Kossebau changed: What|Removed |Added Product|markdownpart|okular Assignee|kosse

T10243: Some KDE applications could use better icons

2020-07-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. @tosta hi. thanks for your artwork proposals, they show you are skilled, makes me jealous :) When it comes to designing icons, it is not only about art though, but also about feasibility when used in context. Icons are less often used in the size you are

[okular] [Bug 407869] Okular KParts plugin steals space key events from shell

2020-05-30 Thread Friedrich W. H. Kossebau
https://bugs.kde.org/show_bug.cgi?id=407869 Friedrich W. H. Kossebau changed: What|Removed |Added CC||o...@senarclens.eu --- Comment #6

[okular] [Bug 407869] Okular KParts plugin steals space key events from shell

2020-05-30 Thread Friedrich W. H. Kossebau
https://bugs.kde.org/show_bug.cgi?id=407869 Friedrich W. H. Kossebau changed: What|Removed |Added CC||alex...@protonmail.com --- Comment

D28639: Use ecm_setup_qtplugin_macro_names

2020-04-07 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Moved to invent as https://invent.kde.org/kde/okular/-/merge_requests/152 REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D28639 To: kossebau, #okular, aacid Cc: aacid, okular-devel, johnzh, andisa,

D28639: Use ecm_setup_qtplugin_macro_names

2020-04-06 Thread Friedrich W. H. Kossebau
kossebau edited the test plan for this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D28639 To: kossebau, #okular Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, ngraham, darcyshen, aacid

D28639: Use ecm_setup_qtplugin_macro_names

2020-04-06 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. kossebau requested review of this revision. REVISION SUMMARY Avoids all the explicit boilerplate needed, ensures the dependency on the JSON file ia also

T10243: Some KDE applications could use better icons

2020-01-24 Thread Friedrich W. H. Kossebau
kossebau added a comment. (also, do kwin/plasma actually see the desktop file in the custom install prefix, e.g. by being started with respective paths in the respective env vars?) TASK DETAIL https://phabricator.kde.org/T10243 To: kossebau Cc: johanneszarl, Leon0402, IohannesPetros,

D26163: Install okularpart into plugins/kf5/parts/

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. Oh, and the Calligra plugins for Okular will also break, as they also have `X-KDE-Library=okularpart`, given they also work by being subplugins to the Okular KPart, so need to reference it, REPOSITORY R223 Okular REVISION DETAIL

D26163: Install okularpart into plugins/kf5/parts/

2019-12-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. At least Kile tries to load the Okular KPart via the binary name and using the constructor of KPluginLoader which only searches in the normal Qt plugin paths, not subdirs, Possibly there are others who copied that code. No idea what to do, besides promoting the use

T10243: Some KDE applications could use better icons

2019-09-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. In T10243#201331 , @ngraham wrote: > cold, barren, and excessively harsh and masculine. But you also don't go overboard on ornamentation or else it feels smothering, claustrophobic, and excessively feminine. I

T10243: Some KDE applications could use better icons

2019-09-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. Sounds like there should be some additional "Generic icon" entry in the app/desktopfile metadata, so people can decide whether they want to see brand-based icons or function-based icons, like there is with "Name" & "Generic Name". TASK DETAIL

[okular] [Bug 407869] Okular KParts plugin steals space key events from shell

2019-05-23 Thread Friedrich W. H. Kossebau
https://bugs.kde.org/show_bug.cgi?id=407869 Friedrich W. H. Kossebau changed: What|Removed |Added Summary|Markdown preview disables |Okular KParts plugin steals

[okular] [Bug 407869] Markdown preview disables adding spaces

2019-05-23 Thread Friedrich W. H. Kossebau
https://bugs.kde.org/show_bug.cgi?id=407869 Friedrich W. H. Kossebau changed: What|Removed |Added Ever confirmed|0 |1 Component|plugin-preview

D11250: Expose presentation via MPRIS to rich remote controllers

2019-02-21 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. Herald added a subscriber: okular-devel. No personal need anymore, and seemingly no-one else interested, thus discarding. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D11250 To: kossebau, #okular Cc:

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-19 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 29945. kossebau added a comment. extend MprisThumbnailStore to support updates of thumbnails REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11250?vs=29681=29945 BRANCH addmprisservice REVISION DETAIL

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-18 Thread Friedrich W . H . Kossebau
kossebau added inline comments. INLINE COMMENTS > aacid wrote in dbusabstractadaptor.h:32 > This seems like random glue code, wouldn't this make more sense in Qt or in > KF5? Possibly. Similar code working around the missing Qt feature is found across code. Actually one would expect this

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-17 Thread Friedrich W . H . Kossebau
kossebau added a comment. So far got a few comments about this being a nice idea in general, and one already about something in the code. So far all positive. Now, where are the negative ones, there must be some :) If not or even then, I hope for some good people for some further detailed

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-16 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 29681. kossebau added a comment. - always create mpris service, not only with Q_OS_LINUX - minor code clean-ups REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11250?vs=29333=29681 BRANCH addmprisservice REVISION

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-16 Thread Friedrich W . H . Kossebau
kossebau added a comment. In D11250#227259 , @pino wrote: > Please do not restrict it to `Q_OS_LINUX`, as there is no Linux-only code (nor the feature is specific to Linux in any way). Good hint, possibly was misguided by the special

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-12 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 29333. kossebau added a comment. Register objects before registering the service name, this should help Plasma MPRIS controllers & others to use the service instantly when the name is registered REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-12 Thread Friedrich W . H . Kossebau
kossebau added a comment. Two issues yet, one in code and one possibly in Plasma: a) the same okular process can have multiple documents open and thus run multiple presentations at the same time. The current code will only expose the first presentation to mpris. No idea yet how to handle

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-12 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 29326. kossebau added a comment. - added thumbnail support - fixed unregistering from DBus when presentationwidget is only closed, not deleted REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11250?vs=29286=29326

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-11 Thread Friedrich W . H . Kossebau
kossebau added a comment. Right now trying to also get preview of the current page implemented, by storing the PixmapRequest result in a temporary file and passing that in the metadata as mpris:artUrl. But not sure if I make it tonight, and already useful as is, so this upload for first

D11250: Expose presentation via MPRIS to rich remote controllers

2018-03-11 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Okular. Restricted Application added a project: Okular. kossebau requested review of this revision. REVISION SUMMARY When going into presentation mode, a D-Bus object is created that implements MPRIS spec and exposes control to the

[okular] [Bug 386600] Okularpart renders markdown as regular text

2017-11-07 Thread Friedrich W . H . Kossebau
https://bugs.kde.org/show_bug.cgi?id=386600 --- Comment #3 from Friedrich W. H. Kossebau <kosse...@kde.org> --- I do not have Okular from master branch, so cannot test this myself for Markdown documents. But the KParts plugin used should know about the mimetype, it is passed both when l

D7431: Add RTF support to Okular

2017-08-23 Thread Friedrich W . H . Kossebau
kossebau added a comment. @aacid poked me as well to look at this., so I give in, as actually I might indeed be the one knowing most about this code still. Sadly out of loop with Calligra & Okular, not even build setups. But what I remember from the time when I hacked on the Okular plugins

[Okular-devel] [calligrastage] [Bug 340200] Okular crashes on exit after viewing a ODF presentation

2014-10-21 Thread Friedrich W . H . Kossebau
https://bugs.kde.org/show_bug.cgi?id=340200 Friedrich W. H. Kossebau kosse...@kde.org changed: What|Removed |Added Product|okular |calligrastage

[Okular-devel] [calligrastage] [Bug 340200] Okular crashes on exit after viewing a ODF presentation

2014-10-21 Thread Friedrich W . H . Kossebau
https://bugs.kde.org/show_bug.cgi?id=340200 Friedrich W. H. Kossebau kosse...@kde.org changed: What|Removed |Added Assignee|okular-devel@kde.org|kosse...@kde.org

[Okular-devel] API change of Generator::generateDocumentSynopsis, documentation needed

2014-09-09 Thread Friedrich W. H. Kossebau
Hi Albert, recently the API of Okular::Generator was changed, the signature of generateDocumentSynopsis(...) changed from virtual const DocumentInfo * generateDocumentInfo(); to virtual DocumentInfo generateDocumentInfo( const QSetDocumentInfo::Key keys ) const;

Re: [Okular-devel] API change of Generator::generateDocumentSynopsis, documentation needed

2014-09-09 Thread Friedrich W. H. Kossebau
Am Dienstag, 9. September 2014, 11:45:47 schrieb Albert Astals Cid: El Dimarts, 9 de setembre de 2014, a les 11:09:48, Friedrich W. H. Kossebau va escriure: Hi Albert, recently the API of Okular::Generator was changed, the signature of generateDocumentSynopsis(...) changed from

[Okular-devel] Review Request 120113: Adapt docu of generators to generateDocumentInfo() method change

2014-09-09 Thread Friedrich W. H. Kossebau
Description --- As offered by email :) Diffs - Mainpage.dox f091e99 Diff: https://git.reviewboard.kde.org/r/120113/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Okular-devel mailing list Okular-devel@kde.org https

Re: [Okular-devel] Review Request 120113: Adapt docu of generators to generateDocumentInfo() method change

2014-09-09 Thread Friedrich W. H. Kossebau
marked as submitted. Review request for Okular and Albert Astals Cid. Repository: okular Description --- As offered by email :) Diffs - Mainpage.dox f091e99 Diff: https://git.reviewboard.kde.org/r/120113/diff/ Testing --- Thanks, Friedrich W. H. Kossebau

Re: [Okular-devel] Calligra-based generators for ODT/OTT and ODP/OTP, priorities?

2014-06-15 Thread Friedrich W. H. Kossebau
Am Donnerstag, 5. Juni 2014, 10:29:17 schrieb Friedrich W. H. Kossebau: Hi, both a head-up, but also a question: I am currently pushing another Okular generator plugin to Calligra mainline, for ODT/OTT (you might know that there is already one generator plugin in Calligra for ODP

Re: [Okular-devel] Review Request 109115: Make observer.h installable

2013-02-25 Thread Friedrich W. H. Kossebau
/master/entry/extras/okularodpgenerator/OkularOdpGenerator.cpp#L125 Cheers Friedrich - Friedrich W. H. Kossebau On Feb. 23, 2013, 10:25 p.m., Albert Astals Cid wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: [Okular-devel] About Calligra Active and what it should intend to be

2011-10-10 Thread Friedrich W. H. Kossebau
Hi, may I give a comment as outsider on the issue (also cross-posting okular- devel, please follow-ups only to calligra-de...@kde.org) Mardi, le 4 octobre 2011, à 08:58, Inge Wallin a écrit: On Monday, October 03, 2011 16:24:21 Vít Pelčák wrote: 2011/10/3 Shantanu Tushar Jha

Re: [Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2011-08-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102453/ --- (Updated Aug. 27, 2011, 11:57 a.m.) Review request for Okular. Changes

[Okular-devel] Review Request: make core/document.cpp compile without warning when QT_ASCII_CAST_WARNINGS is set

2011-08-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102453/ --- Review request for Okular. Summary --- Or: flood code with