Re: refactoring in pageview class

2017-02-14 Thread Jonathan Schultz
OK I stand corrected about other applications. But still must agree with hb that Okular makes it difficult to know how to get out of full-screen. Sure, people who are committed users of KDE probably know Ctrl-Shift-F, but Okular is really a basic application that is widely used by beginners

Re: refactoring in pageview class

2017-02-13 Thread Jonathan Schultz
My personal interest stems from having forked okular for my own project (https://github.com/jschultz/okular-tagging), You've relicensed all of the code to GPL-3 ? Not really thought about it, just used GPL-3 as a default licence. Not sure that's illegal but for sure makes cherry-picking

Re: refactoring in pageview class

2017-02-13 Thread Jonathan Schultz
Hear hear! PageView really is a a mess, I presume because it has been repeatedly added to as okular has grown from kpdf and never been subject to a proper clean-up. Notably (and in addition to the PageView/PageViewPrivate confusion you mention), it has massively long functions (eg

Re: Review Request 127366: Resize annotations

2017-01-26 Thread Jonathan Schultz
> On April 8, 2016, 7:52 a.m., Jonathan Schultz wrote: > > Sorry I've been meaning to test this a bit more and only got to it today. > > > > I have a couple of minor comments: > > > > 1. The corner boxes do not seem to work - even though the mouse icon >

Re: Review Request 127366: Resize annotations

2017-01-26 Thread Jonathan Schultz
> On April 8, 2016, 7:52 a.m., Jonathan Schultz wrote: > > Sorry I've been meaning to test this a bit more and only got to it today. > > > > I have a couple of minor comments: > > > > 1. The corner boxes do not seem to work - even though the mouse icon >

Re: PDFium plugin

2017-01-17 Thread Jonathan Schultz
, Jonathan Schultz wrote: Looks interesting. How does it compare (performance, features, etc.) with the Poppler plugin? Any chance you could save us the bother of building ourselves and post a link to an executable? Cheers, Jonathan On 18/01/17 03:30, Gilbert Assaf wrote: Hi all, I worked

Re: PDFium plugin

2017-01-17 Thread Jonathan Schultz
Looks interesting. How does it compare (performance, features, etc.) with the Poppler plugin? Any chance you could save us the bother of building ourselves and post a link to an executable? Cheers, Jonathan On 18/01/17 03:30, Gilbert Assaf wrote: Hi all, I worked on an okular pdf plugin

Re: Review Request 127366: Resize annotations

2016-10-27 Thread Jonathan Schultz
there something that you think should be done soon, or as next change? > If not I'll just go on with what comes to my mind, and will probably update > here in 1..2 weeks. > > Btw., sorry, I don't know how inline quote here (using the reviewboard > webinterface). > >

Re: [Okular-devel] Review Request 127366: Resize annotations

2016-04-07 Thread Jonathan Schultz
t merging? I think you are way ahead of me, and I am looking forward to going over your patch to learn how to do a few things. That said, I have contributed one tiny review request: https://git.reviewboard.kde.org/r/127496/ but haven't had any response yet. - Jonathan Schultz On April 5, 2016, 8:02

Re: [Okular-devel] Review Request 127496: Normal right click processing in text selection mode if no text has been selected.

2016-03-25 Thread Jonathan Schultz
--- Thanks, Jonathan Schultz ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 127496: Normal right click processing in text selection mode if no text has been selected.

2016-03-25 Thread Jonathan Schultz
that contains the comment '// If nothing else going on, process right click as normal' Diffs - ui/pageview.cpp 3ebf7dc Diff: https://git.reviewboard.kde.org/r/127496/diff/ Testing --- Thanks, Jonathan Schultz ___ Okular-devel mailing list

Re: [Okular-devel] Review Request 127366: Resize annotations

2016-03-21 Thread Jonathan Schultz
> On March 14, 2016, 12:46 a.m., Albert Astals Cid wrote: > > Looks very nice for a start, congratulations. > > > > > Reconsider UI, esp. the Ctrl-way to get focus. Is there something in the > > > KDE HIG about it? > > > > It's not too bad, i think it would be ok, but if you awnt to try

Re: [Okular-devel] Building on Windows

2016-03-10 Thread Jonathan Schultz
Thank you both Albert and Thomas for helping with this. I'm neither an expert in Okular nor in KDE for Windows. But I am working on a project that involves adding functionality to Okular and is worthless if it can't be built for Windows, so I do have an interest in getting this to work. So I

Re: [Okular-devel] Building on Windows

2016-03-07 Thread Jonathan Schultz
Yeah removing visibility doens't seem like the proper fix to be honest. Makes sense. Maybe you can bring this to the kde windows list in case more people there can help? I tried that list first - it was Thomas who suggested I bring it also to the okular-devel list. Cheers, Albert

[Okular-devel] Building on Windows

2016-03-06 Thread Jonathan Schultz
Hello all, On trying, and eventually succeeding in building Okular version 1.0.0 under KF 5.5.0 and Windows 7, I found a few points (with the help of Thomas Friedrichsmeier on the kde-windows list) that probably need attention. Starting with the simplest and least difficult: 1. Line 14 of

Re: [Okular-devel] Consistency in user interface

2016-02-28 Thread Jonathan Schultz
On 29/02/16 10:08, Albert Astals Cid wrote: El Monday 29 February 2016, a les 09:13:10, Jonathan Schultz va escriure: They operate differently because they do different things, after drawing the rectange there's nothing else you want to do so the menu is triggered immediately. I differ

Re: [Okular-devel] Consistency in user interface

2016-02-28 Thread Jonathan Schultz
They operate differently because they do different things, after drawing the rectange there's nothing else you want to do so the menu is triggered immediately. I differ with this interpretation in several ways: 1. On what basis do we know 'there is nothing else you want to do'? Some useful

[Okular-devel] Consistency in user interface

2016-02-25 Thread Jonathan Schultz
Hello all, I hope I'm not wading into a discussion about UI without understanding the background here, but is there any good reason for the different behaviour of Okular depending on the selection modes? That is, in 'normal' (ie rectangle) selection mode, a menu of options appears

Re: [Okular-devel] Advice about adding functionality to Okular

2015-11-24 Thread Jonathan Schultz
Hi Albert, What do you mean "code that section"? Sorry - I should have explained what Qualitative Data Analysis refers to by 'code'. What it means is to 'tag' a document section by associating with a 'code' that is in turn linked to an externally maintained database of codes with their own

Re: [Okular-devel] Advice about adding functionality to Okular

2015-11-24 Thread Jonathan Schultz
of this future maintenance. Your answer gives me some indication of how I might go about this so I will take it from there for now. Thanks for your help. Cheers, Jonathan On 25/11/15 11:14, Albert Astals Cid wrote: El Wednesday 25 November 2015, a les 10:24:34, Jonathan Schultz va escriure: Hi Albert

[Okular-devel] Advice about adding functionality to Okular

2015-11-23 Thread Jonathan Schultz
Hello folks, Could I ask for any opinions on how best to approach adding functionality to Okular? In brief, what I want to do is use Okular as an engine for coding/tagging sections (text or rectangular) for Qualitative Data Analysis (QDA). What this means is that when a section of a document is