[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 Albert Astals Cid changed: What|Removed |Added CC||patrick.f...@fbc.ch --- Comment #26 fro

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #25 from Niels Ole Salscheider 2011-09-22 18:39:53 --- Seems to be right now. -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. _

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #24 from Albert Astals Cid 2011-09-22 18:21:46 --- Thanks for the review, i actually had a look at the code in the destructor and for some reason overlooked the QFile::remove there and then m_filelist did not make any sense anymore and

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #23 from Niels Ole Salscheider 2011-09-22 18:06:21 --- Thanks. I have just noticed that you removed "m_filelist". This way, the temporary files will not get deleted on destruction of the annotation window. Is this a good idea? -- Co

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 Albert Astals Cid changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Version Fixed In|

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 Niels Ole Salscheider changed: What|Removed |Added Attachment #63726|0 |1 is obsolete|

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #21 from Niels Ole Salscheider 2011-09-22 09:44:23 --- I think it is best to always display the button so that the user gets feedback why his code does not work. I attached a patch for that. -- Configure bugmail: https://bugs.kde.org

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #20 from Niels Ole Salscheider 2011-09-22 09:43:19 --- Created an attachment (id=63851) --> (http://bugs.kde.org/attachment.cgi?id=63851) adds support for latex annotations to the annotation window -- Configure bugmail: https://bugs

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-22 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 Niels Ole Salscheider changed: What|Removed |Added Attachment #63725|0 |1 is obsolete|

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-21 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #18 from Niels Ole Salscheider 2011-09-22 06:28:15 --- You are right, this should be changed. There are two possibilities: Either do not display the button at all if latexis not installed or do so but show a message box saying "latex

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-21 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #17 from Albert Astals Cid 2011-09-21 23:09:57 --- I'd like a bit more of user feedback in case latex is not installed, as far as i can see now what would happen is that he clicks the button and gets nothing? -- Configure bugmail: ht

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-17 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 Niels Ole Salscheider changed: What|Removed |Added Attachment #63564|0 |1 is obsolete|

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-17 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #15 from Niels Ole Salscheider 2011-09-17 12:23:27 --- Created an attachment (id=63726) --> (http://bugs.kde.org/attachment.cgi?id=63726) adds support for latex annotations to the annotation window -- Configure bugmail: https://bugs

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-17 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 Niels Ole Salscheider changed: What|Removed |Added Attachment #63563|0 |1 is obsolete|

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-17 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #13 from Niels Ole Salscheider 2011-09-17 12:22:06 --- While it would be nice to save the rendered formula to the pdf, I think it's something we can still implement once okular has support for saving annotations to it. I created a pat

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-15 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #12 from Jonathan Verner 2011-09-15 11:13:53 --- Sorry, I misinterpreted your comment. But this is good news :-) I will have to look at poppler again. (In reply to comment #11) > > As Albert said, currently poppler (the pdf libra

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #11 from Albert Astals Cid 2011-09-15 11:06:51 --- As Albert said, currently poppler (the pdf library used by okular) doesn't support saving annotations back to the file. I did not say that at all. I said Okular doesn't do it

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-15 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #10 from Jonathan Verner 2011-09-15 09:50:54 --- (In reply to comment #8) > Is it a good idea to include a rendered formula? This way, we cannot adjust > font size and color easily... As Albert said, it would have the benefit that oth

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-14 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #9 from Albert Astals Cid 2011-09-14 18:03:07 --- Including the rendered formula has the benefit that other programs (i.e. Acrobat) can render the formula too, but that obviously depends on another missing feature that is saving annota

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-14 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 Niels Ole Salscheider changed: What|Removed |Added CC||niels_ole@salscheider-onlin

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-12 Thread Jonathan Verner
https://bugs.kde.org/show_bug.cgi?id=281813 Jonathan Verner changed: What|Removed |Added CC||jonathan.ver...@gmail.com --- Comment #7

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #6 from Albert Astals Cid 2011-09-11 19:37:01 --- What i would add is something that detects if there is valid latex code between $$ and then adds a status message on the top saying something like "This comment seems to have latex form

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-11 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #5 from Niels Ole Salscheider 2011-09-11 18:13:27 --- I think most annotations won't include $$valid_latex_code$$ if it is not on purpose but you are right that we cannot be sure about that. Maybe a solution would be not to alter the

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #4 from Albert Astals Cid 2011-09-11 17:51:56 --- Oh, i see what you did is that any annotation out there with $$ is rendered with latex, do not think it is a good idea, i am sure there are files out there with $$ in the text and they

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-11 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #3 from Niels Ole Salscheider 2011-09-11 17:34:06 --- I thought about that, too. However, there is no way to store formulas in PDF annotations as far as I know. So the best one can do is to store them as plain Latex-style code (as I di

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #2 from Albert Astals Cid 2011-09-11 17:22:26 --- This feature goes a bit against the fact that we are trying to save our annotations to file in case of PDF that support annotations, the problem is that this is not supported as far as

[Okular-devel] [Bug 281813] Add support for LaTeX formulas in annotations

2011-09-11 Thread Niels Ole Salscheider
https://bugs.kde.org/show_bug.cgi?id=281813 --- Comment #1 from Niels Ole Salscheider 2011-09-11 16:50:36 --- Created an attachment (id=63564) --> (http://bugs.kde.org/attachment.cgi?id=63564) Screenshot -- Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email --- You are r