Re: [Okular-devel] pan mouse icon fix

2010-03-25 Thread Albert Astals Cid
A Dijous, 25 de març de 2010, Glen Kaukola va escriure: Hey, Here's the fix for the pan icon showing up on a double click. Seems to me the timer may last a bit too long though. Yeah? No? Anyway, criticism is certainly appreciated. Comments on the patch: * You should make the timer

Re: [Okular-devel] pan mouse icon fix

2010-03-25 Thread Glen Kaukola
Comments on the patch: * You should make the timer single shot, no need to get the timer called again and again Done. * If when dragging happens the timer is still running (dragging happened earlier than Application::doubleClickInterval() + 10) you should stop the timer and call

Re: [Okular-devel] pan mouse icon fix

2010-03-25 Thread Albert Astals Cid
A Dijous, 25 de març de 2010, Glen Kaukola va escriure: Comments on the patch: * You should make the timer single shot, no need to get the timer called again and again Done. * If when dragging happens the timer is still running (dragging happened earlier than

[Okular-devel] pan mouse icon fix

2010-03-24 Thread Glen Kaukola
Hey, Here's the fix for the pan icon showing up on a double click. Seems to me the timer may last a bit too long though. Yeah? No? Anyway, criticism is certainly appreciated. I also noticed what seems to be a bug with pop up notes. When my zoom is at 100% the whole of my document fits in