This revision was automatically updated to reflect the committed changes.
Closed by commit R223:18d404c3ee97: Support additional widget actions in PDF
Forms (authored by aheinecke, committed by aacid).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
aheinecke added inline comments.
INLINE COMMENTS
> aacid wrote in formwidgets.cpp:1078
> Can you please add that explanation either as a comment somewhere in the code
> or as part of the git commit? It'll make it easier to find next time someone
> looks at the code and wonders why it has an
aacid added inline comments.
INLINE COMMENTS
> aheinecke wrote in CMakeLists.txt:97
> Out of curiosity: Why is this and the other "check compiles" tests for
> released versions of poppler not:
>
> if (Poppler_VERSION VERSION_GREATER "0.64.99")
> set (HAVE_POPPLER_0_65 1)
> endif()
In
aheinecke updated this revision to Diff 35015.
aheinecke added a comment.
Don't eat the MouseRelease event if it is outside the widget
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12665?vs=35014=35015
REVISION DETAIL
https://phabricator.kde.org/D12665
aheinecke updated this revision to Diff 35014.
aheinecke added a comment.
- Fixed precedence of activation action over mouse release action.
- Only activate mouse released if release is inside the widget.
- Fixed check for Poppler 0.65
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
aheinecke planned changes to this revision.
aheinecke added inline comments.
INLINE COMMENTS
> aacid wrote in formwidgets.cpp:1073
> This still triggers if you press the button inside a form, move the mouse
> outside the form and release, not sure this is "according to spec", it says
> "An
aacid added inline comments.
Restricted Application added a subscriber: okular-devel.
INLINE COMMENTS
> CMakeLists.txt:86
>l->nextLinks();
> + f->additionalAction(Poppler::Annotation::CursorEnteringAction);
> }
You need to move this to a whole new block since it has to be in a check for
aheinecke updated this revision to Diff 33810.
aheinecke added a comment.
- Removed a spurious emit when calling signalAction.
- Updated to API of update poppler patch.
- Fixed leaking the additional actions.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
aheinecke updated this revision to Diff 33630.
aheinecke added a comment.
Changed mouseRelease event to fallback to activationAction
Some formatting.
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12665?vs=33497=33630
BRANCH
master
REVISION DETAIL
aheinecke planned changes to this revision.
aheinecke added a comment.
MouseReleased indeed needs some different handling. It only works in the
tests for the Button's as they trigger the "MouseReleased" action as the
activation action.
As we need a generic way to trigger activation
aheinecke created this revision.
aheinecke added a reviewer: Okular.
aheinecke added a project: Okular.
aheinecke requested review of this revision.
REVISION SUMMARY
This adds support for actions associated with form fields
through corresponding annotation widgets.
TEST PLAN
Still needs a
11 matches
Mail list logo
