D12825: Fix recalculating forms twice

This revision was automatically updated to reflect the committed changes. Closed by commit R223:3ae2ae06e810: Fix recalculating forms twice (authored by aheinecke, committed by aacid). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12825?vs=35008=35029

D12825: Fix recalculating forms twice

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aheinecke updated this revision to Diff 35008. aheinecke added a comment. Include duplicate cals from editFormList and editFormCombo REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12825?vs=33987=35008 REVISION DETAIL https://phabricator.kde.org/D12825

D12825: Fix recalculating forms twice

aheinecke added a comment. I'll upload a new patch. (sorry for delaying my okular work, I'm currently still a bit swamped by the efail hype) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aacid added a comment. Will you upload an updated patch or should i just do it ? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aheinecke added a comment. Ugh, Sorry for overlooking these. Yes. They also call notifyFormChanges in their redo. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aacid added a comment. Should we remove the recalculateForms from editFormList and editFormCombo too then? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825 To: aheinecke, aacid Cc: okular-devel, ngraham, aacid

D12825: Fix recalculating forms twice

aheinecke added a comment. To clarify: d->m_undoStack->push( uc ); results in: EditFormTextCommand::redo() https://cgit.kde.org/okular.git/tree/core/documentcommands.cpp#n513 which calls: m_docPriv->notifyFormChanges( m_pageNumber );

D12825: Fix recalculating forms twice

aheinecke added a comment. I did not know when adding f0a80a67 that pushing to the undoStack automatically executes the redo function. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12825

D12825: Fix recalculating forms twice

aheinecke created this revision. aheinecke added a reviewer: aacid. Restricted Application added a project: Okular. Restricted Application added a subscriber: okular-devel. aheinecke requested review of this revision. REVISION SUMMARY As a side effect of f0a80a67