This revision was automatically updated to reflect the committed changes.
Closed by commit R223:cb691f70dcb0: Fix some clazy warning (authored by
mlaurent).
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20832?vs=57003&id=58700
REVISION DETAIL
https://phabri
nicolasfella added inline comments.
INLINE COMMENTS
> aacid wrote in parttest.cpp:258
> QStringliteral is broken on windows with non ascii chars, please turn this
> back to QString::fromUtf8 so tests don't start failing.
Might be worth a comment so the next person knows?
REPOSITORY
R223 Okul
aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.
Please revert the QStringLiteral with utf8 inside, after that you can commit
if you're convince there will be no regressions :)
INLINE COMMENTS
> parttest.cpp:258
> +QTest::newRow("non-u
mlaurent added a comment.
Ping ?
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent added a comment.
Ok albert send me an email in private :)
he will look at it in several days :)
tha,ks :)
(I didn't have internet access before to see his email :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-d
mlaurent added a comment.
new ping :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent added a comment.
ping ? :)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent updated this revision to Diff 57003.
mlaurent added a comment.
Fix comment gave by albert
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D20832?vs=56998&id=57003
BRANCH
fix_some_clazy_warning (branched from master)
REVISION DETAIL
https://phabr
aacid added inline comments.
INLINE COMMENTS
> fileprinter.h:92
> */
> -static int printFile( QPrinter &printer, const QString file,
> +static int printFile( QPrinter &printer, const QString &file,
>QPrinter::Orientation documentOrientation,
This breaks
mlaurent added a reviewer: aacid.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20832
To: mlaurent, aacid
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
mlaurent created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
fix clazy warning
REPOSITORY
R223 Okular
BRANCH
fix_some_clazy_warning (branched from master)
REVISION DETAIL
https://pha
11 matches
Mail list logo
