D20868: Support '#page=' fragment to open at page

michaelweghorn abandoned this revision. michaelweghorn added a comment. In D20868#615357 , @aacid wrote: > Please move as a Merge Request in https://invent.kde.org/kde/okular > > We have pre-commit CI and lots of checks including clazy and

D20868: Support '#page=' fragment to open at page

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. Please move as a Merge Request in https://invent.kde.org/kde/okular We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place

D20868: Support '#page=' fragment to open at page

aacid added a comment. needs autotest REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20868 To: michaelweghorn, #okular Cc: aacid, davidhurka, okular-devel, joaonetto, tfella, ngraham, darcyshen

D20868: Support '#page=' fragment to open at page

davidhurka added a comment. How about the following approach (not tested)? This way, other parameters (like `nameddest`) wouldn’t break it and can be added later. const QString fragment = url.fragment(QUrl::EncodeDelimiters); bool gotOpenPageNumber = false; int

D20868: Support '#page=' fragment to open at page

michaelweghorn created this revision. michaelweghorn added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. michaelweghorn requested review of this revision. REVISION SUMMARY Support the '#page=' fragment to specify which page to open the document