D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D21971 . REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis, aacid Cc: davidhurka, aacid, okular-devel, johnzh,

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

aacid added a comment. Personally I don't really about the button order, what i care is about the shortcuts i've been using for 10 years not changing REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis, aacid Cc: davidhurka,

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

davidhurka added a comment. In D21635#475541 , @ngraham wrote: > The current keyboard shortcuts aren't a problem if we don't re-arrange the items in the Selection Mode toolbar button. Is it important to have a 3-4-5 order in that button

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham added a comment. In D21635#475539 , @aacid wrote: > But we're setting the menu here no? > > ac->setDefaultShortcut(d->aMouseTextSelect, Qt::CTRL + Qt::Key_3); > > > Can it just be still be a 4? The current keyboard

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

aacid added a comment. But we're setting the menu here no? ac->setDefaultShortcut(d->aMouseTextSelect, Qt::CTRL + Qt::Key_3); Can it just be still be a 4? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis, aacid Cc:

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham added a comment. In D21635#475496 , @aacid wrote: > *Do not change the shortcuts* In that case perhaps we should revert D21624 and then find another way to make the toolbar selection menu

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. *Do not change the shortcuts* REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis, aacid Cc: aacid, okular-devel,

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham added a comment. I am a little hesitant to do this since changing shortcuts is always a bit controversial and we'd be resetting people's muscle memory for these tools. :/ But I don't see any way around it unless we revert D21624 and find a

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R223 Okular BRANCH re-arrange-shortcuts-and-menu-items-accordingly (branched from master) REVISION DETAIL https://phabricator.kde.org/D21635 To: ngraham, #okular, #vdg, ndavis Cc: okular-devel,

D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement

ngraham created this revision. ngraham added reviewers: Okular, VDG. Herald added a project: Okular. Herald added a subscriber: okular-devel. ngraham requested review of this revision. REVISION SUMMARY D21624 re-arranged the ordering of the selection tools