aacid closed this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid, ervin, rkflx
Cc: #okular, michaelweghorn, ngraham, aacid
rkflx accepted this revision.
rkflx added a comment.
This revision is now accepted and ready to land.
Yay, `make test` looks much better now. (I still get some failures, but those
are also present without the patch – no time to bisect right now though, sorry.
Let's see what the CI says.)
aacid added a comment.
In https://phabricator.kde.org/D9328#198101, @rkflx wrote:
> In https://phabricator.kde.org/D9328#197788, @aacid wrote:
>
> > In https://phabricator.kde.org/D9328#196555, @rkflx wrote:
> >
> > > >> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp,
aacid updated this revision to Diff 26246.
aacid edited the summary of this revision.
aacid removed subscribers: rkflx, ervin, michaelweghorn, ngraham.
aacid added a comment.
Fix crash found by the tests. Good we have them!
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
rkflx added a comment.
In https://phabricator.kde.org/D9328#197788, @aacid wrote:
> In https://phabricator.kde.org/D9328#196555, @rkflx wrote:
>
> > >> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp, line 129`
>
>
> Ok, i found how to reproduce too and this should be
aacid added a comment.
In https://phabricator.kde.org/D9328#196555, @rkflx wrote:
> >> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp, line 129`
(Happened two times already, but not everytime.)
> >
> > You got this one changing the size of the sidebar?
>
> In fact,
aacid updated this revision to Diff 26172.
aacid added a comment.
Fix issues with the text thread generator
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9328?vs=25991=26172
BRANCH
cancellable (branched from master)
REVISION DETAIL
rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.
>> 5. `ASSERT: "page()" in file okular/core/generator_p.cpp, line 129`
(Happened two times already, but not everytime.)
>
> You got this one changing the size of the sidebar?
aacid updated this revision to Diff 25991.
aacid marked an inline comment as done.
aacid added a comment.
cancel text extraction on document close
add const
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9328?vs=25886=25991
BRANCH
cancellable
aacid added a comment.
In https://phabricator.kde.org/D9328#195937, @rkflx wrote:
> Better, but not perfect yet ;)
>
> > There's no autotests in https://phabricator.kde.org/D8379, no?
>
> Seems I mixed it up with https://phabricator.kde.org/D8642, sorry.
>
> > 2. OOM killed
rkflx added inline comments.
INLINE COMMENTS
> rkflx wrote in generator_pdf.cpp:1177
> `const`
Any reason you changed it everywhere but here?
REPOSITORY
R223 Okular
BRANCH
cancellable (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid, ervin
Cc: rkflx,
rkflx added a comment.
Better, but not perfect yet ;)
> There's no autotests in https://phabricator.kde.org/D8379, no?
Seems I mixed it up with https://phabricator.kde.org/D8642, sorry.
> 2. OOM killed when changing sidebar size.
I suspect there are multiple issues
aacid added a comment.
@rkflx should be hopefully better now, can you have a look?
REPOSITORY
R223 Okular
BRANCH
cancellable (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid, ervin
Cc: rkflx, ervin, michaelweghorn, ngraham, #okular, aacid
aacid updated this revision to Diff 25886.
aacid added a comment.
This revision is now accepted and ready to land.
Fixed issues with cancelling tile requests
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9328?vs=25868=25886
BRANCH
cancellable (branched
aacid planned changes to this revision.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid, ervin
Cc: rkflx, ervin, michaelweghorn, ngraham, #okular, aacid
aacid added a comment.
In https://phabricator.kde.org/D9328#195391, @aacid wrote:
> In https://phabricator.kde.org/D9328#193130, @rkflx wrote:
>
> > 4. No text rendering in some situations (observed this multiple times
when wildly zooming and jumping around via the thumbnail view,
aacid updated this revision to Diff 25868.
aacid marked an inline comment as done.
aacid added a comment.
Fix crash on resizing window and assert on triggering layer updates
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9328?vs=24109=25868
BRANCH
aacid marked 9 inline comments as done.
aacid added a comment.
In https://phabricator.kde.org/D9328#193130, @rkflx wrote:
> First things first: The patch marks an impressive improvement in
(perceived) drawing performance for slow-rendering PDFs, I'm glad your hard
work payed off.
>
rkflx added a comment.
First things first: The patch marks an impressive improvement in (perceived)
drawing performance for slow-rendering PDFs, I'm glad your hard work payed off.
See below for some minor comments regarding the code, but obviously I lack
Okular/Poppler knowledge to
aacid added a subscriber: rkflx.
aacid added a comment.
@ngraham @rkflx It would be great if you could find some time "soon" to
review this
i have work-work-time assigned for this, but as far as i understand only this
month, so if you find there's changes needed it would be great if it
ervin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R223 Okular
BRANCH
cancellable (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid, ervin
Cc: ervin, michaelweghorn, ngraham, #okular, gassaf, aacid
aacid added a comment.
Added the qAsConst
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid, ervin
Cc: ervin, michaelweghorn, ngraham, #okular, gassaf, aacid
aacid updated this revision to Diff 24109.
aacid marked 2 inline comments as done.
aacid added a comment.
Add qAsConst
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9328?vs=23970=24109
BRANCH
cancellable (branched from master)
REVISION DETAIL
ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Couple of smaller issues. Otherwise I didn't spot anything which looked very
wrong to me, admittedly I don't know much about okular though.
INLINE COMMENTS
> document.cpp:3269
> +
michaelweghorn added a comment.
In https://phabricator.kde.org/D9328#179915, @aacid wrote:
> @michaelweghorn can you give it a try with the new version of the patch?
This should make it better.
It does, thanks! I can no longer reproduce with the new version of the patch.
aacid added a comment.
@michaelweghorn can you give it a try with the new version of the patch? This
should make it better.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D9328
To: aacid
Cc: michaelweghorn, ngraham, #okular, gassaf, aacid
aacid updated this revision to Diff 23970.
aacid added a comment.
Better way to ensure the text generation thread always start after the pixmap
one
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9328?vs=23951=23970
BRANCH
cancellable (branched from
aacid added a comment.
In https://phabricator.kde.org/D9328#179878, @michaelweghorn wrote:
> I tested this a bit and find it really nice that rendering of the actual
page (rather than the thumbnail) usually starts at once when re-rendering is
needed (e.g. when zoom level is changed).
michaelweghorn added a comment.
I tested this a bit and find it really nice that rendering of the actual page
(rather than the thumbnail) usually starts at once when re-rendering is needed
(e.g. when zoom level is changed).
Also, closing Okular now works fast, even if rendering is still in
aacid updated this revision to Diff 23951.
aacid added a comment.
Made a mistake while cleaning up and the previous code didn't really work ^_^
REPOSITORY
R223 Okular
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9328?vs=23910=23951
BRANCH
cancellable (branched from master)
aacid created this revision.
Restricted Application added a subscriber: Okular.
Restricted Application added a project: Okular.
REVISION SUMMARY
Only supported by the pdf backend if using poppler >= 0.63
Sadly had to change the generator API
TEST PLAN
Needs
31 matches
Mail list logo
