Right, then go with your approach. I'd default to the desktop one
which is the one most people are after I guess. It's annoying when
projects don't build by default.
Aleix
On Mon, Jan 27, 2020 at 11:53 PM Albert Astals Cid wrote:
>
> El dilluns, 27 de gener de 2020, a les 1:10:08 CET, Aleix Pol
El dilluns, 27 de gener de 2020, a les 1:10:08 CET, Aleix Pol va escriure:
> Hi Albert,
> I'm unsure it's necessary to be this radical. IMHO, it's fine to just
> not build okularkirigami if the dependencies don't match. And
> viceversa.
What if dependencies match both? Build both?
That's
El dilluns, 27 de gener de 2020, a les 6:02:26 CET, Oliver Sander va escriure:
> > So cmake . would fail and tell you something like:
> >
> > Please specify -DOKULAR_UI=Desktop|Mobile|Both
>
> I don't mind this flag at all, but I think the build should not fail without
> it.
> That's just
Hi Albert,
I'm unsure it's necessary to be this radical. IMHO, it's fine to just
not build okularkirigami if the dependencies don't match. And
viceversa.
Aleix
On Sat, Jan 25, 2020 at 11:25 PM Albert Astals Cid wrote:
>
> Right now we build by default both the Desktop UI and the Mobile UI.
>
>
> So cmake . would fail and tell you something like:
>
> Please specify -DOKULAR_UI=Desktop|Mobile|Both
I don't mind this flag at all, but I think the build should not fail without it.
That's just one more hurdle to pass for newcomers.
Best,
Oliver
smime.p7s
Description: S/MIME
неділя, 26 січня 2020 р. 00:25:32 EET Albert Astals Cid написано:
> Right now we build by default both the Desktop UI and the Mobile UI.
>
> In my opinion, for the user, that doesn't make sense, you either want one
> installed or the other installed, but not both.
>
> On the other hand, it makes
Right now we build by default both the Desktop UI and the Mobile UI.
In my opinion, for the user, that doesn't make sense, you either want one
installed or the other installed, but not both.
On the other hand, it makes lots of sense for CI and for developers, because
you don't want to break
