Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-22 Thread Dileep Sankhla
Hello Albert, > Are you speaking of not having that for the new tool or removing it > altogether? I'm just suggesting to not have the hover icon for the new typewriter tool. We should not remove it for the inline note. What do you finally suggest? Thanks and Regards, Dileep

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-22 Thread Albert Astals Cid
El diumenge, 20 de maig de 2018, a les 11:52:04 CEST, Dileep Sankhla va escriure: > Hi Albert, > ‌ > > On Sun, May 20, 2018 at 3:02 PM, Albert Astals Cid wrote: > > El divendres, 18 de maig de 2018, a les 17:04:09 CEST, Dileep Sankhla va > > > > escriure: > > > Hello everyone, >

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-22 Thread Dileep Sankhla
Hello everyone, > Basically, annotation color is set as a common attribute to all annotation >> types at the end of the file and if we should bypass it with an if >> condition that will set annotation color for type "typewriter" hardcoded >> to >> QColor(255,255,255,0). >> I have tried

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-21 Thread Tobias Deiminger
Am 21.05.2018 11:18 schrieb Albert Astals Cid: El diumenge, 20 de maig de 2018, a les 13:38:42 CEST, Tobias Deiminger va escriure: Hi, this one is about saving the actual annotation (rather then the tool configuration). Am Freitag, 18. Mai 2018, 17:04:09 CEST schrieb Dileep Sankhla: > 4. In

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-21 Thread Albert Astals Cid
El diumenge, 20 de maig de 2018, a les 13:38:42 CEST, Tobias Deiminger va escriure: > Hi, > > this one is about saving the actual annotation (rather then the tool > configuration). > > Am Freitag, 18. Mai 2018, 17:04:09 CEST schrieb Dileep Sankhla: > > 4. In

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-20 Thread Tobias Deiminger
This is about engine colors and misc. Almost through now:) Am Freitag, 18. Mai 2018, 17:04:09 CEST schrieb Dileep Sankhla: 6. tools.xml has and tags. The engine color is used - i) to colorize the overlay icon with engine color that is drawn on tool-base-okular icon for every annotation

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-20 Thread Dileep Sankhla
Thank you so much Tobias. I'm using vim editor and I was unaware of ctags. I have just installed eclipse to speed and ease up the development process. Your explanations are so vivid that I got them easily. For now, I will try demo font color selector dialog with saving the current color in the

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-20 Thread Tobias Deiminger
Hi, this one is about saving the actual annotation (rather then the tool configuration). Am Freitag, 18. Mai 2018, 17:04:09 CEST schrieb Dileep Sankhla: 4. In Okular::Annotation::Style::setColor(const QColor ), it sets d->m_color = color (see tree/core/annotations.cpp. Here d is just a

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-20 Thread Dileep Sankhla
Hi Tobias, On Sat, May 19, 2018 at 6:17 PM, Tobias Deiminger wrote: > Hi Dileep, > > that's quite a lot. I don't have enough continuous time to answer all at > once, so I just start with the first two questions. > @all: Everybody is very welcome to join discussion and

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-20 Thread Dileep Sankhla
Hi Albert, ‌ On Sun, May 20, 2018 at 3:02 PM, Albert Astals Cid wrote: > El divendres, 18 de maig de 2018, a les 17:04:09 CEST, Dileep Sankhla va > escriure: > > Hello everyone, > > > > I'm working on my GSoC project[0] with my mentor Tobias Deiminger > >

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-20 Thread Albert Astals Cid
El divendres, 18 de maig de 2018, a les 17:04:09 CEST, Dileep Sankhla va escriure: > Hello everyone, > > I'm working on my GSoC project[0] with my mentor Tobias Deiminger > and I need to add a new 'typewriter' tool to > the annotation toolbar with a new icon and a

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-19 Thread Tobias Deiminger
Hi Dileep, here's the next one. I just have to correct another typo from my former gdb examples. The conditional breakpoints must use double-equal of course, like (gdb) break KConfig::reparseConfiguration if this==0x5588f310 Now about font color... Am Freitag, 18. Mai 2018, 17:04:09

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-19 Thread Tobias Deiminger
Hi Dileep, here's a short follow up, because there was a small mistake in my former email and I forgot to answer "when it (okularpartrc) is being created". Am 18.05.2018 17:04 schrieb Dileep Sankhla: content similar to tools.xml. I need to know when it is being created and read by okular

Re: Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-19 Thread Tobias Deiminger
Hi Dileep, that's quite a lot. I don't have enough continuous time to answer all at once, so I just start with the first two questions. @all: Everybody is very welcome to join discussion and answering:) Am 18.05.2018 17:04 schrieb Dileep Sankhla: I have few things to ask before getting it

Queries regarding adding a new 'typewriter' annotation tool to the toolbar

2018-05-18 Thread Dileep Sankhla
Hello everyone, I'm working on my GSoC project[0] with my mentor Tobias Deiminger and I need to add a new 'typewriter' tool to the annotation toolbar with a new icon and a setting dialogue to customize its font [and font color]. I have few things to ask before getting