Re: Review Request 130187: CHMGenerator code modernization

2017-08-16 Thread Gilbert Assaf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130187/ --- (Updated Aug. 16, 2017, 12:53 nachm.) Status -- This change has

Re: Review Request 130187: CHMGenerator code modernization

2017-07-31 Thread Albert Astals Cid
> On July 24, 2017, 11:08 a.m., Albert Astals Cid wrote: > > i'd be happier if we don't touch the code in lib/ and kio-msits since it's > > "copied" from kchmviewer. > > > > At some point it would make sense if someone has time to go and see how > > much kchmviewer code has changed and if it

Re: Review Request 130187: CHMGenerator code modernization

2017-07-31 Thread Gilbert Assaf
> On Juli 24, 2017, 11:08 vorm., Albert Astals Cid wrote: > > i'd be happier if we don't touch the code in lib/ and kio-msits since it's > > "copied" from kchmviewer. > > > > At some point it would make sense if someone has time to go and see how > > much kchmviewer code has changed and if it

Re: Review Request 130187: CHMGenerator code modernization

2017-07-24 Thread Gilbert Assaf
> On July 24, 2017, 11:08 a.m., Albert Astals Cid wrote: > > i'd be happier if we don't touch the code in lib/ and kio-msits since it's > > "copied" from kchmviewer. > > > > At some point it would make sense if someone has time to go and see how > > much kchmviewer code has changed and if it

Re: Review Request 130187: CHMGenerator code modernization

2017-07-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130187/#review103466 --- i'd be happier if we don't touch the code in lib/ and

Review Request 130187: CHMGenerator code modernization

2017-07-20 Thread Gilbert Assaf
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130187/ --- Review request for Okular. Repository: okular Description --- -